GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Object.keys, values, entries by mahdiHash · Pull Request #137 · javascript-tutorial/fa.javascript.info

Conversation

mahdiHash commented Aug 10, 2021

Copy link

Copy Markdown

Contributor

Please review and comment / commit if anything is wrong

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mahdiHash added 7 commits

August 8, 2021 20:29


          Translate a part of article

3586e98


          Merge branch 'javascript-tutorial:master' into master

56ae7e2


          Translate a part of article

bae4c24


          Translate article

ffaf4d0


          Translate task of "sum salaries"

f3be0d0


          Translate solution of "sum salaries"

b5f5219


          Translate task of "count properties"

d12bcd0

javascript-translate-bot added the review needed label

Aug 10, 2021

javascript-translate-bot requested a review from a team

August 10, 2021 10:23

javascript-translate-bot mentioned this pull request

Aug 10, 2021

Persian (Farsi) Translation Progress #1

Open

mahdyar requested changes

Aug 10, 2021

View reviewed changes

Comment thread

1-js/05-data-types/09-keys-values-entries/01-sum-salaries/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/09-keys-values-entries/02-count-properties/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/09-keys-values-entries/02-count-properties/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Aug 10, 2021

javascript-translate-bot commented Aug 10, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Aug 10, 2021


          Apply suggestions from code review

568a4f8

Co-authored-by: Mahdyar Hasanpour <[email protected]>

mahdiHash commented Aug 10, 2021

Copy link

Copy Markdown

Contributor Author

Thank you, @mahdyar
/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Aug 10, 2021

javascript-translate-bot requested a review from a team

August 10, 2021 17:58

mahdyar requested changes

Aug 10, 2021

View reviewed changes

Comment thread

1-js/05-data-types/09-keys-values-entries/02-count-properties/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Aug 10, 2021

javascript-translate-bot commented Aug 10, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Add the English term to avoid confusion

763b022

mahdiHash commented Aug 10, 2021

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Aug 10, 2021

javascript-translate-bot requested a review from a team

August 10, 2021 19:22

javascript-translate-bot removed the review needed label

Aug 10, 2021

mahdyar approved these changes

Aug 10, 2021

View reviewed changes

mahdyar left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mahdiHashemi14!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added the needs +1 label

Aug 10, 2021

mahdyar merged commit 020a7be into javascript-tutorial:master

Aug 10, 2021

javascript-translate-bot commented Aug 10, 2021

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

mahdyar

mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.