GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Rest parameters and spread syntax by Amirhossein-Veysi · Pull Request #142 · javascript-tutorial/fa.javascript.info

Conversation

@Amirhossein-Veysi

@Amirhossein-Veysi Amirhossein-Veysi commented Aug 31, 2021

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Amirhossein-Veysi added 7 commits August 31, 2021 17:59
@Amirhossein-Veysi
Translated article
f97c409
@Amirhossein-Veysi
Translated article
e279e80
@Amirhossein-Veysi
Translated article
da80381
@Amirhossein-Veysi
Translated article
5f631bf
@Amirhossein-Veysi
Translated article
3a93941
@Amirhossein-Veysi
Translated article
c21c674
@Amirhossein-Veysi
Translated article
39f90a9
@javascript-translate-bot javascript-translate-bot added the review needed label Aug 31, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team August 31, 2021 14:07
@CLAassistant

CLAassistant commented Aug 31, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot mentioned this pull request Aug 31, 2021
Persian (Farsi) Translation Progress #1
Open
Amirhossein-Veysi added 3 commits September 1, 2021 10:18
@Amirhossein-Veysi
Change argument to arguments
557028f
@Amirhossein-Veysi
Add URL to spread-syntax
0c8edd7
@Amirhossein-Veysi
Change some words
c30a1cc
@mahdyar

mahdyar commented Sep 1, 2021

Copy link
Copy Markdown
Member

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @Amirhossein-Veysi and thank you for your contribution;
You should first sign the CLA before I can review your translation, so I mark this as draft since it's not yet ready to be reviewed.
Feel free to mark it as "Ready for review" whenever it was ready. :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mahdyar
mahdyar marked this pull request as draft September 1, 2021 07:35
@Amirhossein-Veysi
Amirhossein-Veysi marked this pull request as ready for review September 1, 2021 09:07
mahdyar
mahdyar requested changes Sep 1, 2021
View reviewed changes
Comment thread 1-js/06-advanced-functions/02-rest-parameters-spread/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/06-advanced-functions/02-rest-parameters-spread/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/06-advanced-functions/02-rest-parameters-spread/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/06-advanced-functions/02-rest-parameters-spread/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/06-advanced-functions/02-rest-parameters-spread/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/06-advanced-functions/02-rest-parameters-spread/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/06-advanced-functions/02-rest-parameters-spread/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/06-advanced-functions/02-rest-parameters-spread/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/06-advanced-functions/02-rest-parameters-spread/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/06-advanced-functions/02-rest-parameters-spread/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Sep 1, 2021
@javascript-translate-bot

javascript-translate-bot commented Sep 1, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Amirhossein-Veysi added 7 commits September 1, 2021 20:57
@Amirhossein-Veysi
Problems solved
88a1e4c
@Amirhossein-Veysi
Problems solved
7043ee1
@Amirhossein-Veysi
Some problems resolved
fd76e66
@Amirhossein-Veysi
All problems solved
31f6fed
@Amirhossein-Veysi
Fixed line 122
1ee2e38
@Amirhossein-Veysi
Some problems solved
43d6a3f
@Amirhossein-Veysi
Some problems sovled
db608e9
@Amirhossein-Veysi

Amirhossein-Veysi commented Sep 2, 2021

Copy link
Copy Markdown
Contributor Author

Hi, Thanks for your review @mahdyar, I tried to solve all problems and now there's no problem, there might be some issue in preview and the reason is the line 122 which wraps the rest of the lines in a code section.
/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the changes requested label Sep 2, 2021
mahdyar
mahdyar requested changes Sep 2, 2021
View reviewed changes
Comment thread 1-js/06-advanced-functions/02-rest-parameters-spread/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Sep 2, 2021
@javascript-translate-bot

javascript-translate-bot commented Sep 2, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Sep 2, 2021
@Amirhossein-Veysi
new line added
25180f1
@Amirhossein-Veysi

Amirhossein-Veysi commented Sep 2, 2021

Copy link
Copy Markdown
Contributor Author

The issue resolved. /done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Sep 2, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team September 2, 2021 08:56
mahdyar
mahdyar requested changes Sep 2, 2021
View reviewed changes
Comment thread 1-js/06-advanced-functions/02-rest-parameters-spread/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/06-advanced-functions/02-rest-parameters-spread/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/06-advanced-functions/02-rest-parameters-spread/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Sep 2, 2021
@javascript-translate-bot

javascript-translate-bot commented Sep 2, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Sep 2, 2021
@Amirhossein-Veysi
Issues solved
c1195f0
@Amirhossein-Veysi

Amirhossein-Veysi commented Sep 2, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Should i replace commas in the commented section of codes that are translated? @mahdyar

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mahdyar

mahdyar commented Sep 2, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Should i replace commas in the commented section of codes that are translated? @mahdyar

It's up to you, but I wouldn't.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Amirhossein-Veysi added 5 commits September 2, 2021 14:24
@Amirhossein-Veysi
Some issues resolved
cad24d7
@Amirhossein-Veysi
Fixed
b92e458
@Amirhossein-Veysi
Fixed
33aa375
@Amirhossein-Veysi
Fixed
59ab60a
@Amirhossein-Veysi
All issues fixed
6b61722
@Amirhossein-Veysi

Amirhossein-Veysi commented Sep 2, 2021

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Sep 2, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team September 2, 2021 10:25
@javascript-translate-bot javascript-translate-bot removed the review needed label Sep 2, 2021
mahdyar
mahdyar approved these changes Sep 2, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Amirhossein-Veysi!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@javascript-translate-bot javascript-translate-bot added the needs +1 label Sep 2, 2021
@mahdyar
mahdyar merged commit dff1c54 into javascript-tutorial:master Sep 2, 2021
@javascript-translate-bot

javascript-translate-bot commented Sep 2, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Amirhossein-Veysi @CLAassistant @mahdyar @javascript-translate-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.