GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Mouse events by erfanyeganegi · Pull Request #149 · javascript-tutorial/fa.javascript.info

Conversation

erfanyeganegi commented Sep 10, 2021

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          mouse-event-basics

255c30a

javascript-translate-bot added the review needed label

Sep 10, 2021

javascript-translate-bot requested a review from a team

September 10, 2021 07:51

mahdyar changed the title ~~mouse-event-basics~~ Mouse events

Sep 10, 2021

mahdyar mentioned this pull request

Sep 10, 2021

Persian (Farsi) Translation Progress #1

Open

mahdyar requested changes

Sep 10, 2021

View reviewed changes

mahdyar left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @erfanyeganegi and thank you for your contribution!
Please consider naming your PR after the article name for future PRs (Read the readme if you haven't):

PR title should match article title, the bot will write it's number into the issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

2-ui/3-event-details/1-mouse-events-basics/01-selectable-list/solution.view/index.html Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/1-mouse-events-basics/01-selectable-list/solution.view/index.html Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/1-mouse-events-basics/head.html Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Sep 10, 2021

javascript-translate-bot commented Sep 10, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Sep 10, 2021

erfanyeganegi added 4 commits

September 10, 2021 14:16


          Update index.html

18e169c

make the requested changes.


          Revert "mouse-event-basics"

7927eae

This reverts commit 255c30a.


          Update article.md

65a7114

made the requested changes and improved translation.


          requested changes done

550e42c

erfanyeganegi commented Sep 10, 2021

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Sep 10, 2021

javascript-translate-bot requested a review from a team

September 10, 2021 10:04

mahdyar requested changes

Sep 10, 2021

View reviewed changes

mahdyar left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned some of the problems below, please check it again for any similar problems.
Line numbers shouldn't change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

2-ui/3-event-details/1-mouse-events-basics/article.md Outdated

Comment on lines +59 to +65

		\| `event.button` \| وضعیت کلید \|
		\| -------------- \| ----------------- \|
		\| 0 \| کلید چپ (اصلی) \|
		\| 1 \| کلید وسط (کمکی) \|
		\| 2 \| کلید راست (ثانوی) \|
		\| 3 \| کلید X1 (عقب) \|
		\| 4 \| کلید X2 (جلو) \|

mahdyar Sep 10, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't add spaces here either.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

2-ui/3-event-details/1-mouse-events-basics/article.md Outdated

		};
		</script>
		```
		````

mahdyar Sep 10, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't change the format of the article. The last back quote is extra.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

2-ui/3-event-details/1-mouse-events-basics/article.md Outdated


		```warn header="Attention: on Mac it's usually `Cmd` instead of `Ctrl`"
		On Windows and Linux there are modifier keys `key:Alt`, `key:Shift` and `key:Ctrl`. On Mac there's one more: `key:Cmd`, corresponding to the property `metaKey`.
		```warn header="توجه: روی مک معمولا `Cmd`بجای`Ctrl`خواهد بود" روی ویندوز و لینوکس کلیدهای اصلاح‌کننده `key:Alt`, `key:Shift`و`key:Ctrl`وجود خواهد داشت. روی مک یک کلید دیگر نیز وجود دارد: `key:Cmd`, متناظر خاصیت `metaKey`.

mahdyar Sep 10, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't merge them in one line.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added changes requested and removed review needed labels

Sep 10, 2021

javascript-translate-bot commented Sep 10, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Update article.md

eb4714f

erfanyeganegi commented Sep 10, 2021

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Sep 10, 2021

javascript-translate-bot requested a review from a team

September 10, 2021 20:15

mahdyar approved these changes

Sep 11, 2021

View reviewed changes

mahdyar left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @erfanyeganegi!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Sep 11, 2021

mahdyar merged commit c0c5540 into javascript-tutorial:master

Sep 11, 2021

javascript-translate-bot commented Sep 11, 2021

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erfanyeganegi deleted the mouse-event-basics branch

September 11, 2021 11:23

Reviewers

mahdyar

mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.