GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Variable scope, closure by mahdiHash · Pull Request #150 · javascript-tutorial/fa.javascript.info

Conversation

mahdiHash commented Sep 10, 2021

Copy link

Copy Markdown

Contributor

Please review and comment / commit if anything is wrong

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mahdiHash added 30 commits

September 3, 2021 12:01


          Translate a part of article

02bb058


          Translate a part of article

c804c16


          Translate some error messages

1da9b01

The error messages written as comments are not exactly what the browser shows us, so I decided to translate them.


          Translate a part of article

8e30e70


          Translate a part of article

a030eca


          Translate a part of article

efb7c91


          Translate a part of article

b420819


          Change some lines for better readability or understanding

645cfdc


          Translate a part of article

3b97485


          Translate a part of article

d4a1f7d


          Translate article

80f180f


          Translate task of "closure-latest-changes"

67c299e


          Translate solution of "closure-latest-changes"

328b3a9


          Translate task of "closure-variable-access"

1a91fdf


          Translate solution of "closure-variable-access"

c0360a3


          Translate task of "counter-independent"

1698afa


          Translate solution of "counter-independent"

539ffcf


          Translate task of "counter-object-independent"

3f88e03


          Translate task of "counter-object-independent"

684a4d2


          Translate task of "function-in-if"

c641e77


          Translate solution of "function-in-if"

0654b5d


          Translate task of "closure-sum"

f8c0af6


          Translate solution of "closure-sum"

6b9c591


          Translate task of "let-scope"

8dc9297


          Translate solution of "let-scope"

ef57382


          Change a comment for better readability

26678cb


          Translate task of "filter-through-function"

eb9f373


          Translate task of "sort-by-field"

53eaa4a


          Translate task of "make-army"

5dfb504


          Translate solution of "make-army"

d22754e


          Translate a word

b7290e2

javascript-translate-bot added the review needed label

Sep 10, 2021

javascript-translate-bot requested a review from a team

September 10, 2021 10:23

javascript-translate-bot mentioned this pull request

Sep 10, 2021

Persian (Farsi) Translation Progress #1

Open

mahdyar requested changes

Sep 10, 2021

View reviewed changes

Comment thread

1-js/06-advanced-functions/03-closure/1-closure-latest-changes/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/06-advanced-functions/03-closure/2-closure-variable-access/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Sep 10, 2021

javascript-translate-bot commented Sep 10, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash added 2 commits

September 10, 2021 19:49


          Add the deleted line

d238e45


          Remove the untranslated line

f973524

mahdiHash commented Sep 10, 2021

Copy link

Copy Markdown

Contributor Author

Thank you @mahdyar
/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Sep 10, 2021

javascript-translate-bot requested a review from a team

September 10, 2021 15:23

mahdyar approved these changes

Sep 10, 2021

View reviewed changes

mahdyar left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mahdiHashemi14!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Sep 10, 2021

mahdyar merged commit a6d5582 into javascript-tutorial:master

Sep 10, 2021

javascript-translate-bot commented Sep 10, 2021

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

mahdyar

mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.