GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Arrow functions revisited by mahdiHash · Pull Request #166 · javascript-tutorial/fa.javascript.info

Conversation

mahdiHash commented Oct 30, 2021

Copy link

Copy Markdown

Contributor

Please review and comment/commit if anything is wrong

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mahdiHash added 3 commits

October 28, 2021 13:24


          Translate a part of article

9bf1832


          Translate a part of article

b7effda


          Translate article

b8dfb45

Line 126 needs more attention

javascript-translate-bot added the review needed label

Oct 30, 2021

javascript-translate-bot requested a review from a team

October 30, 2021 13:42

javascript-translate-bot mentioned this pull request

Oct 30, 2021

Persian (Farsi) Translation Progress #1

Open

mahdiHash commented

Oct 30, 2021

View reviewed changes

Comment thread

1-js/06-advanced-functions/12-arrow-functions/article.md Outdated

		- همچنین آن‌ها `super` ندارند اما هنوز آن را نخوانده‌ایم. در فصل <info:class-inheritance> آن را خواهیم خواند

		That's because they are meant for short pieces of code that do not have their own "context", but rather work in the current one. And they really shine in that use case.
		به دلیل اینکه آن‌ها برای قطعه‌های کوتاهی از کد در نظر گرفته شده‌اند که «زمینه» خودشان را ندارند و در زمینه کنونی کار می‌کنند. و آن‌ها واقعا در این مورد استفاده می‌درخشند.

mahdiHash Oct 30, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line needs more attention

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mahdyar Oct 30, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	به دلیل اینکه آن‌ها برای قطعه‌های کوتاهی از کد در نظر گرفته شده‌اند که «زمینه» خودشان را ندارند و در زمینه کنونی کار می‌کنند. و آن‌ها واقعا در این مورد استفاده می‌درخشند.
	به دلیل اینکه آن‌ها برای قطعه‌های کوتاهی از کد در نظر گرفته شده‌اند که «موقعیت»(context) خودشان را ندارند و در موقعیت کنونی کار می‌کنند. و آن‌ها واقعا در این مورد استفاده کاربرد دارند.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mahdiHash Oct 30, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I translated "context" as "زمینه" in other articles. I think "موقعیت" is a good translation for "position" or "location" or something like this.
I'll add the English term in parentheses.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mahdiHash marked this pull request as ready for review

October 30, 2021 13:43

mahdyar requested changes

Oct 30, 2021

View reviewed changes

Comment thread

1-js/06-advanced-functions/12-arrow-functions/article.md Outdated

		- همچنین آن‌ها `super` ندارند اما هنوز آن را نخوانده‌ایم. در فصل <info:class-inheritance> آن را خواهیم خواند

		That's because they are meant for short pieces of code that do not have their own "context", but rather work in the current one. And they really shine in that use case.
		به دلیل اینکه آن‌ها برای قطعه‌های کوتاهی از کد در نظر گرفته شده‌اند که «زمینه» خودشان را ندارند و در زمینه کنونی کار می‌کنند. و آن‌ها واقعا در این مورد استفاده می‌درخشند.

mahdyar Oct 30, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	به دلیل اینکه آن‌ها برای قطعه‌های کوتاهی از کد در نظر گرفته شده‌اند که «زمینه» خودشان را ندارند و در زمینه کنونی کار می‌کنند. و آن‌ها واقعا در این مورد استفاده می‌درخشند.
	به دلیل اینکه آن‌ها برای قطعه‌های کوتاهی از کد در نظر گرفته شده‌اند که «موقعیت»(context) خودشان را ندارند و در موقعیت کنونی کار می‌کنند. و آن‌ها واقعا در این مورد استفاده کاربرد دارند.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/06-advanced-functions/12-arrow-functions/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Oct 30, 2021

javascript-translate-bot commented Oct 30, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Apply a suggestion from code review

a9ccff6

Co-authored-by: Mahdyar Hasanpour <[email protected]>

mahdiHash commented Oct 30, 2021

Copy link

Copy Markdown

Contributor Author

Thank you @mahdyar
/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Oct 30, 2021

javascript-translate-bot requested a review from a team

October 30, 2021 17:39


          Add English term

1152e75

mahdyar approved these changes

Oct 31, 2021

View reviewed changes

mahdyar left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;
Thank you, @mahdiHashemi14!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Oct 31, 2021

mahdyar merged commit acad004 into javascript-tutorial:master

Oct 31, 2021

javascript-translate-bot commented Oct 31, 2021

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

mahdyar

mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

mahdiHash commented Oct 30, 2021

Uh oh!

mahdiHash Oct 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mahdyar Oct 30, 2021

Choose a reason for hiding this comment

Uh oh!

mahdiHash Oct 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mahdyar Oct 30, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

javascript-translate-bot commented Oct 30, 2021

Uh oh!

mahdiHash commented Oct 30, 2021

Uh oh!

mahdyar left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Oct 31, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mahdiHash Oct 30, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash Oct 30, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.