GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Property getters and setters by mahdiHash · Pull Request #170 · javascript-tutorial/fa.javascript.info

Conversation

@mahdiHash

@mahdiHash mahdiHash commented Nov 11, 2021

Copy link
Copy Markdown
Contributor

Please review and comment/commit if anything is wrong

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mahdiHash added 8 commits November 8, 2021 14:42
@mahdiHash
Translate a part of article
47c0b5c
@mahdiHash
Merge branch 'javascript-tutorial:master' into master
e2803f2
@mahdiHash
Translate a part of article
f12e386
@mahdiHash
Translate a part of article
8f7bb07
@mahdiHash
Add some words in the beginning of lines: 107 to 110
c10e888 
The lines 107 to 110 were started from left, because there were English words in the beginning, and they didn't look nice.  
I added Persian words in the beginning, so the lines start from right.
@mahdiHash
Translate a part of article
c6766c6
@mahdiHash
Typo
72cf053
@mahdiHash
Translate article
8d89f69 
Line 188 needs more attention
@javascript-translate-bot javascript-translate-bot added the review needed label Nov 11, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team November 11, 2021 13:31
@javascript-translate-bot javascript-translate-bot mentioned this pull request Nov 11, 2021
Persian (Farsi) Translation Progress #1
Open
mahdiHash
mahdiHash commented Nov 11, 2021
View reviewed changes
Comment thread 1-js/07-object-properties/02-property-accessors/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mahdiHash
mahdiHash marked this pull request as ready for review November 11, 2021 13:35
mahdyar
mahdyar requested changes Nov 11, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the requested changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Nov 11, 2021
@javascript-translate-bot

javascript-translate-bot commented Nov 11, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mahdiHash
Apply suggestions from code review
99c06bf 
Co-authored-by: Mahdyar Hasanpour <[email protected]>
Replaced «گیرنده» with "getter"  
Replaced «تنظیم‌کننده» with "setter"  
Replaced «دسترسی» with «اکسسر»  

And some small changes:  
- Fixed a typo in line 203  
- Also changed a word in lines 108 and 143
@mahdiHash

mahdiHash commented Nov 11, 2021

Copy link
Copy Markdown
Contributor Author

Thank you @mahdyar
/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Nov 11, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team November 11, 2021 19:22
mahdyar
mahdyar approved these changes Nov 12, 2021
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Nov 12, 2021
@mahdyar
mahdyar merged commit 4d2b165 into javascript-tutorial:master Nov 12, 2021
@javascript-translate-bot

javascript-translate-bot commented Nov 12, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mahdiHash @javascript-translate-bot @mahdyar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.