GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Object to primitive conversion by mahdiHash · Pull Request #177 · javascript-tutorial/fa.javascript.info

Conversation

@mahdiHash

@mahdiHash mahdiHash commented Nov 25, 2021

Copy link
Copy Markdown
Contributor

Please review and comment/commit if anything is wrong

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mahdiHash added 7 commits November 22, 2021 09:07
@mahdiHash
Translate a part of article
7cbd081 
Lines 12 and 14 need more attention.
@mahdiHash
Translate a part of article
595d69a 
This part (conversion rules) needs more attention.
It was complicated.
@mahdiHash
Translate a part of article
1fa4aa0
@mahdiHash
Translate a part of article
29d0b5c 
Line 139 needs more attention
@mahdiHash
Translate a part of article
267f846
@mahdiHash
Translate article
8de3bf3 
Lines 253, 275 and 277 need more attention.
@mahdiHash
Merge branch 'master' of https://github.com/mahdihashemi14/fa.javascr…
d8a6677 
…ipt.info
@javascript-translate-bot javascript-translate-bot added the review needed label Nov 25, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team November 25, 2021 11:23
@javascript-translate-bot javascript-translate-bot mentioned this pull request Nov 25, 2021
Persian (Farsi) Translation Progress #1
Open
mahdiHash
mahdiHash commented Nov 25, 2021
View reviewed changes
Comment thread 1-js/04-object-basics/09-object-toprimitive/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
mahdiHash
mahdiHash commented Nov 25, 2021
View reviewed changes
Comment thread 1-js/04-object-basics/09-object-toprimitive/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
mahdiHash
mahdiHash commented Nov 25, 2021
View reviewed changes
Comment thread 1-js/04-object-basics/09-object-toprimitive/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mahdiHash
mahdiHash marked this pull request as ready for review November 25, 2021 11:26
mahdyar
mahdyar approved these changes Nov 25, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestion(s).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Nov 25, 2021
mahdyar
mahdyar requested changes Nov 25, 2021
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestion(s).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added the changes requested label Nov 25, 2021
@javascript-translate-bot

javascript-translate-bot commented Nov 25, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mahdiHash @mahdyar
Apply suggestions from code review
2a31b9f 
Co-authored-by: Mahdyar Hasanpour <[email protected]>
@mahdiHash

mahdiHash commented Nov 25, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Thank you @mahdyar
I also have a question: do you think "جزء" is a good translation for "hint"? For example in line 35.

/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Nov 25, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team November 25, 2021 17:45
mahdyar
mahdyar approved these changes Nov 26, 2021
View reviewed changes

@mahdyar mahdyar left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mahdyar
I also have a question: do you think "جزء" is a good translation for "hint"? For example in line 35.
/done

Yes, that LGTM.
Thank you, @mahdiHashemi14!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mahdyar
mahdyar merged commit 0e66dd1 into javascript-tutorial:master Nov 26, 2021
@javascript-translate-bot

javascript-translate-bot commented Nov 26, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1 review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mahdiHash @javascript-translate-bot @mahdyar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.