GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Private and protected properties and methods by mahdiHash · Pull Request #182 · javascript-tutorial/fa.javascript.info

Conversation

mahdiHash commented Dec 20, 2021

Copy link

Copy Markdown

Contributor

Please review and comment/commit if anything is wrong

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mahdiHash added 8 commits

December 15, 2021 23:35


          Translate a part of article

26d728e

Line 6 needs more attention


          Translate a part of article

4de10f8


          Translate a part of article

d87dc2d

Line 41 needs more attention


          Translate a part of article

8e146e8


          Translate a part of article

076ab8e

Line 128 needs more attention


          Change «ویژگی» to «فیلد» in the headers

07d8631


          Translate a part of article

6d47e5f


          Translate article

861b06b

Lines 306, 308, and 322 need more attention.

javascript-translate-bot added the review needed label

Dec 20, 2021

javascript-translate-bot requested a review from a team

December 20, 2021 09:31

javascript-translate-bot mentioned this pull request

Dec 20, 2021

Persian (Farsi) Translation Progress #1

Open

mahdiHash commented

Dec 20, 2021

View reviewed changes

Comment thread

1-js/09-classes/04-private-protected-properties-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash commented

Dec 20, 2021

View reviewed changes

Comment thread

1-js/09-classes/04-private-protected-properties-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash commented

Dec 20, 2021

View reviewed changes

Comment thread

1-js/09-classes/04-private-protected-properties-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash commented

Dec 20, 2021

View reviewed changes

Comment thread

1-js/09-classes/04-private-protected-properties-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash commented

Dec 20, 2021

View reviewed changes

Comment thread

1-js/09-classes/04-private-protected-properties-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash commented

Dec 20, 2021

View reviewed changes

Comment thread

1-js/09-classes/04-private-protected-properties-methods/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash marked this pull request as ready for review

December 20, 2021 09:35

mahdyar requested changes

Dec 23, 2021

View reviewed changes

mahdyar left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the requested changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot removed the review needed label

Dec 23, 2021

javascript-translate-bot commented Dec 23, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Dec 23, 2021


          Apply suggestions from code review

1dcd92e

Co-authored-by: Mahdyar Hasanpour <[email protected]>

mahdiHash commented Dec 23, 2021

Copy link

Copy Markdown

Contributor Author

Thank you @mahdyar
/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Dec 23, 2021

javascript-translate-bot requested a review from a team

December 23, 2021 16:19

mahdyar approved these changes

Dec 24, 2021

View reviewed changes

mahdyar left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mahdiHash!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added needs +1 and removed review needed labels

Dec 24, 2021

mahdyar merged commit 4964d5d into javascript-tutorial:master

Dec 24, 2021

javascript-translate-bot commented Dec 24, 2021

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

mahdyar

mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.