GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Class checking: "instanceof" by mahdiHash · Pull Request #186 · javascript-tutorial/fa.javascript.info

Conversation

@mahdiHash

@mahdiHash mahdiHash commented Jan 3, 2022

Copy link
Copy Markdown
Contributor

Please review and comment/commit if anything is wrong.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mahdiHash added 6 commits December 31, 2021 22:05
@mahdiHash
Translate a part of article
731a3fb
@mahdiHash
Translate a part of article
93b95e6
@mahdiHash
Translate a part of article
9bae254 
Line 203 needs more attention (translation of "types on steroids")
@mahdiHash
Translate article
1d7efa8 
Line 219 needs more attention
@mahdiHash
Merge branch 'master' of https://github.com/mahdiHash/fa.javascript.info
cd20212
@mahdiHash
Translate "strange-instanceof" task and solution
fd75bbe
@javascript-translate-bot javascript-translate-bot added the review needed label Jan 3, 2022
@javascript-translate-bot
javascript-translate-bot requested a review from a team January 3, 2022 10:50
@javascript-translate-bot javascript-translate-bot mentioned this pull request Jan 3, 2022
Persian (Farsi) Translation Progress #1
Open
@mahdiHash
Remove an untranslated line
3d20a3f
mahdiHash
mahdiHash commented Jan 3, 2022
View reviewed changes
Comment thread 1-js/09-classes/06-instanceof/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
mahdiHash
mahdiHash commented Jan 3, 2022
View reviewed changes
Comment thread 1-js/09-classes/06-instanceof/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
mahdiHash
mahdiHash commented Jan 3, 2022
View reviewed changes
Comment thread 1-js/09-classes/06-instanceof/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mahdiHash
mahdiHash marked this pull request as ready for review January 3, 2022 10:57
@mahdiHash @mahdyar
Apply suggestions from code review
5f77253 
Co-authored-by: Mahdyar Hasanpour <[email protected]>
mahdyar
mahdyar requested changes Jan 3, 2022
View reviewed changes

@mahdyar mahdyar left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggested changes and request for another review.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Jan 3, 2022
@javascript-translate-bot

javascript-translate-bot commented Jan 3, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mahdiHash @mahdyar
Apply suggestions from code review
98d3fb6 
Co-authored-by: Mahdyar Hasanpour <[email protected]>
@mahdiHash

mahdiHash commented Jan 3, 2022

Copy link
Copy Markdown
Contributor Author

Thank you @mahdyar
/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Jan 3, 2022
@javascript-translate-bot
javascript-translate-bot requested a review from a team January 3, 2022 18:19
@mahdyar

mahdyar commented Jan 3, 2022

Copy link
Copy Markdown
Member

Thank you, @mahdiHash!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mahdyar
mahdyar approved these changes Jan 3, 2022
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Jan 3, 2022
@mahdyar
mahdyar merged commit 9d81a18 into javascript-tutorial:master Jan 3, 2022
@javascript-translate-bot

javascript-translate-bot commented Jan 3, 2022

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mahdiHash @javascript-translate-bot @mahdyar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.