GeezerVison is showing github.com — Operators by kooshan75 · Pull Request #19 · javascript-tutorial/fa.javascript.info
Conversation
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
mehradsadeghi
left a comment
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the article.docx file.
I'm not sure about the translations inside code blocks, because the final result of these translations will be shown RTL and the code blocks will be LTR. So how the Persian characters inside code blocks will be shown ?
Give me your opinion @kooshan75 .
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Please remove the article.docx file.
I'm not sure about the translations inside code blocks, because the final result of these translations will be shown RTL and the code blocks will be LTR. So how the Persian characters inside code blocks will be show ?
Give me your opinion @kooshan75 .
I deleted article.docx file in my first commit. Did I do something wrong?
Ummm, about this RTL thing: I don't think there'd be a problem. Since code blocks are LTR, if there's a Persian comment in those code blocks, it would've been shown correctly, but if there's an English word in between of Persian words, it would mess up the whole sentence. Even in this case, we can easily handle it with adding a js file which fixes these edge cases in code blocks. With all these being said, I can still undo those changes at your request.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Please remove the article.docx file.
I'm not sure about the translations inside code blocks, because the final result of these translations will be shown RTL and the code blocks will be LTR. So how the Persian characters inside code blocks will be show ?
Give me your opinion @kooshan75 .
I deleted article.docx file in my first commit. Did I do something wrong?
Ummm, about this RTL thing: I don't think there'd be a problem. Since code blocks are LTR, if there's a Persian comment in those code blocks, it would've been shown correctly, but if there's an English word in between of Persian words, it would mess up the whole sentence. Even in this case, we can easily handle it with adding a js file which fixes these edge cases in code blocks. With all these being said, I can still undo those changes at your request.
It's OK. Thank you @kooshan75 .
|
kooshan75 reacted with heart emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|