GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Operators by kooshan75 · Pull Request #19 · javascript-tutorial/fa.javascript.info

Conversation

@kooshan75

@kooshan75 kooshan75 commented Jul 10, 2019

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
kooshan75 added 2 commits July 10, 2019 15:04
@kooshan75
translated article.md and deleted docx file
b2c95a8
@kooshan75
translated tasks, solutions & index.md
673979f
@javascript-translate-bot javascript-translate-bot added the review needed label Jul 10, 2019
@javascript-translate-bot
javascript-translate-bot requested a review from a team July 10, 2019 11:24
@iliakan iliakan mentioned this pull request Jul 10, 2019
Persian (Farsi) Translation Progress #1
Open
mehradsadeghi
mehradsadeghi previously requested changes Jul 10, 2019
View reviewed changes

@mehradsadeghi mehradsadeghi left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the article.docx file.
I'm not sure about the translations inside code blocks, because the final result of these translations will be shown RTL and the code blocks will be LTR. So how the Persian characters inside code blocks will be shown ?
Give me your opinion @kooshan75 .

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Jul 10, 2019
@javascript-tutorial javascript-tutorial deleted a comment from javascript-translate-bot Jul 10, 2019
@kooshan75

kooshan75 commented Jul 10, 2019

Copy link
Copy Markdown
Contributor Author

Please remove the article.docx file.
I'm not sure about the translations inside code blocks, because the final result of these translations will be shown RTL and the code blocks will be LTR. So how the Persian characters inside code blocks will be show ?
Give me your opinion @kooshan75 .

I deleted article.docx file in my first commit. Did I do something wrong?
Ummm, about this RTL thing: I don't think there'd be a problem. Since code blocks are LTR, if there's a Persian comment in those code blocks, it would've been shown correctly, but if there's an English word in between of Persian words, it would mess up the whole sentence. Even in this case, we can easily handle it with adding a js file which fixes these edge cases in code blocks. With all these being said, I can still undo those changes at your request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mehradsadeghi
mehradsadeghi dismissed their stale review July 10, 2019 12:29

It's not necessary.

@mehradsadeghi
mehradsadeghi merged commit e3cfd50 into javascript-tutorial:master Jul 10, 2019
@javascript-translate-bot

javascript-translate-bot commented Jul 10, 2019

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mehradsadeghi

mehradsadeghi commented Jul 10, 2019

Copy link
Copy Markdown
Contributor

Please remove the article.docx file.
I'm not sure about the translations inside code blocks, because the final result of these translations will be shown RTL and the code blocks will be LTR. So how the Persian characters inside code blocks will be show ?
Give me your opinion @kooshan75 .

I deleted article.docx file in my first commit. Did I do something wrong?
Ummm, about this RTL thing: I don't think there'd be a problem. Since code blocks are LTR, if there's a Persian comment in those code blocks, it would've been shown correctly, but if there's an English word in between of Persian words, it would mess up the whole sentence. Even in this case, we can easily handle it with adding a js file which fixes these edge cases in code blocks. With all these being said, I can still undo those changes at your request.

It's OK. Thank you @kooshan75 .

kooshan75 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kooshan75
kooshan75 deleted the operators branch July 10, 2019 12:36
@mehradsadeghi mehradsadeghi removed the changes requested label Jul 10, 2019
@mahdiHash mahdiHash mentioned this pull request Sep 2, 2021
Update "Basic operators, maths" #144
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mehradsadeghi mehradsadeghi mehradsadeghi left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kooshan75 @javascript-translate-bot @mehradsadeghi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.