GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Promise by Beroozam · Pull Request #197 · javascript-tutorial/fa.javascript.info

Conversation

@Beroozam

@Beroozam Beroozam commented Feb 16, 2022

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Beroozam added 25 commits January 16, 2022 13:17
@Beroozam
promise
5daaa74
@Beroozam
syntax
a42e936
@Beroozam
resolve and reject
f18594f
@Beroozam
takes time
db7e505
@Beroozam
calling after ready
79ae48f
@Beroozam
resolved
0b663d6
@Beroozam
additional arg
fefe0d7
@Beroozam
object Error
a140d3b
@Beroozam
promise resolved
c84a77a
@Beroozam
handle
0d89ed2
@Beroozam
runs first function
161c6d9
@Beroozam
catch method
0fae38d
@Beroozam
finally method
8ce413e
@Beroozam
finally pass
4cf1b49
@Beroozam
let's
b548886
@Beroozam
table
c0b9e9a
@Beroozam
re resolve solution
41ae6fc
@Beroozam
re resolve task
b3feeb0
@Beroozam
delay promise solution
8582f9d
@Beroozam
delay promise task
d92e9ee
@Beroozam
animate circle promise .html
3e223e9
@Beroozam
animate circle promise task
8bbdb2f
@Beroozam
delay promise solution2
8c021fa
@Beroozam
review
d40914b
@Beroozam
review2
ce43fa3
@javascript-translate-bot javascript-translate-bot added the review needed label Feb 16, 2022
@javascript-translate-bot
javascript-translate-bot requested a review from a team February 16, 2022 03:40
@javascript-translate-bot javascript-translate-bot mentioned this pull request Feb 16, 2022
Persian (Farsi) Translation Progress #1
Open
mahdiHash
mahdiHash suggested changes Feb 16, 2022
View reviewed changes
Comment thread 1-js/11-async/02-promise-basics/01-re-resolve/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/01-re-resolve/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/01-re-resolve/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/02-delay-promise/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Feb 16, 2022
@javascript-translate-bot

javascript-translate-bot commented Feb 16, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Feb 16, 2022
@mahdiHash

mahdiHash commented Feb 16, 2022

Copy link
Copy Markdown
Contributor

Thanks for the translation @Beroozam.
Before I submit a review for other files, I need to know the translation of "Promise".
I think "Promise" doesn't need a translation and it's fine to write it as is.
What do you think @mahdyar?

mahdyar reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mahdyar

mahdyar commented Feb 16, 2022

Copy link
Copy Markdown
Member

Thanks for the translation @Beroozam. Before I submit a review for other files, I need to know the translation of "Promise". I think "Promise" doesn't need a translation and it's fine to write it as is. What do you think @mahdyar?

I agree. it should be as it was.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Beroozam

Beroozam commented Feb 16, 2022

Copy link
Copy Markdown
Contributor Author

I had no idea about this so I wanted you to help in this translation but what do you think about the sentences that start in Persian that we put the phrase پرامیس and other places from Promise.
@mahdiHash
@mahdyar

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Beroozam @mahdiHash
Apply suggestions from code review
2d1288a
Co-authored-by: Mahdi Hashemi <[email protected]>
@mahdiHash mahdiHash added review needed and removed changes requested labels Feb 17, 2022
@mahdiHash

mahdiHash commented Feb 17, 2022

Copy link
Copy Markdown
Contributor

I had no idea about this so I wanted you to help in this translation but what do you think about the sentences that start in Persian that we put the phrase پرامیس and other places from Promise. @mahdiHash @mahdyar

If you don't know the meaning of a word/sentence and couldn't find it in the glossary, you can ask us in the Translation Help issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash
mahdiHash suggested changes Feb 17, 2022
View reviewed changes

@mahdiHash mahdiHash left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestions.
You can add the suggestions to a batch and create a commit just once (docs).
For now, ignore the suggestions of translation of "settled" until we see what @mahdyar says.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/11-async/02-promise-basics/02-delay-promise/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/02-delay-promise/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/02-delay-promise/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/03-animate-circle-promise/solution.view/index.html Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/03-animate-circle-promise/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Feb 17, 2022
@javascript-translate-bot

javascript-translate-bot commented Feb 17, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Feb 17, 2022
@mahdiHash

mahdiHash commented Feb 24, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Hi, @Beroozam.
Are you still working on the changes?
I changed my mind about translation of "settled". I think the meaning you've chosen is fine.
You can add all the suggestions to a batch and submit a commit just once (docs). You only need to separately change the lines which have to be rewritten.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Beroozam @mahdiHash
Apply suggestions from code review
3c76446
Co-authored-by: Mahdi Hashemi <[email protected]>
Beroozam
Beroozam commented Mar 1, 2022
View reviewed changes

@Beroozam Beroozam left a comment

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/11-async/02-promise-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/02-promise-basics/article.md Outdated
// runs when the promise is settled, doesn't matter successfully or not
.finally(() => stop loading indicator)
// so the loading indicator is always stopped before we process the result/error
// زمانی اجرا می‌شود که وعده تسویه شود، مهم نیست موفقیت‌آمیز باشد یا نه

ghost Mar 1, 2022

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// زمانی اجرا می‌شود که وعده تسویه شود، مهم نیست موفقیت‌آمیز باشد یا نه
// زمانی اجرا می‌شود که promise تسویه شود، مهم نیست موفقیت‌آمیز باشد یا نه

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
mahdiHash
mahdiHash reviewed Mar 1, 2022
View reviewed changes
Comment thread 1-js/11-async/02-promise-basics/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Behourz Mahdi Hashemi
Apply suggestions from code review
9763d18
Co-authored-by: Mahdi Hashemi <[email protected]>
@mahdiHash

ghost commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

Hi, @Beroozam.
If the translation is ready, please tell us so we merge it :)

Beroozam reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Beroozam

ghost commented Mar 2, 2022

Copy link
Copy Markdown
Contributor Author

Hi, @mahdiHash
It's done and ready. merge it please .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mahdiHash mahdiHash removed the changes requested label Mar 3, 2022
mahdiHash
mahdiHash approved these changes Mar 3, 2022
View reviewed changes
@javascript-translate-bot javascript-translate-bot added the needs +1 label Mar 3, 2022
@mahdiHash

ghost commented Mar 3, 2022

Copy link
Copy Markdown
Contributor

Thanks for your contribution, @Beroozam.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdyar
mahdyar approved these changes Mar 3, 2022
View reviewed changes
@mahdyar
mahdyar merged commit 115385e into javascript-tutorial:master Mar 3, 2022
@javascript-translate-bot

ghost commented Mar 3, 2022

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes
+1 more reviewer
@mahdiHash mahdiHash mahdiHash approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Beroozam @javascript-translate-bot @mahdiHash @mahdyar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.