GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Error handling with promises by mahdiHash · Pull Request #224 · javascript-tutorial/fa.javascript.info

Conversation

@mahdiHash

@mahdiHash mahdiHash commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

Please review and comment/commit if anything is wrong.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mahdiHash added 2 commits September 8, 2022 15:27
@mahdiHash
Translate article
9570368 
Lines 154 and 169 need more attention.
@mahdiHash
Translate task and solution of "error-async"
9d24aa9
@javascript-translate-bot javascript-translate-bot added the review needed label Sep 8, 2022
@javascript-translate-bot
javascript-translate-bot requested a review from a team September 8, 2022 11:04
@javascript-translate-bot javascript-translate-bot mentioned this pull request Sep 8, 2022
Persian (Farsi) Translation Progress #1
Open
mahdiHash
mahdiHash commented Sep 8, 2022
View reviewed changes
Comment thread 1-js/11-async/04-promise-error-handling/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
mahdiHash
mahdiHash commented Sep 8, 2022
View reviewed changes
Comment thread 1-js/11-async/04-promise-error-handling/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mahdiHash
mahdiHash marked this pull request as ready for review September 8, 2022 11:05
mahdyar
mahdyar approved these changes Sep 9, 2022
View reviewed changes

@mahdyar mahdyar left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Unhandled" has to be translated since I've translated the word "handle" everywhere. The problem is with "rejection". In this article I didn't translate the words "reject" and "resolve". IMO they're better to be left as is, so, "rejection" can be "rejection". But I like to have your opinion on it, too.

P.S. I want to change the translation of some words in the vocabulary of README. This change will keep them in English (not translated).

I agree. LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Sep 9, 2022
@mahdyar
mahdyar merged commit f8fb6b8 into javascript-tutorial:master Sep 9, 2022
@javascript-translate-bot

javascript-translate-bot commented Sep 9, 2022

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mahdiHash @javascript-translate-bot @mahdyar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.