GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Automated testing with Mocha by EhsanShahbazii · Pull Request #250 · javascript-tutorial/fa.javascript.info

Conversation

@EhsanShahbazii

@EhsanShahbazii EhsanShahbazii commented Jan 2, 2023

Copy link
Copy Markdown
Contributor

/done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
EhsanShahbazii added 2 commits January 2, 2023 00:46
@EhsanShahbazii
Translate article until line 108
a1c2718
@EhsanShahbazii
Translate article
650dbb4
@javascript-translate-bot javascript-translate-bot added the review needed label Jan 2, 2023
@javascript-translate-bot
javascript-translate-bot requested a review from a team January 2, 2023 07:56
@javascript-translate-bot

javascript-translate-bot commented Jan 2, 2023

Copy link
Copy Markdown

Error: the article has another translator @mahdyar in the Progress Issue #1.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CLAassistant

CLAassistant commented Jan 2, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mahdiHash
❌ EhsanShahbazii
You have signed the CLA already but the status is still pending? Let us recheck it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash
mahdiHash suggested changes Jan 2, 2023
View reviewed changes

@mahdiHash mahdiHash left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the changes. Notice the apply-to-whole ones.
You can add the suggestions to a batch and submit a single commit (docs).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/03-code-quality/05-testing-mocha/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/03-code-quality/05-testing-mocha/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/03-code-quality/05-testing-mocha/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/03-code-quality/05-testing-mocha/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/03-code-quality/05-testing-mocha/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/03-code-quality/05-testing-mocha/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/03-code-quality/05-testing-mocha/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/03-code-quality/05-testing-mocha/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/03-code-quality/05-testing-mocha/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/03-code-quality/05-testing-mocha/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Jan 2, 2023
@javascript-translate-bot

javascript-translate-bot commented Jan 2, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mahdiHash

mahdiHash commented Jan 2, 2023

Copy link
Copy Markdown
Contributor

Please translate the tasks, too.

EhsanShahbazii reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

EhsanShahbazii and others added 2 commits January 2, 2023 19:58
@EhsanShahbazii @mahdiHash
Update 1-js/03-code-quality/05-testing-mocha/article.md
c2f04b6
Co-authored-by: Mahdi Hashemi <[email protected]>
@EhsanShahbazii
complete review tasks
1c6a7ed
@EhsanShahbazii

EhsanShahbazii commented Jan 2, 2023

Copy link
Copy Markdown
Contributor Author

ok. I corrected the file.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@EhsanShahbazii

EhsanShahbazii commented Jan 2, 2023

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Jan 2, 2023
@javascript-translate-bot
javascript-translate-bot requested a review from a team January 2, 2023 17:07
mahdiHash
mahdiHash suggested changes Jan 2, 2023
View reviewed changes

@mahdiHash mahdiHash left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestions.
You can add the suggestions to a batch and submit a single commit (docs).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/03-code-quality/05-testing-mocha/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/03-code-quality/05-testing-mocha/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/03-code-quality/05-testing-mocha/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/03-code-quality/05-testing-mocha/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Jan 2, 2023
@javascript-translate-bot

javascript-translate-bot commented Jan 2, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@EhsanShahbazii @mahdiHash
Apply suggestions from code review
6390b0a
Co-authored-by: Mahdi Hashemi <[email protected]>
@EhsanShahbazii

EhsanShahbazii commented Jan 2, 2023

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Jan 2, 2023
@javascript-translate-bot
javascript-translate-bot requested a review from a team January 2, 2023 17:56
@mahdiHash
Add an extra line
6478231
Add an extra line to match the LOC of the English article.
@mahdiHash

mahdiHash commented Jan 2, 2023

Copy link
Copy Markdown
Contributor

Please translate the tasks, too.

Have you translated the tasks, @EhsanShahbazii?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@EhsanShahbazii

EhsanShahbazii commented Jan 2, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

The word task in article? yes @mahdiHash

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mahdiHash

mahdiHash commented Jan 2, 2023

Copy link
Copy Markdown
Contributor

The word task in article? yes @mahdiHash

No, I mean the task here.
You translated them in #249, but not in this PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

EhsanShahbazii added 2 commits January 2, 2023 22:04
@EhsanShahbazii
Update task.md
bc6c357
@EhsanShahbazii
Update solution.md
5aeee84
@EhsanShahbazii

EhsanShahbazii commented Jan 2, 2023

Copy link
Copy Markdown
Contributor Author

i see. done @mahdiHash

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash
mahdiHash approved these changes Jan 2, 2023
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Jan 2, 2023
@mahdiHash

mahdiHash commented Jan 2, 2023

Copy link
Copy Markdown
Contributor

Thanks for your contribution, @EhsanShahbazii.

EhsanShahbazii reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@EhsanShahbazii

EhsanShahbazii commented Jan 2, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Thank you for your explanation and guidance.🤍 @mahdiHash

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mahdiHash
mahdiHash merged commit 1f1b759 into javascript-tutorial:master Jan 3, 2023
@javascript-translate-bot

javascript-translate-bot commented Jan 3, 2023

Copy link
Copy Markdown

Error: the article has another translator @mahdyar, not @EhsanShahbazii in the Progress Issue #1. Please update the progress issue or ask maintainers to do so.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mahdiHash mahdiHash mentioned this pull request Jan 3, 2023
Persian (Farsi) Translation Progress #1
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mahdiHash mahdiHash mahdiHash approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@EhsanShahbazii @javascript-translate-bot @CLAassistant @mahdiHash
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.