GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Character classes by EhsanShahbazii · Pull Request #252 · javascript-tutorial/fa.javascript.info

Conversation

EhsanShahbazii commented Jan 19, 2023

Copy link

Copy Markdown

Contributor

/done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

EhsanShahbazii added 8 commits

January 15, 2023 23:02


          translate until line-39

ed1de22


          translate until line-70

dc5a969


          translate summary part

e65ca24


          translate until line-79

ef7c659


          translate until line-141

4ed0af3


          translate until line-160

4a9a273


          finish article

8e5276e


          fixed article

265b90c

javascript-translate-bot added the review needed label

Jan 19, 2023

javascript-translate-bot requested a review from a team

January 19, 2023 22:18

CLAassistant commented Jan 19, 2023

Copy link

Copy Markdown

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot mentioned this pull request

Jan 19, 2023

Persian (Farsi) Translation Progress #1

Open

EhsanShahbazii commented Jan 19, 2023

Copy link

Copy Markdown

Contributor Author

I apologize for my delay.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash suggested changes

Jan 20, 2023

View reviewed changes

mahdiHash left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the changes.
You can add the suggestions to a batch and submit a single commit (docs).

You inserted an empty line 182, please remove it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

9-regular-expressions/02-regexp-character-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/02-regexp-character-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/02-regexp-character-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/02-regexp-character-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/02-regexp-character-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/02-regexp-character-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/02-regexp-character-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/02-regexp-character-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/02-regexp-character-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

9-regular-expressions/02-regexp-character-classes/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Jan 20, 2023

javascript-translate-bot commented Jan 20, 2023

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash commented Jan 20, 2023

Copy link

Copy Markdown

Contributor

I apologize for my delay.

No worries.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

EhsanShahbazii and others added 2 commits

January 20, 2023 11:52


          Apply suggestions from code review

13d17fa

Co-authored-by: Mahdi Hashemi <[email protected]>


          remove empty line-182

d2258a6

EhsanShahbazii commented Jan 20, 2023

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Jan 20, 2023

javascript-translate-bot requested a review from a team

January 20, 2023 08:25

mahdiHash approved these changes

Jan 20, 2023

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels

Jan 20, 2023

mahdiHash commented Jan 20, 2023

Copy link

Copy Markdown

Contributor

Thanks for your contribution, @EhsanShahbazii.

EhsanShahbazii reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash merged commit be57662 into javascript-tutorial:master

Jan 21, 2023

javascript-translate-bot commented Jan 21, 2023

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

1 more reviewer

mahdiHash

mahdiHash approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.