GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Multiline mode of anchors ^ $, flag "m" by EhsanShahbazii · Pull Request #259 · javascript-tutorial/fa.javascript.info

Conversation

@EhsanShahbazii

@EhsanShahbazii EhsanShahbazii commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

/done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
EhsanShahbazii added 6 commits March 14, 2023 12:51
@EhsanShahbazii
translate until line-12
ef7ba95
@EhsanShahbazii
translate until line-42
59b801a
@EhsanShahbazii
translate until line-63
63a8107
@EhsanShahbazii
translate until line-77
e6b6c3e
@EhsanShahbazii
finish article
04395b2
@EhsanShahbazii
Update article.md
d10f9f7
@javascript-translate-bot javascript-translate-bot added the review needed label Mar 14, 2023
@javascript-translate-bot
javascript-translate-bot requested a review from a team March 14, 2023 09:39
@javascript-translate-bot javascript-translate-bot mentioned this pull request Mar 14, 2023
Persian (Farsi) Translation Progress #1
Open
@CLAassistant

CLAassistant commented Mar 14, 2023

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mahdyar

mahdyar commented Mar 14, 2023

Copy link
Copy Markdown
Member

Don't you think the word پرچم in Persian doesn't fit here? 🤔 Maybe flag itself would be a better option?
Let's have @mahdiHash's opinion on this as well.

EhsanShahbazii reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@EhsanShahbazii

EhsanShahbazii commented Mar 14, 2023

Copy link
Copy Markdown
Contributor Author

Don't you think the word پرچم in Persian doesn't fit here? 🤔 Maybe flag itself would be a better option?
Let's have @mahdiHash's opinion on this as well.

In the previous article that we translated, we used the word "پرچم". Of course, in my opinion, it is better that the words flag and anchor are not translated. But because we translated in the previous article, that's why I also translated.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mahdiHash

mahdiHash commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

Sorry for the delay. I was a little busy.

I also think "flag" is better. But it's translated to "پرچم" in other articles, so we need to revert it in another PR.

For now, please left "flag" as is, @EhsanShahbazii.

EhsanShahbazii reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash
mahdiHash suggested changes Mar 15, 2023
View reviewed changes
Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Mar 15, 2023
@javascript-translate-bot

javascript-translate-bot commented Mar 15, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@EhsanShahbazii @mahdiHash
Apply suggestions from code review
25a0d98
Co-authored-by: Mahdi Hashemi <[email protected]>
@EhsanShahbazii

EhsanShahbazii commented Mar 15, 2023

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Mar 15, 2023
@javascript-translate-bot
javascript-translate-bot requested a review from a team March 15, 2023 13:35
mahdiHash
mahdiHash suggested changes Mar 15, 2023
View reviewed changes

@mahdiHash mahdiHash left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the new changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/05-regexp-multiline-mode/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Mar 15, 2023
mahdiHash
mahdiHash suggested changes Mar 15, 2023
View reviewed changes

@mahdiHash mahdiHash left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the new changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@javascript-translate-bot javascript-translate-bot added the changes requested label Mar 15, 2023
@javascript-translate-bot

javascript-translate-bot commented Mar 15, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@EhsanShahbazii @mahdiHash
Apply suggestions from code review
f9e1676
Co-authored-by: Mahdi Hashemi <[email protected]>
@EhsanShahbazii

EhsanShahbazii commented Mar 15, 2023

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the changes requested label Mar 15, 2023
@javascript-translate-bot javascript-translate-bot added the review needed label Mar 15, 2023
@javascript-translate-bot
javascript-translate-bot requested a review from a team March 15, 2023 17:10
@mahdiHash

mahdiHash commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

Thanks for your contribution, @EhsanShahbazii.

EhsanShahbazii reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash
mahdiHash approved these changes Mar 15, 2023
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Mar 15, 2023
mahdyar
mahdyar approved these changes Mar 15, 2023
View reviewed changes
@mahdyar
mahdyar merged commit b669507 into javascript-tutorial:master Mar 15, 2023
@javascript-translate-bot

javascript-translate-bot commented Mar 15, 2023

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes
+1 more reviewer
@mahdiHash mahdiHash mahdiHash approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@EhsanShahbazii @CLAassistant @mahdyar @mahdiHash @javascript-translate-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.