GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Unicode, String internals by mostafa-nematpour · Pull Request #269 · javascript-tutorial/fa.javascript.info

Conversation

@mostafa-nematpour

@mostafa-nematpour mostafa-nematpour commented Jul 12, 2023

Copy link
Copy Markdown
Contributor

translate Unicode, String internals

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mostafa-nematpour
Unicode, String internals
33c5bba
@javascript-translate-bot javascript-translate-bot added the review needed label Jul 12, 2023
@javascript-translate-bot
javascript-translate-bot requested a review from a team July 12, 2023 21:09
@CLAassistant

CLAassistant commented Jul 12, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot mentioned this pull request Jul 12, 2023
Persian (Farsi) Translation Progress #1
Open
mahdyar
mahdyar requested changes Jul 12, 2023
View reviewed changes
Comment thread 1-js/99-js-misc/06-unicode/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/06-unicode/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Jul 12, 2023
@javascript-translate-bot

javascript-translate-bot commented Jul 12, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mostafa-nematpour and others added 2 commits July 13, 2023 01:27
@mostafa-nematpour @mahdyar
Update 1-js/99-js-misc/06-unicode/article.md
aaed2cf
Co-authored-by: Mahdyar Hasanpour <[email protected]>
@mostafa-nematpour @mahdyar
Update 1-js/99-js-misc/06-unicode/article.md
6a0a2fe
Co-authored-by: Mahdyar Hasanpour <[email protected]>
@mostafa-nematpour

mostafa-nematpour commented Jul 12, 2023

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Jul 12, 2023
@javascript-translate-bot
javascript-translate-bot requested a review from a team July 12, 2023 21:58
mahdiHash
mahdiHash suggested changes Jul 13, 2023
View reviewed changes

@mahdiHash mahdiHash left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the suggestions.
You can add the suggestions to a batch and create a commit just once (docs).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/99-js-misc/06-unicode/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/06-unicode/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/06-unicode/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/06-unicode/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/06-unicode/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Jul 13, 2023
@javascript-translate-bot

javascript-translate-bot commented Jul 13, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Jul 13, 2023
mostafa-nematpour and others added 5 commits July 13, 2023 09:26
@mostafa-nematpour @mahdiHash
Update 1-js/99-js-misc/06-unicode/article.md
38c9bca
Co-authored-by: Mahdi Hashemi <[email protected]>
@mostafa-nematpour @mahdiHash
Update 1-js/99-js-misc/06-unicode/article.md
6e0e19a
Co-authored-by: Mahdi Hashemi <[email protected]>
@mostafa-nematpour @mahdiHash
Update 1-js/99-js-misc/06-unicode/article.md
e18f96d
Co-authored-by: Mahdi Hashemi <[email protected]>
@mostafa-nematpour @mahdiHash
Update 1-js/99-js-misc/06-unicode/article.md
e689815
Co-authored-by: Mahdi Hashemi <[email protected]>
@mostafa-nematpour
update 1-js/99-js-misc/06-unicode/article.md line 121
4872e29
@mostafa-nematpour

mostafa-nematpour commented Jul 13, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the suggestions Mehdi
I will try to be better and next time I will put all in one
I'm not good at it
/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Jul 13, 2023
@javascript-translate-bot
javascript-translate-bot requested a review from a team July 13, 2023 06:34
@mahdiHash
remove additional empty lines
5545d77
@mahdiHash

mahdiHash commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

Thanks for the suggestions Mehdi I will try to be better and next time I will put all in one I'm not good at it /done

No worries, mate :)
Thanks for your contribution, @mostafa-nematpour.

mostafa-nematpour reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash
mahdiHash approved these changes Jul 13, 2023
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Jul 13, 2023
@mahdiHash
mahdiHash merged commit 3190e58 into javascript-tutorial:master Jul 14, 2023
@javascript-translate-bot

javascript-translate-bot commented Jul 14, 2023

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mostafa-nematpour
mostafa-nematpour deleted the unicode branch July 14, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar requested changes
+1 more reviewer
@mahdiHash mahdiHash mahdiHash approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@mostafa-nematpour @CLAassistant @javascript-translate-bot @mahdiHash @mahdyar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.