GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Forms: event and method submit by shahrzadJavadiKoushesh · Pull Request #292 · javascript-tutorial/fa.javascript.info

Conversation

@shahrzadJavadiKoushesh

@shahrzadJavadiKoushesh shahrzadJavadiKoushesh commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
shahrzadJavadiKoushesh added 6 commits August 21, 2023 14:39
@shahrzadJavadiKoushesh
line 1
b5a1d7e
@shahrzadJavadiKoushesh
done article.md
e76aa9e
@shahrzadJavadiKoushesh
line 11
d74e530
@shahrzadJavadiKoushesh
task.md done
b0b7eef
@shahrzadJavadiKoushesh
Update task.md
844a648
@shahrzadJavadiKoushesh
solution.md done
0ef2daa
@javascript-translate-bot javascript-translate-bot added the review needed label Aug 23, 2023
@javascript-translate-bot
javascript-translate-bot requested a review from a team August 23, 2023 11:39
@javascript-translate-bot javascript-translate-bot mentioned this pull request Aug 23, 2023
Persian (Farsi) Translation Progress #1
Open
mahdyar
mahdyar requested changes Aug 23, 2023
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shahrzadJavadiKoushesh and thank you for your contribution;

Please make the requested changes and let me know when it's done.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 2-ui/4-forms-controls/4-forms-submit/article.md Outdated
@@ -1,42 +1,42 @@
# Forms: event and method submit
# Forms: event و method submit

@mahdyar mahdyar Aug 23, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Forms: event و method submit
# فرم‌ها: event و method submit

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md Outdated
```

A demo in the iframe:
نسخهی نمایشی در iframe:

@mahdyar mahdyar Aug 23, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
نسخهی نمایشی در iframe:
نسخه‌ای نمایشی در iframe:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md Outdated
- در غیر این صورت اگر کاربر `key:Esc` یا CANCEL را فشار دهد، `callback(null)` فراخوانی می‌شود.

In both cases that ends the input process and removes the form.
در هر دو صورت،‌این فرآیند input را تمام میکند و فرم را پاک میکند.

@mahdyar mahdyar Aug 23, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a space after comma:

Suggested change
در هر دو صورت،‌این فرآیند input را تمام میکند و فرم را پاک میکند.
در هر دو صورت،‌ این فرآیند input را تمام میکند و فرم را پاک میکند.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md Outdated
```

Because the `<div>` covers everything, it gets all clicks, not the page below it.
از آنجایی که `<div>` همه چیز را می‌پوشاند،آن تمام کلیک‌ها را می‌گیرد،نه صفحه‌ی زیر آن.

@mahdyar mahdyar Aug 23, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
از آنجایی که `<div>` همه چیز را می‌پوشاند،آن تمام کلیک‌ها را می‌گیرد،نه صفحه‌ی زیر آن.
از آنجایی که `<div>` همه چیز را می‌پوشاند، آن تمام کلیک‌ها را می‌گیرد،نه صفحه‌ی زیر آن.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot removed the review needed label Aug 23, 2023
@javascript-translate-bot

javascript-translate-bot commented Aug 23, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added the changes requested label Aug 23, 2023
shahrzadJavadiKoushesh added 3 commits August 24, 2023 19:03
@shahrzadJavadiKoushesh
Update article.md
2e54a1f
@shahrzadJavadiKoushesh
Update task.md
3afecd8
@shahrzadJavadiKoushesh
Update solution.md
cbb5115
@shahrzadJavadiKoushesh

shahrzadJavadiKoushesh commented Aug 24, 2023

Copy link
Copy Markdown
Contributor Author

/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Aug 24, 2023
@javascript-translate-bot
javascript-translate-bot requested a review from a team August 24, 2023 15:36
mahdyar
mahdyar approved these changes Aug 28, 2023
View reviewed changes

@mahdyar mahdyar left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @shahrzadJavadiKoushesh!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Aug 28, 2023
@mahdyar
mahdyar merged commit 4d2e43f into javascript-tutorial:master Aug 28, 2023
@javascript-translate-bot

javascript-translate-bot commented Aug 28, 2023

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahdyar mahdyar mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@shahrzadJavadiKoushesh @javascript-translate-bot @mahdyar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.