GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Switch by newshahn · Pull Request #61 · javascript-tutorial/fa.javascript.info

Conversation

@newshahn

@newshahn newshahn commented Jul 12, 2020

Copy link
Copy Markdown
Contributor

Hi,
Switch chapter was translated :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@newshahn
translated switch chapter
cd1c827
@javascript-translate-bot javascript-translate-bot added the review needed label Jul 12, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team July 12, 2020 12:01
mehradsadeghi
mehradsadeghi reviewed Jul 12, 2020
View reviewed changes
Comment thread 1-js/02-first-steps/14-switch/1-rewrite-switch-if-else/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
mehradsadeghi
mehradsadeghi reviewed Jul 12, 2020
View reviewed changes
Comment thread 1-js/02-first-steps/14-switch/2-rewrite-if-switch/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
mehradsadeghi
mehradsadeghi suggested changes Jul 12, 2020
View reviewed changes

@mehradsadeghi mehradsadeghi left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple parts that you've changed single quotes to double quotes in the translations (in code sections). Is there any reason for that ? Am I missing something ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Jul 12, 2020
@javascript-translate-bot

javascript-translate-bot commented Jul 12, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@newshahn

newshahn commented Jul 14, 2020

Copy link
Copy Markdown
Contributor Author

As you can probably tell, I'm pretty new to programming and Github and that's partly why I made these mistakes.
I will fix them and resend my PR.
Thank you
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
newshahn added 2 commits July 14, 2020 18:01
@newshahn
Merge branch 'master' of https://github.com/javascript-tutorial/fa.ja…
c34acbc 
…vascript.info
@newshahn
fixed up everything
c998800
@mehradsadeghi

mehradsadeghi commented Jul 14, 2020

Copy link
Copy Markdown
Contributor

As you can probably tell, I'm pretty new to programming and Github and that's partly why I made these mistakes.
I will fix them and resend my PR.
Thank you

Don't worry about it. You're doing fine.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
newshahn added 3 commits July 15, 2020 15:24
@newshahn
changed the double qoutes to single quotes
9271737
@newshahn
deleted the file i have added by mistake
5e96b62
@newshahn
fixed the backticks
947e06c
@newshahn

newshahn commented Jul 15, 2020

Copy link
Copy Markdown
Contributor Author

Dear Mehrad,
I fixed the issues you mentioned in the past PR.
An extension was changing my double quotes to single quotes.
Hopefully, it's all okay now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mehradsadeghi
mehradsadeghi approved these changes Jul 15, 2020
View reviewed changes

@mehradsadeghi mehradsadeghi left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed changes requested labels Jul 15, 2020
@mehradsadeghi
mehradsadeghi merged commit 74cdde6 into javascript-tutorial:master Jul 15, 2020
@mahdyar mahdyar mentioned this pull request Apr 6, 2021
Persian (Farsi) Translation Progress #1
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mehradsadeghi mehradsadeghi mehradsadeghi approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@newshahn @javascript-translate-bot @mehradsadeghi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.