GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Constructor, operator "new" by mahdiHash · Pull Request #98 · javascript-tutorial/fa.javascript.info

Conversation

mahdiHash commented Mar 19, 2021

Copy link

Copy Markdown

Contributor

Please review and commit if anything is wrong.
All the files in "Constructor, operator new" are translated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mahdiHash added 9 commits

March 17, 2021 22:52


          translate task.md

1af2bd2

Translated task.md.
Please review it and commit if anything is wrong


          translate solution.md

3aec6a2

Please review and commit if anything is wrong.


          translate task.md

Please review and commit if anything is wrong.


          translate task.md

d73f644

Please review and commit if anything is wrong


          Translate a part of atricle.md

acc32e7

It's not done yet. Just the first part is translated


          Translate a part of article.md

337074b

Translated the second part.


          Translate a part of article.md

d30e918

Translated the third part


          Translate aticle.md

e6ea075

Translation is done. Please review and commit if anything is wrong.


          Remove a line

a0b754f

Removed an empty line.

javascript-translate-bot added the review needed label

Mar 19, 2021

javascript-translate-bot requested a review from a team

March 19, 2021 19:19

javascript-translate-bot mentioned this pull request

Mar 19, 2021

Persian (Farsi) Translation Progress #1

Open

CLAassistant commented Mar 19, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdyar requested changes

Mar 19, 2021

View reviewed changes

Comment thread

1-js/04-object-basics/06-constructor-new/article.md Outdated

		```js
		let user = new User; // <-- no parentheses
		// same as
		let user = new User; // <-- بدون پرانتر

mahdyar Mar 19, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo:
پرانتز

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

1-js/04-object-basics/06-constructor-new/article.md Outdated

		@@ -1,17 +1,17 @@
		# Constructor, operator "new"
		# سازنده ، اپراتور "new"

mahdyar Mar 19, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing for commas should be like this as you have already observed everywhere else:
سازنده، اپراتور
instead of:
سازنده ، اپراتور‍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

1-js/04-object-basics/06-constructor-new/article.md Outdated

		```

		Now if we want to create other users, we can call `new User("Ann")`, `new User("Alice")` and so on. Much shorter than using literals every time, and also easy to read.
		حالا اگر ما بخواهیم که user های دیگری بسازیم، می توانیم `new User("Ann")` ، `new User("Alice")` و ... را صدا بزنیم. این کار بسیار کوتاه تر از استفاده همیشگی از literal ها است، و همچنین برای خواندن آسان است.

mahdyar Mar 19, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing for commas should be like this as you have already observed everywhere else:
سازنده، اپراتور
instead of:
سازنده ، اپراتور‍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/04-object-basics/06-constructor-new/article.md Outdated


		```smart header="Objects, we'll be back!"
		In this chapter we only cover the basics about objects and constructors. They are essential for learning more about data types and functions in the next chapters.
		```smart header="شیءها ، ما بر می گردیم!"

mahdyar Mar 19, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spacing for commas should be like this as you have already observed everywhere else:
سازنده، اپراتور
instead of:
سازنده ، اپراتور‍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/04-object-basics/06-constructor-new/article.md Outdated

		@@ -1,17 +1,17 @@
		# Constructor, operator "new"
		# سازنده ، اپراتور "new"

mahdyar Mar 19, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also using ‍‍عملگر instead of اپراتور would be better.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

1-js/04-object-basics/06-constructor-new/article.md Outdated

		// maybe complex logic and statements
		// local variables etc
		// ... کد های دیگر برای ساخت user
		// شاید شامل منطق و دستورالعمل عجیبی باشد

mahdyar Mar 19, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Complex" doesn't mean عجیب. Perhaps using پیچیده would be a better idea.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

1-js/04-object-basics/06-constructor-new/article.md Outdated

		```

		Omitting parentheses here is not considered a "good style", but the syntax is permitted by specification.
		اینجا پنهان کردن پرانتزها به عنوان یک "سبک خوب" فرض نمی شود، اما سینتکس طبق خصوصیات مجاز است.

mahdyar Mar 19, 2021

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Omitting" doesn't mean پنهان کردن. Perhaps using حذف کردن would be a better idea.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mahdiHash reacted with thumbs up emoji

All reactions

👍 1 reaction

mahdiHash Mar 20, 2021

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review🙏🏻

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added changes requested and removed review needed labels

Mar 19, 2021

javascript-translate-bot commented Mar 19, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Update article.md

d9c3779

All the mentioned problems are solved.
Also I translated line 44.

mahdiHash commented Mar 20, 2021

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Mar 20, 2021

javascript-translate-bot requested a review from a team

March 20, 2021 08:42

javascript-translate-bot removed the review needed label

Mar 20, 2021

mahdyar approved these changes

Mar 20, 2021

View reviewed changes

mahdyar left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mahdiHashemi14!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added the needs +1 label

Mar 20, 2021

mahdyar merged commit 3e2c03d into javascript-tutorial:master

Mar 20, 2021

javascript-translate-bot commented Mar 20, 2021

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

mahdyar

mahdyar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

mahdiHash commented Mar 19, 2021

Uh oh!

CLAassistant commented Mar 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Mar 19, 2021

Uh oh!

mahdiHash commented Mar 20, 2021

Uh oh!

mahdyar left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Mar 20, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented Mar 19, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.