GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Code editors by ayushhagarwal · Pull Request #22 · javascript-tutorial/hi.javascript.info

Conversation

@ayushhagarwal

@ayushhagarwal ayushhagarwal commented Jun 27, 2020

Copy link
Copy Markdown
Contributor

Hindi translation done for Code Editors documentation in javascript.info.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ayushhagarwal added 2 commits June 26, 2020 12:32
@ayushhagarwal
Update article.md
60f5ae6 
Heading changed for testing work not completed
@ayushhagarwal
update article.md for code editors.
3c1b65b 
Complete article translated to hindi.
@javascript-translate-bot javascript-translate-bot added the review needed label Jun 27, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team June 27, 2020 16:32
@CLAassistant

CLAassistant commented Jun 27, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@theBstar theBstar changed the title Code Editors Code editors Jun 27, 2020
@theBstar

theBstar commented Jun 27, 2020

Copy link
Copy Markdown
Member

Hey added a bunch of comments feel free to disagree. Nice job overall. Sometimes you need to play around with the English version to get the translation right when using automated tools. The translated version not only has to be correct but meaningful in the context as well. Thanks for your time, Now let's wrap this up asap. 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
theBstar
theBstar requested changes Jun 27, 2020
View reviewed changes

@theBstar theBstar left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments where I thought we could improve. This looks good to be merged post changes. Feel free to disagree!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/01-getting-started/3-code-editors/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/01-getting-started/3-code-editors/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/01-getting-started/3-code-editors/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/01-getting-started/3-code-editors/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/01-getting-started/3-code-editors/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/01-getting-started/3-code-editors/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/01-getting-started/3-code-editors/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot removed the review needed label Jun 27, 2020
@javascript-translate-bot

javascript-translate-bot commented Jun 27, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added the changes requested label Jun 27, 2020
@ayushhagarwal

ayushhagarwal commented Jun 28, 2020

Copy link
Copy Markdown
Contributor Author

/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Jun 28, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team June 28, 2020 06:08
ayushhagarwal and others added 3 commits June 28, 2020 11:39
@ayushhagarwal
Improved the article according to the suggestions recieved.
baa60e7
@ayushhagarwal
Minor improvements
aa41b50
@theBstar
Corrected the git url
7f20f8d
theBstar
theBstar approved these changes Jun 28, 2020
View reviewed changes

@theBstar theBstar left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to be merged. There are certain possible improvements around the context and meanings though. Can be merged now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Jun 28, 2020
@theBstar
theBstar merged commit 6ec932a into javascript-tutorial:master Jun 28, 2020
@iliakan iliakan mentioned this pull request Jun 28, 2020
Hindi Translation Progress #1
Open
@javascript-translate-bot

javascript-translate-bot commented Jun 28, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theBstar theBstar theBstar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ayushhagarwal @CLAassistant @theBstar @javascript-translate-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.