GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Variables by ashpratap007 · Pull Request #30 · javascript-tutorial/hi.javascript.info

Conversation

ashpratap007 commented Jul 30, 2020

Copy link

Copy Markdown

Contributor

Hindi translations for topic "Variables".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Hindi translations for topic "Variables".

8bc5272

javascript-translate-bot added the review needed label

Jul 30, 2020

theBstar commented Jul 31, 2020

Copy link

Copy Markdown

Member

Thank you for submitting the PR. I will review it by tomorrow.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

theBstar requested changes

Aug 2, 2020

View reviewed changes

theBstar left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @ashpratap007 added a few comments. Overall a good job. Thank you for contributing towards a good cause. Let's make the changes, then we will merge it. Let me know if I can help with anything.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/04-variables/1-hello-variables/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/04-variables/1-hello-variables/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/04-variables/2-declare-variables/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/04-variables/2-declare-variables/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/04-variables/2-declare-variables/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/04-variables/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/04-variables/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/04-variables/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/04-variables/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/04-variables/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Aug 2, 2020

javascript-translate-bot commented Aug 2, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Aug 2, 2020

ashpratap007 commented

Aug 3, 2020

View reviewed changes

ashpratap007 left a comment

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the wonderful review. This being my first open-source contribution, kindly bear with me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Changes done after first Review

c0e1c85

ashpratap007 requested a review from theBstar

August 3, 2020 08:04

ashpratap007 commented Aug 3, 2020

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Aug 3, 2020

theBstar added 2 commits

August 5, 2020 08:08


          changed स्ट्रिंग to string

14e6fe5


          reverted language keywords to English

f15d602

theBstar approved these changes

Aug 5, 2020

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels

Aug 5, 2020

theBstar commented Aug 5, 2020

Copy link

Copy Markdown

Member

Thanks for the wonderful review. This being my first open-source contribution, kindly bear with me.

Hey, It was awesome! Merging this PR. Congrats for your first open-source contribution 🎉🎉. Hoping to see many more from you in the coming days. Thank you.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

theBstar merged commit 411b351 into javascript-tutorial:master

Aug 5, 2020

iliakan mentioned this pull request

Aug 5, 2020

Hindi Translation Progress #1

Open

javascript-translate-bot commented Aug 5, 2020

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

theBstar

theBstar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.