GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Comparisons by rjitsu · Pull Request #39 · javascript-tutorial/hi.javascript.info

Conversation

rjitsu commented Oct 2, 2020

Copy link

Copy Markdown

Contributor

I have translated the comparisons article. Let me know if it needs any correction!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

rjitsu added 20 commits

October 2, 2020 20:29


          Create article1.md

79b9f1a


          Update article1.md

a424780


          Update article1.md

840fea8


          Update article1.md

a42dda5


          Update article1.md

535f742


          Update article1.md

21da1f5


          Update article1.md


          Update article1.md

1e6e281


          Create task1.md

239262e


          Update task1.md

be2f963


          Create solution1.md

3dac383


          Update solution1.md

f9cabce


          Update solution1.md

7d1a594


          Update solution1.md

fe27b74


          Delete solution.md

96b22ca


          Delete task.md

6c704fd


          Rename solution1.md to solution.md

77b6cfd


          Rename task1.md to task.md

c4de812


          Delete article.md

c537c54


          Rename article1.md to article.md

c6ba04a

javascript-translate-bot added the review needed label

Oct 2, 2020

javascript-translate-bot requested a review from a team

October 2, 2020 18:42

javascript-translate-bot mentioned this pull request

Oct 2, 2020

Hindi Translation Progress #1

Open

theBstar requested changes

Oct 4, 2020

View reviewed changes

theBstar left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, first of all, huge appreciation for taking time to help a good cause. I went through the translation and found a couple of places where we can improve. Good test is to come back to the article after 30 minutes and see if every line is easy to understand. Translation doesn't need to be exact but it should convey the topic easily. Please resolve the thread and make any other required change. I will review the article post changes. Let me know if I can help in any way. 👏

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/09-comparison/1-comparison-questions/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/09-comparison/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/09-comparison/article.md

		- Greater/less than or equals: <code>a >= b</code>, <code>a <= b</code>.
		- Equals: `a == b`, please note the double equality sign `==` means the equality test, while a single one `a = b` means an assignment.
		- Not equals. In maths the notation is <code>≠</code>, but in JavaScript it's written as <code>a != b</code>.
		- ग्रेटर / से कम: <code>a > b</code>, <code>a < b</code>।

theBstar Oct 4, 2020

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can refer to the link above for some of these notations. Whichever notations are not available (in Hindi) in the list, you can translate them by using an online translator, Use words and provide some context to get more accurate results.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

rjitsu Jun 19, 2021

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theBstar which link? Can you help me with this, I have added all other changes that were requested

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/09-comparison/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/09-comparison/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/09-comparison/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/09-comparison/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/09-comparison/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Oct 4, 2020

javascript-translate-bot commented Oct 4, 2020

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Oct 4, 2020

theBstar commented May 28, 2021

Copy link

Copy Markdown

Member

@rjitsu I would love to merge this PR ASAP if we can make those small changes. Let me know if you are facing any difficulties.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rjitsu commented May 28, 2021 via email

Copy link

Copy Markdown

Contributor Author

Hi, Sorry for the delayed PR, will make the changes over the weekend!

…

On Sat, 29 May 2021, 12:02 am Bikram Sutar, ***@***.***> wrote: @rjitsu <https://github.com/rjitsu> I would love to merge this PR ASAP if we can make those small changes. Let me know if you are facing any difficulties. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#39 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKC3MFUTUUASKXQVYMURZGDTP7OSLANCNFSM4SCA3T5A> .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Update solution.md

77cbaa9


          Update article.md

b29e613

rjitsu closed this

Sep 2, 2021

Reviewers

theBstar

theBstar requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.