GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Functions by rskhan167 · Pull Request #75 · javascript-tutorial/hi.javascript.info

Conversation

@rskhan167

@rskhan167 rskhan167 commented Sep 9, 2021

Copy link
Copy Markdown
Contributor

I have translated Functions. Please let me know if there are any changes/modifications needed. Thank you.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
rasoolkhan16 and others added 14 commits September 6, 2021 16:33
@rasoolkhan16
Translate 1-if-else-required
c594079
@rasoolkhan16
Translate 2-rewrite-function-question0or
e2877f1
@rskhan167
fix numbering
722a4e1
@rskhan167
fix autochange done by IDE
906f4e8
@rskhan167
fix changes made by IDE
0c4bd5e
@rskhan167
Translate 3-min
1e5439e
@rskhan167
Merge branch 'master' of github-personal:rskhan167/hi.javascript.info
fbb4ea7
@rskhan167
fix autochange by IDE
f0d15ad
@rskhan167
Translate article
952f447
@rskhan167
Merge branch 'master' of github-personal:rskhan167/hi.javascript.info
74b6581
@rskhan167
fix translate
b632892
@rskhan167
fix IDE's autochanges
1d42753
@rskhan167
fix IDE's autochanges
93aa7be
@rskhan167
fix IDE's autochanges
f39ab2b
@javascript-translate-bot javascript-translate-bot added the review needed label Sep 9, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team September 9, 2021 19:28
@javascript-translate-bot javascript-translate-bot mentioned this pull request Sep 9, 2021
Hindi Translation Progress #1
Open
@CLAassistant

CLAassistant commented Sep 9, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rskhan167
fix some translations
5bf0d16
theBstar
theBstar requested changes Sep 21, 2021
View reviewed changes

@theBstar theBstar left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have look at all the comments? Also have a re-look at the 1-js/02-first-steps/15-function-basics/article.md file, haven't review all of it. Needs some re-work. Thanks for the contribution. As you are maintaining the project now if you feel something is good enough to be merged feel free to merged even without another review. But make sure you do a proper self-review. Key here to just read the Hindi version and see if everything makes sense. After which you can read the English and Hindi side by side, to check for keywords and other guidelines. Thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/15-function-basics/2-rewrite-function-question-or/task.md Outdated
```

Rewrite it, to perform the same, but without `if`, in a single line.
इसे फिर से लिखें, वही प्रदर्शन करने के लिए, लेकिन बिना `if` के, एक पंक्ति में।

@theBstar theBstar Sep 21, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use something more explicit than प्रदर्शन ? The translation doesn't need to match word by word if it's restricting us to convey the info.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/15-function-basics/3-min/task.md Outdated
# Function min(a, b)

Write a function `min(a,b)` which returns the least of two numbers `a` and `b`.
एक function लिखें `min(a,b)` जो कम से कम दो नंबर `a` और `b` लौटाता है।

@theBstar theBstar Sep 21, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have a re-look at this line?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@rskhan167 rskhan167 Sep 21, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/15-function-basics/4-pow/task.md Outdated
# Function pow(x,n)

Write a function `pow(x,n)` that returns `x` in power `n`. Or, in other words, multiplies `x` by itself `n` times and returns the result.
एक function लिखें `pow(x,n)` जो `x` को `n` के शक्ति में लौटाता है। या, दूसरे शब्दों में, `x` को अपने आप से `n` गुणा से गुणा करता है और परिणाम देता है।

@theBstar theBstar Sep 21, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line also needs to be re-looked. Let's try to use proper mathematical terms in Hindi

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@rskhan167 rskhan167 Sep 21, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/15-function-basics/4-pow/task.md Outdated
```

Create a web-page that prompts for `x` and `n`, and then shows the result of `pow(x,n)`.
एक वेब-पेज बनाएं जो `x` और `n` के लिए संकेत देता है, और फिर `pow(x,n)` का परिणाम दिखाता है।

@theBstar theBstar Sep 21, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prompts is very contextual here, not sure if we should translate. Thoughts?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@rskhan167 rskhan167 Sep 21, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think you are right. It is better to keep it as is.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/15-function-basics/4-pow/task.md Outdated
[demo]

P.S. In this task the function should support only natural values of `n`: integers up from `1`.
नोट: इस टास्क में function को केवल `n` के प्राकृतिक मान का समर्थन करना चाहिए: `1` से ऊपर के पूर्णांक।

@theBstar theBstar Sep 21, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above math terms are translated as plain old english.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@rskhan167 rskhan167 Sep 21, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
# Functions

Quite often we need to perform a similar action in many places of the script.
अक्सर हमें स्क्रिप्ट के कई स्थानों पर इसी तरह की कार्रवाई करने की आवश्यकता होती है।

@theBstar theBstar Sep 21, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hindi sentence is a bit diverted from the meaning of the original sentence, that's what I feel. Can be improved.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@rskhan167 rskhan167 Sep 21, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
अक्सर हमें स्क्रिप्ट के कई स्थानों पर इसी तरह की कार्रवाई करने की आवश्यकता होती है।

For example, we need to show a nice-looking message when a visitor logs in, logs out and maybe somewhere else.
उदाहरण के लिए, जब कोई परिदर्शक इन करता है, लॉग आउट करता है और शायद कहीं और एक अच्छा दिखने वाला संदेश दिखाना चाहता है।

@theBstar theBstar Sep 21, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@rskhan167 rskhan167 Sep 21, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
Functions प्रोग्राम के मुख्य "बिल्डिंग ब्लॉक्स" हैं। वे बिना दोहराव के कोड को कई बार कॉल करने की अनुमति देते हैं।

We've already seen examples of built-in functions, like `alert(message)`, `prompt(message, default)` and `confirm(question)`. But we can create functions of our own as well.
हम पहले से ही बिल्ट-इन function के उदाहरण देख चुके हैं, जैसे `अलर्ट (संदेश)`, `प्रॉम्प्ट (संदेश, डिफ़ॉल्ट)` और `पुष्टि करें (प्रश्न)`। लेकिन हम अपने स्वयं के functions भी बना सकते हैं।

@theBstar theBstar Sep 21, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not translate the keywords, anyting inside '``'

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@rskhan167 rskhan167 Sep 21, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes I somehow missed this

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/15-function-basics/article.md
## Function Declaration

To create a function we can use a *function declaration*.
## Function घोषणा

@theBstar theBstar Sep 21, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be at line no 11

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@rskhan167 rskhan167 Sep 21, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
```

The `function` keyword goes first, then goes the *name of the function*, then a list of *parameters* between the parentheses (comma-separated, empty in the example above) and finally the code of the function, also named "the function body", between curly braces.
`function` कीवर्ड पहले जाता है, फिर _name of the function_ जाता है, फिर कोष्ठक के बीच _parameters_ की एक सूची (उपरोक्त उदाहरण में खाली) और अंत में function का कोड, जिसे "the function body" भी कहा जाता है , घुंघराले ब्रेसिज़ के बीच।

@theBstar theBstar Sep 21, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using a notation like - name of the function? Applies to all the places we are using it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Sep 21, 2021
@javascript-translate-bot

javascript-translate-bot commented Sep 21, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rskhan167 added 3 commits September 21, 2021 09:30
@rskhan167
Update task.md
badd33b
@rskhan167
Update task.md
1eac281
@rskhan167
Update task.md
de48b64
rskhan167
rskhan167 commented Sep 21, 2021
View reviewed changes
Comment thread 1-js/02-first-steps/15-function-basics/article.md Outdated
## Function घोषणा

It looks like this:
function बनाने के लिए हम एक _function declaration_ का उपयोग कर सकते हैं।

@rskhan167 rskhan167 Sep 21, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we translate _function declaration_ also??

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
rskhan167 added 3 commits September 21, 2021 09:56
@rskhan167
Update article.md
dc463a3
@rskhan167
Update task.md
300a818
@rskhan167
Update article.md
582983e
rskhan167 added 10 commits September 21, 2021 10:39
@rskhan167
Update article.md
c8a43e6
@rskhan167
Update article.md
1b5f2a9
@rskhan167
Update task.md
97871c6
@rskhan167
Update task.md
4dd3856
@rskhan167
Update task.md
6b4f682
@rskhan167
Update task.md
1ff58cc
@rskhan167
Update task.md
5601c33
@rskhan167
Update task.md
6913971
@rskhan167
Update article.md
f9696dd
@rskhan167
Update article.md
56a438d
@rskhan167

rskhan167 commented Sep 21, 2021

Copy link
Copy Markdown
Contributor Author

/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Sep 21, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team September 21, 2021 18:31
@rskhan167
rskhan167 requested a review from theBstar September 21, 2021 18:32
@rskhan167

rskhan167 commented Sep 21, 2021

Copy link
Copy Markdown
Contributor Author

Can you have look at all the comments? Also have a re-look at the 1-js/02-first-steps/15-function-basics/article.md file, haven't review all of it. Needs some re-work. Thanks for the contribution. As you are maintaining the project now if you feel something is good enough to be merged feel free to merged even without another review. But make sure you do a proper self-review. Key here to just read the Hindi version and see if everything makes sense. After which you can read the English and Hindi side by side, to check for keywords and other guidelines. Thanks

Thanks for the review. I have made the requested changes also I have gone through 1-js/02-first-steps/15-function-basics/article.md file and made some changes there too. Please let me know if the changes are correct or not.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rskhan167 added 10 commits September 23, 2021 22:41
@rskhan167
Merge branch 'javascript-tutorial:master' into master
c8ecd51
@rskhan167
Merge branch 'javascript-tutorial:master' into master
7b70801
@rskhan167
Update article.md
270a393
@rskhan167
Update article.md
ac357ca
@rskhan167
Update article.md
0588885
@rskhan167
Update article.md
7611a3f
@rskhan167
Update article.md
3ad84fb
@rskhan167
Update task.md
e37cbf2
@rskhan167
Update task.md
a04785d
@rskhan167
Merge branch 'javascript-tutorial:master' into master
d5900ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theBstar theBstar Awaiting requested review from theBstar

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@rskhan167 @CLAassistant @javascript-translate-bot @theBstar @rasoolkhan16
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.