GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Comments by Deep1Shikha · Pull Request #77 · javascript-tutorial/hi.javascript.info

Conversation

Deep1Shikha commented Sep 14, 2021

Copy link

Copy Markdown

Contributor

Comments

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Comments

b6f3119

Comments

javascript-translate-bot added the review needed label

Sep 14, 2021

javascript-translate-bot requested a review from a team

September 14, 2021 15:41

CLAassistant commented Sep 14, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot mentioned this pull request

Sep 14, 2021

Hindi Translation Progress #1

Open

rskhan167 requested review from rskhan167 and removed request for rskhan167

September 15, 2021 05:17

rskhan167 reviewed

Sep 15, 2021

View reviewed changes

Comment thread

1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

rskhan167 reviewed

Sep 15, 2021

View reviewed changes

Comment thread

1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

rskhan167 reviewed

Sep 15, 2021

View reviewed changes

Comment thread

1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

rskhan167 reviewed

Sep 15, 2021

View reviewed changes

Comment thread

1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

rskhan167 reviewed

Sep 15, 2021

View reviewed changes

Comment thread

1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

rskhan167 reviewed

Sep 15, 2021

View reviewed changes

Comment thread

1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

rskhan167 reviewed

Sep 15, 2021

View reviewed changes

Comment thread

1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

rskhan167 reviewed

Sep 15, 2021

View reviewed changes

Comment thread

1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

rskhan167 reviewed

Sep 15, 2021

View reviewed changes

Comment thread

1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

rskhan167 reviewed

Sep 15, 2021

View reviewed changes

Comment thread

1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

rskhan167 reviewed

Sep 15, 2021

View reviewed changes

Comment thread

1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

rskhan167 reviewed

Sep 15, 2021

View reviewed changes

rskhan167 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some changes required please address these. And let me know if you need any help. Thanks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Deep1Shikha added 2 commits

September 15, 2021 13:54


          Update article.md

2434c78

Updated as per review


          Update article.md

490924c

Implemented changes for first review comment

Deep1Shikha commented Sep 15, 2021

Copy link

Copy Markdown

Contributor Author

Thanks for the suggestions, I have pushed the changes.

rskhan167 reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rskhan167 requested changes

Sep 15, 2021

View reviewed changes

Comment thread

1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Sep 15, 2021

javascript-translate-bot commented Sep 15, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rskhan167 commented Sep 15, 2021

Copy link

Copy Markdown

Contributor

Thanks for the suggestions, I have pushed the changes.

A few more change requests have been added. Please address those too. Thanks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Comments

7f09965

Comments /done

javascript-translate-bot removed the changes requested label

Sep 15, 2021

Deep1Shikha commented Sep 15, 2021

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot requested a review from a team

September 15, 2021 09:45

rskhan167 requested changes

Sep 15, 2021

View reviewed changes

rskhan167 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. There is this one change I found. After this I think it is ready to get merged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Sep 15, 2021

javascript-translate-bot commented Sep 15, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Comments

90a54a1

Comments updated

Deep1Shikha requested a review from rskhan167

September 17, 2021 12:52

Deep1Shikha commented Sep 17, 2021

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Sep 17, 2021

javascript-translate-bot requested a review from a team

September 17, 2021 12:52

rskhan167 requested changes

Sep 17, 2021

View reviewed changes

rskhan167 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you forgot to change वास्तुकला to संरचना at other place. Please change that and request review

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/03-code-quality/03-comments/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Sep 17, 2021

javascript-translate-bot commented Sep 17, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Comments

62f65ab

Updated changes as per suggestions

javascript-translate-bot added review needed and removed changes requested labels

Sep 22, 2021

javascript-translate-bot requested a review from a team

September 22, 2021 18:11

Deep1Shikha requested review from rskhan167 and removed request for a team

September 23, 2021 14:24

Deep1Shikha commented Sep 23, 2021

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot requested a review from a team

September 23, 2021 14:24

rskhan167 commented Sep 23, 2021

Copy link

Copy Markdown

Contributor

Good work @Deep1Shikha , thanks for contributing. I am merging this PR. Hoping to see many more contributions from you. And Please let your friends and colleagues also know about this project. Thanks 👍

Deep1Shikha reacted with hooray emoji

All reactions

🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rskhan167 merged commit b90bfda into javascript-tutorial:master

Sep 23, 2021

javascript-translate-bot commented Sep 23, 2021

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Deep1Shikha reacted with hooray emoji

All reactions

🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Deep1Shikha commented Sep 23, 2021

Copy link

Copy Markdown

Contributor Author

Thank you! I am equally enthusiastic and glad. This was my first contribution and it has been merged. I will continue contributing. Grateful to you for your reviews. 🎉

rskhan167 reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rskhan167 added ready to merge and removed review needed labels

Sep 24, 2021

Reviewers

rskhan167

Awaiting requested review from rskhan167

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Deep1Shikha commented Sep 14, 2021

Uh oh!

CLAassistant commented Sep 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rskhan167 left a comment

Choose a reason for hiding this comment

Uh oh!

Deep1Shikha commented Sep 15, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Sep 15, 2021

Uh oh!

rskhan167 commented Sep 15, 2021

Uh oh!

Deep1Shikha commented Sep 15, 2021

Uh oh!

rskhan167 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

javascript-translate-bot commented Sep 15, 2021

Uh oh!

Deep1Shikha commented Sep 17, 2021

Uh oh!

rskhan167 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Sep 17, 2021

Uh oh!

Deep1Shikha commented Sep 23, 2021

Uh oh!

rskhan167 commented Sep 23, 2021

Uh oh!

javascript-translate-bot commented Sep 23, 2021

Uh oh!

Deep1Shikha commented Sep 23, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented Sep 14, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.