GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Code structure by bugron · Pull Request #72 · javascript-tutorial/hy.javascript.info

Conversation

@bugron

@bugron bugron commented Mar 7, 2021

Copy link
Copy Markdown
Contributor

This PR is ready for a full review.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bugron
Translate Code structure article
5295cab
@javascript-translate-bot javascript-translate-bot added the review needed label Mar 7, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team March 7, 2021 16:27
@javascript-translate-bot javascript-translate-bot mentioned this pull request Mar 7, 2021
Armenian Translation Progress #1
Open
ArthurHakobyan
ArthurHakobyan suggested changes Mar 8, 2021
View reviewed changes
Comment thread 1-js/02-first-steps/02-structure/article.md Outdated
```

Now if we run the code, only the first `alert` is shown and then we have an error!
Եթե գործարկենք այս կոդը, ապա կտեսնենք միայն առաջին `alert`–ի հաղորդագրությունը, ոիրց հետո սխալ կառաջանա։

@ArthurHakobyan ArthurHakobyan Mar 8, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ոիրց—> որից

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/02-structure/article.md Outdated
```

Now we have the "All fine now" message followed by `1` and `2`.
Այժմ կտեսնենք «Հիմա ամեն ինչ նորմալ է» հաղորդագրությունը, որին կհաջորդեն `1`–ը and `2`–ը։

@ArthurHakobyan ArthurHakobyan Mar 8, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and —> և

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/02-structure/article.md Outdated
````smart header="An example of an error"
If you're curious to see a concrete example of such an error, check this code out:
````smart header="Սխալի օրինակ"
Ահա կոդ, որը միջոցով կհանգենք նման սխալի՝

@ArthurHakobyan ArthurHakobyan Mar 8, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

որը միջոցով —> որի միջոցով

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/02-structure/article.md Outdated
```

Here, JavaScript interprets the line break as an "implicit" semicolon. This is called an [automatic semicolon insertion](https://tc39.github.io/ecma262/#sec-automatic-semicolon-insertion).
Այստեղ JavaScript–ն ընկալում է նոր տողին անցումը որտես կետ-ստորակետ։ Սա կոչվում է [կետ-ստորակետի ինքաշխատ ավելացում](https://tc39.github.io/ecma262/#sec-automatic-semicolon-insertion) (automatic semicolon insertion)։

@ArthurHakobyan ArthurHakobyan Mar 8, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

որտես —> որպես

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Mar 8, 2021
@javascript-translate-bot

javascript-translate-bot commented Mar 8, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bugron
Fix typos pointed by the reviewer
352981e
@bugron

bugron commented Mar 8, 2021

Copy link
Copy Markdown
Contributor Author

/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Mar 8, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team March 8, 2021 12:39
ArthurHakobyan
ArthurHakobyan approved these changes Mar 10, 2021
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Mar 10, 2021
@ArthurHakobyan
ArthurHakobyan merged commit 35acba4 into javascript-tutorial:master Mar 10, 2021
@javascript-translate-bot

javascript-translate-bot commented Mar 10, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bugron
bugron deleted the translation/02-structure branch March 12, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ArthurHakobyan ArthurHakobyan ArthurHakobyan approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bugron @javascript-translate-bot @ArthurHakobyan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.