GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Data types by arthur-gyulabyan · Pull Request #77 · javascript-tutorial/hy.javascript.info

Conversation

@arthur-gyulabyan

@arthur-gyulabyan arthur-gyulabyan commented Jul 9, 2021

Copy link
Copy Markdown
Contributor

Data types section translated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
arthur-gyulabyan added 3 commits July 10, 2021 03:02
@arthur-gyulabyan
feat: translate article.md of data types section
8207f16
@arthur-gyulabyan
feat: translate task.md of data types section
0915d03
@arthur-gyulabyan
feat: translate solution.md of data types section
4e7b49f
@javascript-translate-bot javascript-translate-bot added the review needed label Jul 9, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team July 9, 2021 23:07
@javascript-translate-bot javascript-translate-bot mentioned this pull request Jul 9, 2021
Armenian Translation Progress #1
Open
@javascript-translate-bot

javascript-translate-bot commented Jul 9, 2021

Copy link
Copy Markdown

Error: the article already has PR number in the Progress Issue #1, it's 77 ⁉️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@CLAassistant

CLAassistant commented Jul 9, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bugron

bugron commented Jul 10, 2021

Copy link
Copy Markdown
Contributor

@arthur-gyulabyan thanks for the PR. I'll review it soon. Keep up the good work!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arthur-gyulabyan

arthur-gyulabyan commented Jul 10, 2021

Copy link
Copy Markdown
Contributor Author

@bugron thank you for response.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
arthur-gyulabyan added 3 commits July 11, 2021 02:16
@arthur-gyulabyan
feat: translate article.md of interaction: alert, prompt, confirm sec…
e87963d 
…tion
@arthur-gyulabyan
feat: translate task.md of interaction: alert, prompt, confirm section
be2bf68
@arthur-gyulabyan
feat: translate solution.md of interaction: alert, prompt, confirm se…
a456830 
…ction
@bugron

bugron commented Jul 11, 2021

Copy link
Copy Markdown
Contributor

This looks great. I'll be reviewing your translations today. For future let's keep the one article - one PR principle.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arthur-gyulabyan

arthur-gyulabyan commented Jul 11, 2021

Copy link
Copy Markdown
Contributor Author

Oh, sorry for that mistake. I'll follow the principle in further PRs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bugron
bugron requested changes Jul 11, 2021
View reviewed changes

@bugron bugron left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arthur-gyulabyan thanks again for the PR. I am amazed by the quality of the translation, really!
Please do not get discouraged by the number of comments! Except for those new line comments there are just a few things to address and we'll be ready to merge this.
Way to go!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/05-types/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/02-first-steps/05-types/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/02-first-steps/05-types/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/02-first-steps/05-types/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/02-first-steps/05-types/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/02-first-steps/06-alert-prompt-confirm/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/02-first-steps/06-alert-prompt-confirm/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/02-first-steps/06-alert-prompt-confirm/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/02-first-steps/06-alert-prompt-confirm/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/02-first-steps/06-alert-prompt-confirm/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Jul 11, 2021
@javascript-translate-bot

javascript-translate-bot commented Jul 11, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
arthur-gyulabyan added 2 commits July 11, 2021 16:58
@arthur-gyulabyan
fix: unnecessary new lines removed, typos fixed
f328760
@arthur-gyulabyan
fix: unnecessary new lines removed, typos fixed
9ed10ee
@arthur-gyulabyan

arthur-gyulabyan commented Jul 11, 2021

Copy link
Copy Markdown
Contributor Author

@bugron thank you for review! The issue with new lines occurred because of my editor's settings. I fixed it, so now everything is okay. I also fixed typos and other bugs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arthur-gyulabyan

arthur-gyulabyan commented Jul 11, 2021

Copy link
Copy Markdown
Contributor Author

/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Jul 11, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team July 11, 2021 13:30
bugron
bugron approved these changes Jul 11, 2021
View reviewed changes

@bugron bugron left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Jul 11, 2021
@bugron

bugron commented Jul 11, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Thanks for your first PR! Merging and looking forward to your future contributions. 🎉🎉🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bugron
bugron merged commit df5f520 into javascript-tutorial:master Jul 11, 2021
@javascript-translate-bot

javascript-translate-bot commented Jul 11, 2021

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot

javascript-translate-bot commented Jul 11, 2021

Copy link
Copy Markdown

Error: the article already translated in the Progress Issue #1 ⁉️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bugron bugron bugron approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@arthur-gyulabyan @javascript-translate-bot @CLAassistant @bugron
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.