GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — Logical operators by vahmelk99 · Pull Request #82 · javascript-tutorial/hy.javascript.info Conversation
|
There was an error while loading. Please reload this page.
|
Thanks for the PR @vahmelk99. I'll be reviewing it soon. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Please do not be discouraged by the number of comments. It is normal for this project. Once the suggested changes are implemented I'll give it another round of reviews. Thanks.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Please make the requested changes. After it, add a comment "/done". |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@vahmelk99 also for future PRs the name of the PR should exactly match the title of the article you are translating (see #1). For example the title of this PR should have been |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Should I create a new PR? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@vahmelk99 nope, just have that noted for future PRs. Thanks. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
@vahmelk99 please make sure there are no unnecessary line shifts here and there, also make sure to restore original formatting and new lines where mentioned. Thanks for you contribution.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Please make the requested changes. After it, add a comment "/done". |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…tion.md Co-authored-by: Arsen Melikyan <[email protected]>
Co-authored-by: Arsen Melikyan <[email protected]>
Co-authored-by: Arsen Melikyan <[email protected]>
Co-authored-by: Arsen Melikyan <[email protected]>
Co-authored-by: Arsen Melikyan <[email protected]>
Co-authored-by: Arsen Melikyan <[email protected]>
Co-authored-by: Arsen Melikyan <[email protected]>
Co-authored-by: Arsen Melikyan <[email protected]>
|
@bugron thanks for your time. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
/done |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@vahmelk99 thanks for your efforts but unfortunately not all the comments are addressed. GitHub might hide some of them so please make sure everything is in order before we can move on to merging this PR. Thanks. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
@vahmelk99 looks superb! Thanks again for your contribution! I've fixed a few line shifts and svg translation stuff and we're ready to merge this PR.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
In the SVG file, I fixed the coordinates of the text, so there were not any overflowed texts. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@vahmelk99 the thing is that SVG file should not be modified directly, there is a note about that in README.md. A special |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.