GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Logical operators by vahmelk99 · Pull Request #82 · javascript-tutorial/hy.javascript.info

Conversation

@vahmelk99

@vahmelk99 vahmelk99 commented Aug 9, 2021

Copy link
Copy Markdown
Contributor

Please check my translation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
vahmelk99 added 17 commits August 3, 2021 01:45
@vahmelk99
article.md to line 19
eb51f73
@vahmelk99
OR operator ended
27c1964
@vahmelk99
&& translated
7a0456e
@vahmelk99
article added
e57228d
@vahmelk99
importance translated
ac13025
@vahmelk99
1-alert-null-2-undefined translated
6612518
@vahmelk99
3-alert-1-null-2 translated
b662a96
@vahmelk99
2-alert-or translated
c0cdc9a
@vahmelk99
2-alert-or translated
7646dd5
@vahmelk99
4-alert-and translated
f0d57a5
@vahmelk99
5-alert-and-or translated
54448c2
@vahmelk99
titles rename and 6th ex.
5895fdc
@vahmelk99
7-check-if-out-range translated
7b2e8c7
@vahmelk99
8-if-question translated
ccc824f
@vahmelk99
start translating 9-check-login
1bb3af5
@vahmelk99
Merge branch 'master' of https://github.com/vahmelk99/hy.javascript.info
addba0d
@vahmelk99
9-check-login translated
61801fd
@javascript-translate-bot javascript-translate-bot added the review needed label Aug 9, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team August 9, 2021 13:53
@CLAassistant

CLAassistant commented Aug 9, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bugron

bugron commented Aug 9, 2021

Copy link
Copy Markdown
Contributor

Thanks for the PR @vahmelk99. I'll be reviewing it soon.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bugron
bugron requested changes Aug 10, 2021
View reviewed changes

@bugron bugron left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not be discouraged by the number of comments. It is normal for this project. Once the suggested changes are implemented I'll give it another round of reviews. Thanks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/02-first-steps/11-logical-operators/1-alert-null-2-undefined/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/11-logical-operators/1-alert-null-2-undefined/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/11-logical-operators/1-alert-null-2-undefined/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/11-logical-operators/2-alert-or/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/11-logical-operators/2-alert-or/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/11-logical-operators/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/11-logical-operators/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/11-logical-operators/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/11-logical-operators/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/11-logical-operators/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Aug 10, 2021
@javascript-translate-bot

javascript-translate-bot commented Aug 10, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bugron

bugron commented Aug 10, 2021

Copy link
Copy Markdown
Contributor

@vahmelk99 also for future PRs the name of the PR should exactly match the title of the article you are translating (see #1). For example the title of this PR should have been Logical operators.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vahmelk99

vahmelk99 commented Aug 11, 2021

Copy link
Copy Markdown
Contributor Author

@vahmelk99 also for future PRs the name of the PR should exactly match the title of the article you are translating (see #1). For example the title of this PR should have been Logical operators.

Should I create a new PR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vahmelk99
translation bugfixes in logical operators
fe68296
@vahmelk99
vahmelk99 force-pushed the master branch from 4530853 to fe68296 Compare August 11, 2021 19:23
@bugron

bugron commented Aug 11, 2021

Copy link
Copy Markdown
Contributor

@vahmelk99 nope, just have that noted for future PRs. Thanks.

vahmelk99 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bugron
bugron reviewed Aug 13, 2021
View reviewed changes
Comment thread 1-js/02-first-steps/11-logical-operators/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

bugron
bugron reviewed Aug 13, 2021
View reviewed changes
Comment thread 1-js/02-first-steps/11-logical-operators/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

bugron
bugron reviewed Aug 13, 2021
View reviewed changes
Comment thread 1-js/02-first-steps/11-logical-operators/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

bugron
bugron requested changes Aug 13, 2021
View reviewed changes

@bugron bugron left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vahmelk99 please make sure there are no unnecessary line shifts here and there, also make sure to restore original formatting and new lines where mentioned. Thanks for you contribution.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vahmelk99 reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@javascript-translate-bot javascript-translate-bot removed the review needed label Aug 13, 2021
@javascript-translate-bot

javascript-translate-bot commented Aug 13, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Aug 13, 2021
vahmelk99 and others added 9 commits August 13, 2021 20:08
@vahmelk99 @bugron
Update 1-js/02-first-steps/11-logical-operators/3-alert-1-null-2/solu…
1f1ea7d
…tion.md

Co-authored-by: Arsen Melikyan <[email protected]>
@vahmelk99 @bugron
Update 1-js/02-first-steps/11-logical-operators/4-alert-and/task.md
87442eb
Co-authored-by: Arsen Melikyan <[email protected]>
@vahmelk99 @bugron
Update 1-js/02-first-steps/11-logical-operators/article.md
8b25f3b
Co-authored-by: Arsen Melikyan <[email protected]>
@vahmelk99 @bugron
Update 1-js/02-first-steps/11-logical-operators/article.md
dab4805
Co-authored-by: Arsen Melikyan <[email protected]>
@vahmelk99 @bugron
Update 1-js/02-first-steps/11-logical-operators/article.md
34f3333
Co-authored-by: Arsen Melikyan <[email protected]>
@vahmelk99 @bugron
Update 1-js/02-first-steps/11-logical-operators/article.md
dde7793
Co-authored-by: Arsen Melikyan <[email protected]>
@vahmelk99 @bugron
Update 1-js/02-first-steps/11-logical-operators/article.md
a12a35c
Co-authored-by: Arsen Melikyan <[email protected]>
@vahmelk99 @bugron
Update 1-js/02-first-steps/11-logical-operators/article.md
d85ba1b
Co-authored-by: Arsen Melikyan <[email protected]>
@vahmelk99
article fixed
a99cafd
@vahmelk99

vahmelk99 commented Aug 13, 2021

Copy link
Copy Markdown
Contributor Author

@bugron thanks for your time.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vahmelk99

vahmelk99 commented Aug 13, 2021

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Aug 13, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team August 13, 2021 16:22
@bugron

bugron commented Aug 13, 2021

Copy link
Copy Markdown
Contributor

@vahmelk99 thanks for your efforts but unfortunately not all the comments are addressed. GitHub might hide some of them so please make sure everything is in order before we can move on to merging this PR. Thanks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bugron
bugron approved these changes Aug 15, 2021
View reviewed changes

@bugron bugron left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vahmelk99 looks superb! Thanks again for your contribution! I've fixed a few line shifts and svg translation stuff and we're ready to merge this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vahmelk99 reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Aug 15, 2021
@bugron
bugron merged commit a99cafd into javascript-tutorial:master Aug 15, 2021
@bugron bugron changed the title 11-logical-operators translated Logical operators Aug 15, 2021
@bugron bugron mentioned this pull request Aug 15, 2021
Armenian Translation Progress #1
Open
@vahmelk99

vahmelk99 commented Aug 15, 2021

Copy link
Copy Markdown
Contributor Author

@vahmelk99 looks superb! Thanks again for your contribution! I've fixed a few line shifts and svg translation stuff and we're ready to merge this PR.

In the SVG file, I fixed the coordinates of the text, so there were not any overflowed texts.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bugron

bugron commented Aug 15, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@vahmelk99 the thing is that SVG file should not be modified directly, there is a note about that in README.md. A special images.yml file is used to define SVG text translations and text positions. But its a bit tricky to see the results here because you'll also need to set up the server, run a gulp job to generate new images based on that yml file and start the project (local version of javascriptinfo.com) to check whether everything looks as intended or not. Cheers.

vahmelk99 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bugron bugron bugron approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vahmelk99 @CLAassistant @bugron @javascript-translate-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.