GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Loops: while and for by vahmelk99 · Pull Request #84 · javascript-tutorial/hy.javascript.info

Conversation

vahmelk99 commented Aug 21, 2021

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vahmelk99 added 5 commits

August 17, 2021 22:28


          article while loops

7af7b49


          break translated

8f4f536


          article done

794be86


          ex1 translated

371b28c


          exs translated

88e3ddd

javascript-translate-bot added the review needed label

Aug 21, 2021

javascript-translate-bot requested a review from a team

August 21, 2021 12:46

javascript-translate-bot mentioned this pull request

Aug 21, 2021

Armenian Translation Progress #1

Open

vahmelk99 commented

Aug 21, 2021

View reviewed changes

Comment thread

1-js/02-first-steps/13-while-for/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update 1-js/02-first-steps/13-while-for/article.md

0ae628f

bugron requested changes

Aug 21, 2021

View reviewed changes

bugron left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good just a few comments to address. Besides those comments while you're resolving merge conflicts I'll get to reviewing the main article.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/13-while-for/2-which-value-while/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/13-while-for/5-replace-for-while/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/13-while-for/6-repeat-until-correct/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/13-while-for/7-list-primes/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/13-while-for/7-list-primes/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/13-while-for/7-list-primes/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Aug 21, 2021

javascript-translate-bot commented Aug 21, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vahmelk99 and others added 7 commits

August 21, 2021 18:08


          Update 1-js/02-first-steps/13-while-for/2-which-value-while/solution.md

feb54b2

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/5-replace-for-while/task.md

3cc0808

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/6-repeat-until-correct/soluti…

998b003

…on.md

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/7-list-primes/solution.md

763c6f2

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/7-list-primes/task.md

ffb0e12

Co-authored-by: Arsen Melikyan <[email protected]>


          7th sol fix

38730de


          Merge branch 'master' into master

9bb925b

vahmelk99 commented Aug 21, 2021

Copy link

Copy Markdown

Contributor Author

Thanks for the review)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vahmelk99 commented Aug 21, 2021

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Aug 21, 2021

javascript-translate-bot requested a review from a team

August 21, 2021 14:21

bugron requested changes

Aug 21, 2021

View reviewed changes

bugron left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's address a few more comments and we're good to go.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vahmelk99 reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

1-js/02-first-steps/13-while-for/7-list-primes/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/13-while-for/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/13-while-for/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/13-while-for/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/13-while-for/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/13-while-for/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/13-while-for/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/13-while-for/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/13-while-for/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/13-while-for/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Aug 21, 2021

javascript-translate-bot commented Aug 21, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vahmelk99 and others added 18 commits

August 21, 2021 19:31


          Update 1-js/02-first-steps/13-while-for/7-list-primes/solution.md

5806f13

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/article.md

e653e50

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/article.md

6f701c6

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/article.md

df1e71f

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/article.md

9f90054

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/article.md

14c423e

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/article.md

4ccbb8f

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/article.md

6482c5d

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/article.md

3f2c9c8

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/article.md

132ebde

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/article.md

8cef7f2

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/article.md

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/article.md

a84d5d3

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/article.md

74574c7

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/article.md

a76316c

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/article.md

b032a1f

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/article.md

6ba30b1

Co-authored-by: Arsen Melikyan <[email protected]>


          Update 1-js/02-first-steps/13-while-for/article.md

2de07d1

Co-authored-by: Arsen Melikyan <[email protected]>

vahmelk99 commented Aug 21, 2021

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Aug 21, 2021

javascript-translate-bot requested a review from a team

August 21, 2021 15:36

bugron commented Aug 21, 2021

Copy link

Copy Markdown

Contributor

This is awesome! Thanks @vahmelk99 for all your hard work. It is my pleasure to collaborate with you. Way to go! Merged.

vahmelk99 reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bugron merged commit dd52f90 into javascript-tutorial:master

Aug 21, 2021

javascript-translate-bot commented Aug 21, 2021

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

bugron

bugron requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

vahmelk99 commented Aug 21, 2021

Uh oh!

Uh oh!

bugron left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Aug 21, 2021

Uh oh!

vahmelk99 commented Aug 21, 2021

Uh oh!

vahmelk99 commented Aug 21, 2021

Uh oh!

bugron left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Aug 21, 2021

Uh oh!

vahmelk99 commented Aug 21, 2021

Uh oh!

bugron commented Aug 21, 2021

Uh oh!

javascript-translate-bot commented Aug 21, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bugron left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.