GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Strings by CheerfulCherry · Pull Request #133 · javascript-tutorial/pl.javascript.info

Conversation

@CheerfulCherry

@CheerfulCherry CheerfulCherry commented Jun 21, 2022

Copy link
Copy Markdown
Contributor

translated article about Strings

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
CheerfulCherry added 18 commits May 29, 2022 20:13
@CheerfulCherry
03-string>1-ucfirst
12b07a8
@CheerfulCherry
03-string>2-check-spam
b161b30
@CheerfulCherry
03-string>03-truncate
20587fa
@CheerfulCherry
03-string>4-extract-currency
badc904
@CheerfulCherry
string#quotes
f380c0b
@CheerfulCherry
string#special-characters
7e952df
@CheerfulCherry
string#string-length
82285a9
@CheerfulCherry
string#accessing-characters
adcfca6
@CheerfulCherry
string#strings-are-immutable
6ae22e7
@CheerfulCherry
string#changing-the-case
5100f5f
@CheerfulCherry
string#searching-for-a-substring
e2c28bf
@CheerfulCherry
string#getting-a-substring
075ea56
@CheerfulCherry
string#comparing-strings
b12d778
@CheerfulCherry
string#correct-comparisons
5ed97bc
@CheerfulCherry
string#surrogate-pairs
8d6c4b8
@CheerfulCherry
#diacritical-marks-and-normalization
2f21740
@CheerfulCherry
string#summary
c35927c
@CheerfulCherry
small fixes
66fa6e8
@javascript-translate-bot javascript-translate-bot added the review needed label Jun 21, 2022
@javascript-translate-bot
javascript-translate-bot requested a review from a team June 21, 2022 14:07
@javascript-translate-bot javascript-translate-bot mentioned this pull request Jun 21, 2022
Polish Translation Progress #1
Open
@CLAassistant

CLAassistant commented Jun 21, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

deivuss331
deivuss331 requested changes Oct 15, 2022
View reviewed changes
Comment thread 1-js/05-data-types/03-string/1-ucfirst/_js.view/test.js Outdated
});

it("Doesn't die on an empty string", function() {
it("Nie wysypuje się na na pustym łańcuchu", function() {

@deivuss331 deivuss331 Oct 15, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2x "na"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Oct 15, 2022
@javascript-translate-bot

javascript-translate-bot commented Oct 15, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CheerfulCherry
Update test.js
2281d2e
@CheerfulCherry

CheerfulCherry commented Oct 15, 2022

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Oct 15, 2022
@javascript-translate-bot
javascript-translate-bot requested a review from a team October 15, 2022 10:41
deivuss331
deivuss331 approved these changes Oct 15, 2022
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Oct 15, 2022
@deivuss331

deivuss331 commented Oct 15, 2022

Copy link
Copy Markdown
Member

@RafalMichniuk całkiem sprawnie wrzuciłeś poprawkę 😄 IMO jest ok, jak chcesz to zrób merge chyba że jeszcze ktoś doda review (ale chyba mało kto jest tu aktywny)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CheerfulCherry

CheerfulCherry commented Oct 15, 2022

Copy link
Copy Markdown
Contributor Author

@deivuss331 dzięki! 😎 OK, poczekam tydzień (to chyba nie dużo czasu w kontekście jak tu wszystko zasuwa 😅) i jak nie pojawi się żadne review, to zrobię merge 🙂

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CheerfulCherry
CheerfulCherry merged commit 1d7ff5c into javascript-tutorial:master Oct 22, 2022
@javascript-translate-bot

javascript-translate-bot commented Oct 22, 2022

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deivuss331 deivuss331 deivuss331 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@CheerfulCherry @CLAassistant @javascript-translate-bot @deivuss331
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.