GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fetch by mitroc · Pull Request #22 · javascript-tutorial/pl.javascript.info

Conversation

@mitroc

@mitroc mitroc commented Oct 5, 2019

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
mitroc added 7 commits October 5, 2019 20:29
mitroc
Translated 'sever.js'
e8b6c59
mitroc
Translate 'task.md'
9470b2a
mitroc
Translate 'solution'
27af43f
mitroc
Translate 'test.js'
d9a9d01
mitroc
Translated 'source.js'
835aaba
mitroc
Translated 'article.md'
363bc8e
mitroc
Correct 'article.md'
625b23f
@javascript-translate-bot javascript-translate-bot added the review needed label Oct 5, 2019
@javascript-translate-bot
javascript-translate-bot requested a review from a team October 5, 2019 21:29
@CLAassistant

CLAassistant commented Oct 5, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iliakan iliakan mentioned this pull request Oct 5, 2019
Polish Translation Progress #1
Open
mitroc added 3 commits October 6, 2019 01:23
mitroc
Translate 'article.md'
61c7794
mitroc
Reword 'article.md'
7333597
mitroc
Translate 'server.js'
c178a41
jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/01-fetch/01-fetch-users/_js.view/test.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/01-fetch/01-fetch-users/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/01-fetch/01-fetch-users/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/01-fetch/01-fetch-users/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/01-fetch/01-fetch-users/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/01-fetch/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/02-formdata/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/02-formdata/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/02-formdata/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/02-formdata/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/02-formdata/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/02-formdata/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/02-formdata/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/02-formdata/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/02-formdata/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 6, 2019
View reviewed changes
Comment thread 5-network/02-formdata/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@jakubdrozdek

jakubdrozdek commented Oct 6, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@mitroc Dobra robota! :) Podoba mi się to tłumaczenie. Oczywiście, musiałem wtrącić swoje trzy grosze (wyszły aż 52 grosze ;-) ), ale ogólne tłumaczenie jest na dobrym poziomie.
Jeszcze tylko ogarnij Git flow i praca będzie szła sprawnie.

Jako że to Twój pierwszy PR, możesz tego nie wiedzieć:
GitHub umożliwia łatwe zaaplikowanie sugerowanych zmian z poziomu dyskusji. Wystarczy dodać wszystkie sugestie do "batcha" i na koniec zaakceptować, tworząc pojedynczego commita ze wszystkimi zmianami.
image

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jakubdrozdek jakubdrozdek added changes requested and removed review needed labels Oct 6, 2019
@mitroc
Merge branch 'master' of https://github.com/javascript-tutorial/pl.ja…
52f7556
…vascript.info
@mitroc

mitroc commented Oct 7, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@jakubdrozdek W mordę, strasznie ten interfejs mają zawinięty. W robocie używamy bitbucketa, więc tu się gubię. Czyli widzę, że mogę zrobić pojedynczy commit, albo dodać do grupowego. Spoko. To co w takim razie robi pod spodem przycisk Resolve conversation, oprócz tego, że:

The entire conversation will be collapsed and marked as resolved, making it easier to find conversations that still need to be addressed.

Bo po tym, jak już jest resolved nie można dodać do batcha 😄 i trzeba zrobić unresolve, więc trochę podwójna robota. 😞

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jakubdrozdek

jakubdrozdek commented Oct 7, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Resolve conversation robi się automatycznie, gdy tylko wrzucisz commita z poprawkami dotyczącymi danej linii, o którą się rozchodzi we wspomnianym 'conversation'. Jeśli jednak komentarz nie wnosi niczego szczególnego albo nie zgadzasz się z nim i razem ustalimy, że jednak nie ma sensu czegoś zmieniać tak, jak to zasugerowałem, to możesz resolvować dla samego porządku w PR-ze :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jakubdrozdek

jakubdrozdek commented Oct 7, 2019

Copy link
Copy Markdown
Contributor

Z tego co widzę, to nie poprawiłeś kompletnie nic, a oznaczyłeś wątki jako 'resolved'... Przejdź jeszcze raz przez wszystko, daj 'unresolved', a później zrób batcha :-)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mitroc

mitroc commented Oct 8, 2019

Copy link
Copy Markdown
Contributor Author

Ech....

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mitroc and others added 3 commits October 8, 2019 11:35
mitroc @jakubdrozdek
Apply suggestions from code review
3b71594
Co-Authored-By: Jakub Drozdek <[email protected]>
@mitroc
Merge branch 'master' of https://github.com/javascript-tutorial/pl.ja…
3adf2cd
…vascript.info
@mitroc
Merge branch 'master' of https://github.com/mitroc/pl.javascript.info
5d606ab
@mitroc

mitroc commented Oct 19, 2019

Copy link
Copy Markdown
Contributor Author

@jakubdrozdek Rzucisz okiem na te otwarte kwestie?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jakubdrozdek

jakubdrozdek commented Oct 19, 2019

Copy link
Copy Markdown
Contributor

@mitroc Wybacz, zupełnie mi umknął ten PR... Odpowiedziałem i mój wniosek jest taki, że lepiej nie pisać nic niż napisać głupotę :-) Piszmy bez "klasa".

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mitroc added 2 commits October 20, 2019 13:46
@mitroc
Merge branch 'master' of https://github.com/javascript-tutorial/pl.ja…
ae0d66f
…vascript.info
@mitroc
Apply code review suggestions
c20bed7
jakubdrozdek
jakubdrozdek approved these changes Oct 20, 2019
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed changes requested labels Oct 20, 2019
@jakubdrozdek
jakubdrozdek merged commit 54bac9e into javascript-tutorial:master Oct 20, 2019
@javascript-translate-bot

javascript-translate-bot commented Oct 20, 2019

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakubdrozdek jakubdrozdek jakubdrozdek approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mitroc @CLAassistant @jakubdrozdek @javascript-translate-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.