GeezerVison is showing github.com — Fetch by mitroc · Pull Request #22 · javascript-tutorial/pl.javascript.info
Conversation
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
CLAassistant
commented
Oct 5, 2019
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
All committers have signed the CLA.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jakubdrozdek
commented
Oct 6, 2019
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
@mitroc Dobra robota! :) Podoba mi się to tłumaczenie. Oczywiście, musiałem wtrącić swoje trzy grosze (wyszły aż 52 grosze ;-) ), ale ogólne tłumaczenie jest na dobrym poziomie.
Jeszcze tylko ogarnij Git flow i praca będzie szła sprawnie.
Jako że to Twój pierwszy PR, możesz tego nie wiedzieć:
GitHub umożliwia łatwe zaaplikowanie sugerowanych zmian z poziomu dyskusji. Wystarczy dodać wszystkie sugestie do "batcha" i na koniec zaakceptować, tworząc pojedynczego commita ze wszystkimi zmianami.

|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
mitroc
commented
Oct 7, 2019
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
@jakubdrozdek W mordę, strasznie ten interfejs mają zawinięty. W robocie używamy bitbucketa, więc tu się gubię. Czyli widzę, że mogę zrobić pojedynczy commit, albo dodać do grupowego. Spoko. To co w takim razie robi pod spodem przycisk Resolve conversation, oprócz tego, że:
The entire conversation will be collapsed and marked as resolved, making it easier to find conversations that still need to be addressed.
Bo po tym, jak już jest resolved nie można dodać do batcha 😄 i trzeba zrobić unresolve, więc trochę podwójna robota. 😞
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
jakubdrozdek
commented
Oct 7, 2019
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
Resolve conversation robi się automatycznie, gdy tylko wrzucisz commita z poprawkami dotyczącymi danej linii, o którą się rozchodzi we wspomnianym 'conversation'. Jeśli jednak komentarz nie wnosi niczego szczególnego albo nie zgadzasz się z nim i razem ustalimy, że jednak nie ma sensu czegoś zmieniać tak, jak to zasugerowałem, to możesz resolvować dla samego porządku w PR-ze :)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Z tego co widzę, to nie poprawiłeś kompletnie nic, a oznaczyłeś wątki jako 'resolved'... Przejdź jeszcze raz przez wszystko, daj 'unresolved', a później zrób batcha :-)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@mitroc Wybacz, zupełnie mi umknął ten PR... Odpowiedziałem i mój wniosek jest taki, że lepiej nie pisać nic niż napisać głupotę :-) Piszmy bez "klasa".
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|