GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fetch: Download progress by mitroc · Pull Request #31 · javascript-tutorial/pl.javascript.info

Conversation

@mitroc

@mitroc mitroc commented Oct 20, 2019

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
mitroc and others added 22 commits October 5, 2019 20:29
mitroc
Translated 'sever.js'
e8b6c59
mitroc
Translate 'task.md'
9470b2a
mitroc
Translate 'solution'
27af43f
mitroc
Translate 'test.js'
d9a9d01
mitroc
Translated 'source.js'
835aaba
mitroc
Translated 'article.md'
363bc8e
mitroc
Correct 'article.md'
625b23f
mitroc
Translate 'article.md'
61c7794
mitroc
Reword 'article.md'
7333597
mitroc
Translate 'server.js'
c178a41
@mitroc
Merge branch 'master' of https://github.com/javascript-tutorial/pl.ja…
52f7556
…vascript.info
mitroc @jakubdrozdek
Apply suggestions from code review
3b71594
Co-Authored-By: Jakub Drozdek <[email protected]>
@mitroc
Merge branch 'master' of https://github.com/javascript-tutorial/pl.ja…
73a31b3
…vascript.info into 5-03-fetch-progress
@mitroc
Merge branch 'master' of https://github.com/javascript-tutorial/pl.ja…
3adf2cd
…vascript.info
@mitroc
Merge branch 'master' of https://github.com/mitroc/pl.javascript.info
5d606ab
@mitroc
Translate 'article.md' (wip)
d0fd799
@mitroc
Merge branch 'master' of https://github.com/javascript-tutorial/pl.ja…
ae0d66f
…vascript.info
@mitroc
Apply code review suggestions
c20bed7
@mitroc
Merge branch 'master' into 5-03-fetch-progress
1d76585
@mitroc
Translate fetch-progress.
6dbc5d7
@mitroc
Minor adjustments.
a444543
@mitroc
Merge branch 'master' of https://github.com/javascript-tutorial/pl.ja…
ad60b49
…vascript.info into 5-03-fetch-progress
@javascript-translate-bot javascript-translate-bot added the review needed label Oct 20, 2019
@javascript-translate-bot
javascript-translate-bot requested a review from a team October 20, 2019 17:34
@iliakan iliakan mentioned this pull request Oct 20, 2019
Polish Translation Progress #1
Open
@jakubdrozdek

jakubdrozdek commented Oct 20, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@mitroc Wygląda na to, że znów nie zrobiłeś brancha jak należy i masz śmieci w pull requeście.
image

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jakubdrozdek

jakubdrozdek commented Oct 20, 2019

Copy link
Copy Markdown
Contributor

Żeby nowo tworzony branch był zsynchronizowany z naszym tutaj masterem, musisz co jakiś czas (najlepiej przed każdym nowym branchem) aktualizować SWOJEGO mastera (na forku). Tutaj masz instrukcję, jak to zrobić za pomocą pull requesta: https://stackoverflow.com/questions/20984802/how-can-i-keep-my-fork-in-sync-without-adding-a-separate-remote/21131381#21131381

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 20, 2019
View reviewed changes
Comment thread 5-network/03-fetch-progress/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 20, 2019
View reviewed changes
Comment thread 5-network/03-fetch-progress/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 20, 2019
View reviewed changes
Comment thread 5-network/03-fetch-progress/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 20, 2019
View reviewed changes
Comment thread 5-network/03-fetch-progress/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 20, 2019
View reviewed changes
Comment thread 5-network/03-fetch-progress/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 20, 2019
View reviewed changes
Comment thread 5-network/03-fetch-progress/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 20, 2019
View reviewed changes
Comment thread 5-network/03-fetch-progress/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 20, 2019
View reviewed changes
Comment thread 5-network/03-fetch-progress/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 20, 2019
View reviewed changes
Comment thread 5-network/03-fetch-progress/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 20, 2019
View reviewed changes
Comment thread 5-network/03-fetch-progress/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 20, 2019
View reviewed changes
Comment thread 5-network/03-fetch-progress/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 20, 2019
View reviewed changes
Comment thread 5-network/03-fetch-progress/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 20, 2019
View reviewed changes
Comment thread 5-network/03-fetch-progress/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 20, 2019
View reviewed changes
Comment thread 5-network/03-fetch-progress/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakubdrozdek
jakubdrozdek reviewed Oct 20, 2019
View reviewed changes
Comment thread 5-network/03-fetch-progress/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

mitroc @jakubdrozdek
Apply suggestions from code review
578eca5
Co-Authored-By: Jakub Drozdek <[email protected]>
@mitroc

mitroc commented Oct 20, 2019

Copy link
Copy Markdown
Contributor Author

@jakubdrozdek Hmm, no właśnie zrobiłem pull upstream zanim stworzyłem branch do tego tłumaczenia. Ale potem, już w trakcie tłumaczenia pojawiły się na upstreamie nowe rzeczy no i akceptacja poprzedniego PRa, więc znowu zrobiłem pull upstream i domergowałem do tej gałęzi na której pracuję, żeby mieć aktualne zmiany. Może tam jakiegoś sqasha muszę zrobić.
A ten myk z SO też już testowałem i zasadniczo działał, ale coś mi tam nie grało, nie pamiętam już, chyba pokazywał mnie jako tego, który zrobił PR (albo coś w ten deseń).
Przed następnym zrobię sobie jakieś testowe repo na innym koncie i poćwiczę to :).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jakubdrozdek

jakubdrozdek commented Oct 20, 2019

Copy link
Copy Markdown
Contributor

@mitroc W tym przypadku, jako że robisz forka tylko dlatego, że chcesz wrzucać PR-y do tego repo, można zrobić inaczej, dużo prościej. Poza tłumaczeniami nie zależy Ci raczej na zachowaniu jakichkolwiek zmian na swoim forku, więc można go za każdym razem nadpisywać aktualną wersją mastera z tego repo.

Żeby zaktualizować swojego forka, możesz zrobić tak:

  1. git fetch --all
  2. git checkout master
  3. git reset upstream/master --hard
  4. git push -u origin master -f
    Spowoduje to nadpisanie Twojego lokalnego mastera tym z upstreama, nie ważne ile się zmieniło od ostatniej aktualizacji. Po tym możesz stworzyć nowego brancha, który nie będzie miał konfliktów.

Odnośnie sytuacji, gdzie stworzyłeś brancha, ale upstream się zmienił, możesz zrobić coś takiego, będąc na swoim branchu z tłumaczeniem: git rebase upstream/master. Spowoduje to przesunięcie w czasie Twojego brancha, tak jakby powstał on w oparciu o aktualnego mastera, a nie starego.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Oct 20, 2019
jakubdrozdek
jakubdrozdek approved these changes Oct 20, 2019
View reviewed changes
@javascript-translate-bot javascript-translate-bot added the needs +1 label Oct 20, 2019
@jakubdrozdek

jakubdrozdek commented Oct 20, 2019

Copy link
Copy Markdown
Contributor

Merguję, ale zanotuj sobie to, co Ci napisałem, żeby kolejny PR był już na czysto 🙂

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jakubdrozdek
jakubdrozdek merged commit 0e59e86 into javascript-tutorial:master Oct 20, 2019
@javascript-translate-bot

javascript-translate-bot commented Oct 20, 2019

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakubdrozdek jakubdrozdek jakubdrozdek approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mitroc @jakubdrozdek @javascript-translate-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.