GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Nullish coalescing operator '??' by sculpt0r · Pull Request #73 · javascript-tutorial/pl.javascript.info

Conversation

sculpt0r commented Oct 24, 2020

Copy link

Copy Markdown

Contributor

Translated to Polish

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added the review needed label

Oct 24, 2020

javascript-translate-bot requested a review from a team

October 24, 2020 20:03

CLAassistant commented Oct 24, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot mentioned this pull request

Oct 24, 2020

Polish Translation Progress #1

Open

akowalska622 suggested changes

Nov 7, 2021

View reviewed changes

akowalska622 left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good translation, one of the best here, kudos!
I suggested some minor changes, but without them the translation is also good to publish.

One comment about my first suggestion: polish version of MDN suggests different name for the nullish coalescing operator, I've mentioned it once, but if the author of PR decides to change it according to MDN, please check all of the occurrences in the whole text.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/12-nullish-coalescing-operator/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/12-nullish-coalescing-operator/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/12-nullish-coalescing-operator/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/12-nullish-coalescing-operator/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/12-nullish-coalescing-operator/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/12-nullish-coalescing-operator/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/02-first-steps/12-nullish-coalescing-operator/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Nov 7, 2021

javascript-translate-bot commented Nov 7, 2021

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

akowalska622 commented Nov 7, 2021

Copy link

Copy Markdown

Oh, and please sign CLA :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Bartłomiej Kalemba added 5 commits

August 12, 2022 13:28


          WIP: translated half of article

37f9093


          WIP translation part

14c2d04


          All translated - raw

270905c


          Small corrects

b21e7f2


          Remove misspell

f8d4b3a

sculpt0r force-pushed the 1-02-12_Nullish branch from 7bbbcec to f8d4b3a Compare

August 12, 2022 11:28


          Correct according to review

7d65cc7

sculpt0r commented Aug 12, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

Hi @akowalska622 ,
almost ~~a year~~ two years 😰 but I made corrects - sorry for such a long time with no response. Also, CLA is signed :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sculpt0r commented Aug 12, 2022

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Aug 12, 2022

javascript-translate-bot requested a review from a team

August 12, 2022 11:41

sculpt0r requested a review from akowalska622

August 12, 2022 11:41

CheerfulCherry reviewed

Sep 17, 2022

View reviewed changes

Comment thread

1-js/02-first-steps/12-nullish-coalescing-operator/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

CheerfulCherry reviewed

Sep 17, 2022

View reviewed changes

Comment thread

1-js/02-first-steps/12-nullish-coalescing-operator/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

CheerfulCherry reviewed

Sep 17, 2022

View reviewed changes

Comment thread

1-js/02-first-steps/12-nullish-coalescing-operator/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

CheerfulCherry suggested changes

Sep 17, 2022

View reviewed changes

CheerfulCherry left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM poza małymi "kosmetycznymi" poprawkami 🙂

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot removed the review needed label

Sep 17, 2022

javascript-translate-bot commented Sep 17, 2022

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Sep 17, 2022


          Correct c

817815b

sculpt0r commented Oct 13, 2022

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Oct 13, 2022

javascript-translate-bot requested review from a team and removed request for akowalska622

October 13, 2022 17:00

poplaw approved these changes

Oct 14, 2022

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels

Oct 14, 2022

CheerfulCherry approved these changes

Oct 15, 2022

View reviewed changes

CheerfulCherry merged commit 051f376 into javascript-tutorial:master

Oct 15, 2022

javascript-translate-bot commented Oct 15, 2022

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

poplaw

poplaw approved these changes

+2 more reviewers

akowalska622

akowalska622 requested changes

CheerfulCherry

CheerfulCherry approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

sculpt0r commented Oct 24, 2020

Uh oh!

CLAassistant commented Oct 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akowalska622 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Nov 7, 2021

Uh oh!

akowalska622 commented Nov 7, 2021

Uh oh!

sculpt0r commented Aug 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sculpt0r commented Aug 12, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CheerfulCherry left a comment

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Sep 17, 2022

Uh oh!

sculpt0r commented Oct 13, 2022

Uh oh!

javascript-translate-bot commented Oct 15, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

CLAassistant commented Oct 24, 2020 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

sculpt0r commented Aug 12, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.