GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Object methods, "this" by covalt1985 · Pull Request #99 · javascript-tutorial/pl.javascript.info

Conversation

@covalt1985

@covalt1985 covalt1985 commented Jun 1, 2021

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
covalt1985 added 25 commits May 31, 2021 23:12
@covalt1985
section translated
5acaad4
@covalt1985
translated
0b7cdf7
@covalt1985
1/3
fc36130
@covalt1985
almost done
c27d811
@covalt1985
translated
cec745d
@covalt1985
typo
2c00ba5
@covalt1985
Small fixes
f32d381
@covalt1985
Fix
682ad7a
@covalt1985
last fixes
3c6e3b2
@covalt1985
translated
95071a1
@covalt1985
translated
c9f8bf6
@covalt1985
fix
528001f
@covalt1985
translated
c2246d4
@covalt1985
translated
6c37606
@covalt1985
translated
4d37377
@covalt1985
translated
bf914f1
@covalt1985
translated
fc8e2d0
@covalt1985
fix
c6e7d40
@covalt1985
f
e619579
@covalt1985
fix
fad7054
@covalt1985
f
4ce04d7
@covalt1985
f
30fc462
@covalt1985
f
1ce5947
@covalt1985
f
ef13202
@covalt1985
f
d8beb4e
@javascript-translate-bot javascript-translate-bot added the review needed label Jun 1, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team June 1, 2021 23:12
@CLAassistant

CLAassistant commented Jun 1, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot mentioned this pull request Jun 1, 2021
Polish Translation Progress #1
Open
deivuss331
deivuss331 requested changes Nov 7, 2021
View reviewed changes
Comment thread 1-js/04-object-basics/04-object-methods/2-check-syntax/solution.md Outdated
W większości przeglądarek wiadomość o błędzie nie zawiera zbyt wielu szczegółów mówiących co poszło nie tak.

The error message in most browsers does not give us much of a clue about what went wrong.
**Błąd wystąpił ponieważ nie ma średnika po`user = {...}`.**

@deivuss331 deivuss331 Nov 7, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space between "po" and "`user..."

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/04-object-basics/04-object-methods/2-check-syntax/solution.md Outdated
```

Then we can also see that such a joint expression is syntactically a call of the object `{ go: ... }` as a function with the argument `(user.go)`. And that also happens on the same line with `let user`, so the `user` object has not yet even been defined, hence the error.
Teraz widzimy, że taka składnia jest w zasadzie wywołaniem funkcji `{ go: ... }` z argumentem `(user.go)`. W dodatku wywołanie to znajduje się w tej samej linijce co `let user`, więc do obiekt `user` nie został jeszcze nawet zdefiniowany, dlatego pojawia się błąd.

@deivuss331 deivuss331 Nov 7, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sense of the first sentence has changed a bit. It should be something like: "Teraz widzimy, że taka składnia jest w zasadzie wywołaniem objektu { go: ... } jako funkcji z argumentem...".

Also, please remove redunand "do" word from that part of the second sentence: "więc do obiekt user nie został jeszcze..."

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/04-object-basics/04-object-methods/2-check-syntax/task.md Outdated
---

# Syntax check
# Sprawdzian ze składni

@deivuss331 deivuss331 Nov 7, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be more like: "Sprawdzenie składni"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/04-object-basics/04-object-methods/3-why-this/solution.md Outdated
1. Jest to zwykłe wywołanie metody obiektu.

2. The same, brackets do not change the order of operations here, the dot is first anyway.
2. Tak jak powyżej. Nawiasy nie zmieniają tutaj kolejności wykonywania działań. Kropka ma pierwszeństwo.

@deivuss331 deivuss331 Nov 7, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to avoid splitting one original sentence into some smaller ones while translating.

So please change that to: "Tak jak powyżej, nawiasy nie zmieniają tutaj kolejności wykonywania działań, kropka i tak ma pierwszeństwo."

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/04-object-basics/04-object-methods/3-why-this/task.md Outdated
---

# Explain the value of "this"
# Określ wartość "this":

@deivuss331 deivuss331 Nov 7, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove redunand ":" sign at the end of line.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/04-object-basics/04-object-methods/4-object-property-this/solution.md Outdated
Wartość `this` jest tu ustalona wyłącznie dla tej funkcji. Bloki kodu i obiekty nie są w tym przypadku brane pod uwagę.

So `ref: this` actually takes current `this` of the function.
Zatem `ref:this` jest równoznaczne z `this` funkcji.

@deivuss331 deivuss331 Nov 7, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change "ref:this" into "ref: this" just for clarity.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/04-object-basics/04-object-methods/4-object-property-this/task.md Outdated
---

# Using "this" in object literal
# "this" w literałach obiektowych

@deivuss331 deivuss331 Nov 7, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Używanie this w obiektach" sounds better to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/04-object-basics/04-object-methods/4-object-property-this/task.md Outdated
Poniższa funkcja `makeUser` zwraca obiekt.

What is the result of accessing its `ref`? Why?
Jaki będzie rezultat dostępu do jego `ref` ? I dlaczego?

@deivuss331 deivuss331 Nov 7, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove space between ref and question mark

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/04-object-basics/04-object-methods/article.md Outdated
Często się zdarza, że metoda obiektu do poprawnego działania potrzebuje dostępu do informacji zawartej w tym samym obiekcie.

For instance, the code inside `user.sayHi()` may need the name of the `user`.
DLa przykładu, kod wewnątrz `user.sayHi()` może wymagać imienia użytkownika `user`.

@deivuss331 deivuss331 Nov 7, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

word "DLa" should have only first letter capital

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/04-object-basics/04-object-methods/article.md Outdated
Możliwe jest również uzyskanie dostępu do obiektu bez używania `this`, przez odwołanie się do niego za pomocą zmiennej z zewnątrz:

```js
```js run

@deivuss331 deivuss331 Nov 7, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove run

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Nov 7, 2021
@javascript-translate-bot

javascript-translate-bot commented Nov 7, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@covalt1985
review fix
769f335
@covalt1985

covalt1985 commented Nov 7, 2021

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Nov 7, 2021
@javascript-translate-bot
javascript-translate-bot requested a review from a team November 7, 2021 23:33
@deivuss331
deivuss331 self-requested a review June 21, 2022 19:30
deivuss331
deivuss331 approved these changes Jun 21, 2022
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Jun 21, 2022
@deivuss331
deivuss331 merged commit 1545116 into javascript-tutorial:master Jun 21, 2022
@javascript-translate-bot

javascript-translate-bot commented Jun 21, 2022

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@deivuss331 deivuss331 added ready to merge and removed needs +1 labels Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deivuss331 deivuss331 deivuss331 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@covalt1985 @CLAassistant @javascript-translate-bot @deivuss331
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.