GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Data types by jonnathan-ls · Pull Request #243 · javascript-tutorial/pt.javascript.info

Conversation

@jonnathan-ls

@jonnathan-ls jonnathan-ls commented Jun 16, 2022

Copy link
Copy Markdown
Contributor

Data types

📝 Goal

Article update

☑ What was done?

  • Pending text translation

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
renatocfrancisco reacted with laugh emoji
All reactions
  • 😄 1 reaction
@javascript-translate-bot javascript-translate-bot added the review needed label Jun 16, 2022
@javascript-translate-bot
javascript-translate-bot requested a review from a team June 16, 2022 01:34
@javascript-translate-bot

javascript-translate-bot commented Jun 16, 2022

Copy link
Copy Markdown

Error: the article already translated in the Progress Issue #1 ⁉️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jonnathan-ls
fix(first-steps): translates the rest of the article about data types
f579000
@jonnathan-ls
jonnathan-ls force-pushed the fix/steps-types branch from b27374e to f579000 Compare June 16, 2022 01:35
@jonnathan-ls

jonnathan-ls commented Jun 16, 2022

Copy link
Copy Markdown
Contributor Author

Error: the article already translated in the Progress Issue #1 ⁉️
#243 (comment) javascript-translate-bot

There is still text that has not been translated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@odsantos

odsantos commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Error: the article already translated in the Progress Issue #1 interrobang
#243 (comment) javascript-translate-bot

There is still text that has not been translated.

Hi,

Will you translate the missing parts, including solution and task?
It would be helpful to review that as lesson, the whole translated article as well as the rest.

Trying to know your plan regarding to this lesson.

Thanks, Osvaldo.
jonnathan-ls reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
renatocfrancisco
renatocfrancisco reviewed Jul 31, 2023
View reviewed changes

@renatocfrancisco renatocfrancisco left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 73, the english sentence still in the file.
Moreover, good job!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jonnathan-ls reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@jonnathan-ls
Merge branch 'master' of https://github.com/jonnathan-ls/pt.javascrip…
31b5581 
…t.info into fix/steps-types
@jonnathan-ls

jonnathan-ls commented Aug 6, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Olá @renatocfrancisco,

Obrigado pela observação, não tinha percebido ❤️

Olá @odsantos,

Will you translate the missing parts, including solution and task?
It would be helpful to review that as lesson, the whole translated article as well as the rest.

O PR contempla toda tradução do artigo, com exceção da linha 73 como citado pelo Renato
Adicionei um novo commit com o ajuste.

Por desencargo, também atualizei com a master do repositório original.

Poderia adicionar sua revisão a este PR?
renatocfrancisco reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jonnathan-ls
refactor: corrects spelling errors and untranslated text
60e4ab4
@jonnathan-ls jonnathan-ls mentioned this pull request Aug 6, 2023
Portuguese Translation Progress #1
Open
@odsantos

odsantos commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

Hi @jonnathan-ls , sim. Logo que possivel. Obrigado.
jonnathan-ls reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nazarepiedady

nazarepiedady commented Apr 2, 2024

Copy link
Copy Markdown
Member

@peruibeloko, @jonnathan-ls, what is missing in this pull request?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jonnathan-ls

jonnathan-ls commented Apr 7, 2024

Copy link
Copy Markdown
Contributor Author

... what is missing in this pull request?

The review by two maintainers is missing, I will not contribute with the review, as the PR is precisely my own, there is no point in reviewing it myself

@nazarepiedady Could you add your review?
nazarepiedady reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nazarepiedady
nazarepiedady approved these changes Apr 7, 2024
View reviewed changes

@nazarepiedady nazarepiedady left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could improve it more ahead, but for now, it is good enough to be approved.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/05-types/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Apr 7, 2024
@nazarepiedady

nazarepiedady commented Apr 7, 2024

Copy link
Copy Markdown
Member

@jonnathan-ls, now we need one more review. It should take some time because we are running under forces.
jonnathan-ls reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nazarepiedady

nazarepiedady commented Apr 8, 2024

Copy link
Copy Markdown
Member

@peruibeloko, are you available to review this pull request?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
peruibeloko
peruibeloko suggested changes Apr 8, 2024
View reviewed changes

@peruibeloko peruibeloko left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duas mudanças rápidas e está aprovado

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/05-types/article.md Outdated
Em JavaScript, o tipo "number" não pode representar valores inteiros maiores que <code>(2<sup>53</sup>-1)</code> (que é `9007199254740991`) ou menores que <code>-(2<sup>53</sup>-1)</code> para negativos. É uma limitação técnica causada por sua representação interna.

For most purposes that's quite enough, but sometimes we need really big numbers, e.g. for cryptography or microsecond-precision timestamps.
Para a maioria dos propósitos, isso é o suficiente, mas às vezes precisamos de números realmente grandes, por exemplo, para criptografia ou carimbos de data/hora com precisão de microssegundos.

@peruibeloko peruibeloko Apr 8, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is duplicated at line 75

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@jonnathan-ls jonnathan-ls Apr 14, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/05-types/article.md Outdated
```

You can check [*MDN* BigInt compatibility table](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt#Browser_compatibility) to know which versions of a browser are supported.
Você pode verificar a [tabela de compatibilidade do *MDN* BigInt](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt#browser_compatibility) para saber quais versões de um navegador são suportadas.

@peruibeloko peruibeloko Apr 8, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Você pode verificar a [tabela de compatibilidade do *MDN* sobre BigInt]

ou

Você pode verificar a [tabela de compatibilidade do BigInt na *MDN*]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@jonnathan-ls jonnathan-ls Apr 14, 2024

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added the changes requested label Apr 8, 2024
@javascript-translate-bot

javascript-translate-bot commented Apr 8, 2024

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nazarepiedady

nazarepiedady commented Apr 9, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@jonnathan-ls, could you consider the reviews did?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jonnathan-ls added 3 commits April 14, 2024 14:05
@jonnathan-ls
Merge branch 'master' of https://github.com/javascript-tutorial/pt.ja…
ed8e1b4 
…vascript.info into pr/243
@jonnathan-ls
refactor: adds adjustments according to code review suggestions
4a7029e
@jonnathan-ls
feat: adds original content from English repository (en.javascript.in…
7cafcbb 
…fo) and apply translation

See: https://github.com/javascript-tutorial/en.javascript.info/blob/master/1-js/02-first-steps/05-types/article.md#bigint-bigint-type
@jonnathan-ls

jonnathan-ls commented Apr 14, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

... could you consider the reviews did?

/done @nazarepiedady

I applied the requests noted by @peruibeloko, see commit 4a7029e. And I also added pending content that I noticed when accessing the article from the official English repository bigint-type session, see commit 7cafcbb
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Apr 14, 2024
@javascript-translate-bot
javascript-translate-bot requested a review from a team April 14, 2024 17:39
nazarepiedady
nazarepiedady approved these changes Apr 14, 2024
View reviewed changes

@nazarepiedady nazarepiedady left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good enough to be approved.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
peruibeloko
peruibeloko approved these changes Apr 15, 2024
View reviewed changes

@peruibeloko peruibeloko left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nazarepiedady and renatocfrancisco reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nazarepiedady
nazarepiedady merged commit e9d2d8c into javascript-tutorial:master Apr 16, 2024
@javascript-translate-bot

javascript-translate-bot commented Apr 16, 2024

Copy link
Copy Markdown

Error: the article already translated in the Progress Issue #1 ⁉️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jonnathan-ls jonnathan-ls removed needs +1 review needed labels Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nazarepiedady nazarepiedady nazarepiedady approved these changes
+2 more reviewers
@renatocfrancisco renatocfrancisco renatocfrancisco left review comments
@peruibeloko peruibeloko peruibeloko approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@jonnathan-ls @javascript-translate-bot @odsantos @nazarepiedady @peruibeloko @renatocfrancisco
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.