GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||
GeezerVison is showing github.com — Character classes by odsantos · Pull Request #274 · javascript-tutorial/pt.javascript.info Conversation
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
In this line, it could be ...se é um sinal de pontuação. Or maybe I'm wrong.Besides that, good job 👍🏻
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
jonnathan-ls
approved these changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM Adicionei um commit com a tradução do SVG na qual ficou pendente: 6bd748a
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
|
@renatocfrancisco Precisamos verificar de incluí-lo como revisor deste repositório. Outro detalhe, em sua revisão, como está registrando a solicitação? Aparece como comentário e o github registra seu nome como revisor: Mas no painel onde mostra a opção de aceitarmos o PR e o status do mesmo, o github não o registrou a revisão como um solicitação de mudança a ser aprovada antes de mergear: Confirme se no momento que está registrando sua revisão está marcando a opção que "solicita mudanças" antes do "merge" acontecer: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
A opção aparece, mas eu não aprovei e nem requisitei mudanças, eu só comentei, porque vai que minha revisão está incorreta. Eu não sou maintainer, só queria ajudar. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Show, e tem razão, melhor buscarmos alinhamento sobre essa parte de registro como revisor e contribuição. Eu também não era maintainer, acabei me tornando quando procurei contribuir como revisor e fui convidado, caso for de interesse, creio que o @odsantos pode nos direcionar se existe a possibilidade e levarmos ao proprietário do repositório. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@jonnathan-ls tudo bem. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@nazarepiedady consegue revisar? ❤️ PR tranquilo rs |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@jonnathan-ls, parece que temos um conflito no ficheiro |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
/done @nazarepiedady Resolvido. Antes de aceitar o merge, lembre-se de marcar sua revisão como aprovada. Ou se tiver solicitado alguma revisão, verás uma opção de aprovação no quadrante "Changes approved" (acima do campo de "merge pull request") |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
It looks fine, so I approve the review.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@odsantos @nazarepiedady Os trechos |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
@peruibeloko I'll check what you mean and hopefully get back to you soon. Thanks. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Ótima observação @peruibeloko ❤️, não percebemos isso nas reviews e MR @odsantos, de fato, os trechos não devem ser traduzidos, talvez impacte quando o repositório PT estiver apto para ser carregado no site https://javascript.info/ A página https://javascript.info/regexp-character-classes, omitiu a palavra, então deve ser realmente utilizado no contexto do site em vez da documentação. Veja que a página em Espanhol https://es.javascript.info/regexp-character-classes não contemplou a tradução, conforme o arquivo markdown https://github.com/javascript-tutorial/es.javascript.info/blob/master/9-regular-expressions/02-regexp-character-classes/article.md O mesmo ocorre para as demais linguagens já traduzidas. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.