GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Character classes by odsantos · Pull Request #274 · javascript-tutorial/pt.javascript.info

Conversation

@odsantos

@odsantos odsantos commented Jan 25, 2023

Copy link
Copy Markdown
Contributor

This is an @fsdude translated article available in #143.
I closed that PR due to conflicts and, since @fsdude might be unavailable to continue, I'm placing his translation here with a few changes I added.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
odsantos added 3 commits January 23, 2023 23:28
@odsantos
Update "Character classes" translation
820c492
@odsantos
Update "Character classes" translation (2)
a8cef19
@odsantos
Update "Character classes" translation (2)
ca7a248
@javascript-translate-bot javascript-translate-bot added the review needed label Jan 25, 2023
@javascript-translate-bot
javascript-translate-bot requested a review from a team January 25, 2023 20:32
@javascript-translate-bot javascript-translate-bot mentioned this pull request Jan 25, 2023
Portuguese Translation Progress #1
Open
renatocfrancisco
renatocfrancisco reviewed Jul 31, 2023
View reviewed changes

@renatocfrancisco renatocfrancisco left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pt.javascript.info/9-regular-expressions/02-regexp-character-classes/article.md

Line 201 in ca7a248

A codificação Unicode, usada pelo JavaScript para strings, fornece muitas propriedades para caracteres, como: a qual idioma a letra pertence (se for uma letra), é um sinal de pontuação, etc.

In this line, it could be ...se é um sinal de pontuação. Or maybe I'm wrong.
Besides that, good job 👍🏻

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
jonnathan-ls added 2 commits August 13, 2023 14:01
@jonnathan-ls
Merge branch 'master' of https://github.com/javascript-tutorial/pt.ja…
b538c0b
…vascript.info into pr/274
@jonnathan-ls
refactor: add svg translation
6bd748a
jonnathan-ls
jonnathan-ls approved these changes Aug 13, 2023
View reviewed changes

@jonnathan-ls jonnathan-ls left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Adicionei um commit com a tradução do SVG na qual ficou pendente: 6bd748a

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Aug 13, 2023
@jonnathan-ls

jonnathan-ls commented Aug 13, 2023

Copy link
Copy Markdown
Contributor

In this line, it could be ...se é um sinal de pontuação. Or maybe I'm wrong.
Besides that, good job 👍🏻

Concordo com @renatocfrancisco, realizando a tradução ficou parecendo que o que vêm depois da vírgula acaba sendo uma conclusão do que está antes da vírgula.

Na língua original (inglês), a tradução "ao pé da letra" me deixou confuso, então me questiono se a expressão após a virgula seria uma opção (outro item de exemplo) da linha de raciocínio do parágrafo ... se realmente for, entendo que ter um "se" deixa mais nítido que é um outro ponto de exemplo do que o que vem depois da vírgula acabar sendo a conclusão do primeiro ...(se for uma letra)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jonnathan-ls

jonnathan-ls commented Aug 13, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@renatocfrancisco Precisamos verificar de incluí-lo como revisor deste repositório.

Outro detalhe, em sua revisão, como está registrando a solicitação?

Aparece como comentário e o github registra seu nome como revisor:

image

Mas no painel onde mostra a opção de aceitarmos o PR e o status do mesmo, o github não o registrou a revisão como um solicitação de mudança a ser aprovada antes de mergear:

image

Confirme se no momento que está registrando sua revisão está marcando a opção que "solicita mudanças" antes do "merge" acontecer:

image

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@renatocfrancisco

renatocfrancisco commented Aug 13, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

@jonnathan-ls

A opção aparece, mas eu não aprovei e nem requisitei mudanças, eu só comentei, porque vai que minha revisão está incorreta. Eu não sou maintainer, só queria ajudar.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jonnathan-ls

jonnathan-ls commented Aug 13, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

... Eu não sou maintainer, só queria ajudar.

Show, e tem razão, melhor buscarmos alinhamento sobre essa parte de registro como revisor e contribuição. Eu também não era maintainer, acabei me tornando quando procurei contribuir como revisor e fui convidado, caso for de interesse, creio que o @odsantos pode nos direcionar se existe a possibilidade e levarmos ao proprietário do repositório.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@renatocfrancisco

renatocfrancisco commented Aug 13, 2023

Copy link
Copy Markdown

@jonnathan-ls tudo bem.
se não der certo, não tem problema também :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jonnathan-ls

jonnathan-ls commented Dec 23, 2023

Copy link
Copy Markdown
Contributor

@nazarepiedady consegue revisar? ❤️ PR tranquilo rs
Já tem duas revisôes (01 maintainer e de outro colaborador)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nazarepiedady

nazarepiedady commented Dec 23, 2023

Copy link
Copy Markdown
Member

@jonnathan-ls, parece que temos um conflito no ficheiro images.yml, tens como resolvê-lo?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jonnathan-ls
Merge branch 'master' of https://github.com/javascript-tutorial/pt.ja…
8bce9ce
…vascript.info into pr/274
@jonnathan-ls

jonnathan-ls commented Dec 29, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

... parece que temos um conflito no ficheiro images.yml, tens como resolvê-lo?

/done

@nazarepiedady Resolvido.

Antes de aceitar o merge, lembre-se de marcar sua revisão como aprovada.
O procedimento pode ser feito na seção de "Files changed"

image

Ou se tiver solicitado alguma revisão, verás uma opção de aprovação no quadrante "Changes approved" (acima do campo de "merge pull request")

image

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nazarepiedady
nazarepiedady approved these changes Dec 31, 2023
View reviewed changes

@nazarepiedady nazarepiedady left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine, so I approve the review.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nazarepiedady
nazarepiedady merged commit df14a21 into javascript-tutorial:master Dec 31, 2023
@javascript-translate-bot

javascript-translate-bot commented Dec 31, 2023

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

jonnathan-ls reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@peruibeloko

peruibeloko commented Jan 17, 2024

Copy link
Copy Markdown
Contributor

@odsantos @nazarepiedady Os trechos pattern: não devem ser traduzidos pois fazem parte do template para produção do site final, posso realizar essas correções e abrir uma PR?

jonnathan-ls reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@odsantos

odsantos commented Jan 17, 2024

Copy link
Copy Markdown
Contributor Author

@odsantos @nazarepiedady Os trechos pattern: não devem ser traduzidos pois fazem parte do template para produção do site final, posso realizar essas correções e abrir uma PR?

@peruibeloko I'll check what you mean and hopefully get back to you soon. Thanks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@peruibeloko peruibeloko mentioned this pull request Jan 17, 2024
Methods of RegExp and String #141
Merged
@jonnathan-ls

jonnathan-ls commented Jan 20, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Os trechos pattern: não devem ser traduzidos ...

Ótima observação @peruibeloko ❤️, não percebemos isso nas reviews e MR
A vontade para abrir MR com fix, se não puder, nos avise? Para não acabarmos esquecendo ...

@odsantos, de fato, os trechos não devem ser traduzidos, talvez impacte quando o repositório PT estiver apto para ser carregado no site https://javascript.info/

A página https://javascript.info/regexp-character-classes, omitiu a palavra, então deve ser realmente utilizado no contexto do site em vez da documentação.

Veja que a página em Espanhol https://es.javascript.info/regexp-character-classes não contemplou a tradução, conforme o arquivo markdown https://github.com/javascript-tutorial/es.javascript.info/blob/master/9-regular-expressions/02-regexp-character-classes/article.md

O mesmo ocorre para as demais linguagens já traduzidas.

peruibeloko reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nazarepiedady nazarepiedady nazarepiedady approved these changes
@jonnathan-ls jonnathan-ls jonnathan-ls approved these changes
+1 more reviewer
@renatocfrancisco renatocfrancisco renatocfrancisco left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@odsantos @jonnathan-ls @renatocfrancisco @nazarepiedady @javascript-translate-bot @peruibeloko
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.