GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Mixins by danilolmc · Pull Request #382 · javascript-tutorial/pt.javascript.info

Conversation

@danilolmc

@danilolmc danilolmc commented Mar 10, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@danilolmc
Update mixins article
ba36b3a
@javascript-translate-bot javascript-translate-bot added the review needed label Mar 10, 2023
@javascript-translate-bot
javascript-translate-bot requested a review from a team March 10, 2023 17:41
@CLAassistant

CLAassistant commented Mar 10, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@odsantos

odsantos commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

Hi @DaniloLima122 ,

Appreciated your efforts.
Under the title For New Translators, on the top of #1 , you may find instructions for claiming the article and naming the pull request.

Would you please follow them?
Thanks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@danilolmc danilolmc changed the title Update mixins article Mixins Mar 11, 2023
@danilolmc

danilolmc commented Mar 11, 2023

Copy link
Copy Markdown
Contributor Author

Hi @odsantos !

Thank you for the tips!

Now I think the PR name is correct, according the name of the article!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@odsantos

odsantos commented Mar 12, 2023

Copy link
Copy Markdown
Contributor

Hi @DaniloLima122 , it also is necessary to claim it in your name, according to the same instructions, thus you need to add a comment on that page with this title too. After that, if the bot does not reserve on your name and add this PR, a maintainer may do it manually. Thanks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@danilolmc

danilolmc commented Mar 13, 2023

Copy link
Copy Markdown
Contributor Author

Hi @DaniloLima122 , it also is necessary to claim it in your name, according to the same instructions, thus you need to add a comment on that page with this title too. After that, if the bot does not reserve on your name and add this PR, a maintainer may do it manually. Thanks.

Hi @odsantos , thank you! It's done!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@odsantos odsantos mentioned this pull request Mar 13, 2023
Portuguese Translation Progress #1
Open
@odsantos

odsantos commented Mar 13, 2023

Copy link
Copy Markdown
Contributor

Hi @DaniloLima122 , in the future please do not forget to claim first, then to give the PR the same name as on that page.
The bot could reserve it in your name, and usually it can also assign the PR later, but no worries the PR is there as well, done manually.
Thanks for your efforts.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@danilolmc

danilolmc commented Mar 13, 2023

Copy link
Copy Markdown
Contributor Author

Hi @DaniloLima122 , in the future please do not forget to claim first, then to give the PR the same name as on that page.
The bot could reserve it in your name, and usually it can also assign the PR later, but no worries the PR is there as well, done manually.
Thanks for your efforts.

Hi @odsantos ! Great, I won't, thanks for your support! 😁

odsantos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

odsantos
odsantos requested changes Mar 14, 2023
View reviewed changes

@odsantos odsantos left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @danilolmc ,

Here is a review.

Please keep the translation line numbers matching the original (English) even if there is too little or too much space, and if you do not mind, also translate the text inside strings, but not variable names as you did.

Appreciate it if you tell me where you might disagree with this revision.

Thank you,
Osvaldo.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/09-classes/07-mixins/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/09-classes/07-mixins/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/09-classes/07-mixins/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/09-classes/07-mixins/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/09-classes/07-mixins/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/09-classes/07-mixins/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/09-classes/07-mixins/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/09-classes/07-mixins/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/09-classes/07-mixins/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/09-classes/07-mixins/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Mar 14, 2023
@javascript-translate-bot

javascript-translate-bot commented Mar 14, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@danilolmc
it fixes grammar mistakes
787647e
@odsantos

odsantos commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

Hi @danilolmc ,

Here, the bot explains how to indicate that a translation is ready for another review.

Your PR is still marked with "changes requested" under Labels on the top right of this page, which was done by the bot after my review.

Having that label, maintainers might believe that something is still to be done, and not have a look at a PR unless much time has passed.

Since you still might wish to make changes, when you have finished would you tell the bot you're done?

Please, only comment with "/done" here, without quotes or anything else.

Meanwhile, I am afraid I'll wait for that and the subsequent bot request for another review.

Thank you,
Osvaldo.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@danilolmc
danilolmc force-pushed the update-pt-mixins branch from 12ac6d5 to 787647e Compare March 16, 2023 01:48
@danilolmc

danilolmc commented Mar 16, 2023

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Mar 16, 2023
@javascript-translate-bot
javascript-translate-bot requested a review from a team March 16, 2023 01:49
odsantos
odsantos approved these changes Mar 16, 2023
View reviewed changes

@odsantos odsantos left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @danilolmc ,

We need that two maintainers review a translation for merging it.
So, we'll wait for a review by another maintainer.

Thank you,
Best wishes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Mar 16, 2023
jonnathan-ls
jonnathan-ls approved these changes Jul 16, 2023
View reviewed changes

@jonnathan-ls jonnathan-ls left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Mee

@danilolmc
Thank you for contribution

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jonnathan-ls
jonnathan-ls merged commit 0b207b5 into javascript-tutorial:master Jul 16, 2023
@javascript-translate-bot

javascript-translate-bot commented Jul 16, 2023

Copy link
Copy Markdown

Error: the article has another translator @DaniloLima122, not @danilolmc in the Progress Issue #1. Please update the progress issue or ask maintainers to do so.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jonnathan-ls jonnathan-ls removed the needs +1 label Jul 16, 2023
@jonnathan-ls

jonnathan-ls commented Jul 16, 2023

Copy link
Copy Markdown
Contributor

Error: the article has another translator @DaniloLima122, not @danilolmc in the Progress Issue #1. Please update the progress issue or ask maintainers to do so.

Updated

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@danilolmc

danilolmc commented Oct 28, 2023

Copy link
Copy Markdown
Contributor Author

Error: the article has another translator @DaniloLima122, not @danilolmc in the Progress Issue #1. Please update the progress issue or ask maintainers to do so.

Updated

I had changed my github username, but I had already finished the translation before it was merged.

jonnathan-ls reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@odsantos odsantos odsantos approved these changes
@jonnathan-ls jonnathan-ls jonnathan-ls approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@danilolmc @CLAassistant @odsantos @javascript-translate-bot @jonnathan-ls
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.