GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||
GeezerVison is showing github.com — Mixins by danilolmc · Pull Request #382 · javascript-tutorial/pt.javascript.info Conversation
|
There was an error while loading. Please reload this page.
|
Hi @DaniloLima122 , Appreciated your efforts. Would you please follow them? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hi @odsantos ! Thank you for the tips! Now I think the PR name is correct, according the name of the article! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hi @DaniloLima122 , it also is necessary to claim it in your name, according to the same instructions, thus you need to add a comment on that page with this title too. After that, if the bot does not reserve on your name and add this PR, a maintainer may do it manually. Thanks. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Hi @odsantos , thank you! It's done! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hi @DaniloLima122 , in the future please do not forget to claim first, then to give the PR the same name as on that page. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Hi @odsantos ! Great, I won't, thanks for your support! 😁 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Hi @danilolmc ,
Here is a review.
Please keep the translation line numbers matching the original (English) even if there is too little or too much space, and if you do not mind, also translate the text inside strings, but not variable names as you did.
Appreciate it if you tell me where you might disagree with this revision.
Thank you,
Osvaldo.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Please make the requested changes. After it, add a comment "/done". |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hi @danilolmc , Here, the bot explains how to indicate that a translation is ready for another review. Your PR is still marked with "changes requested" under Labels on the top right of this page, which was done by the bot after my review. Having that label, maintainers might believe that something is still to be done, and not have a look at a PR unless much time has passed. Since you still might wish to make changes, when you have finished would you tell the bot you're done? Please, only comment with "/done" here, without quotes or anything else. Meanwhile, I am afraid I'll wait for that and the subsequent bot request for another review. Thank you, |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
12ac6d5 to
787647e
Compare
|
/done |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Hi @danilolmc ,
We need that two maintainers review a translation for merging it.
So, we'll wait for a review by another maintainer.
Thank you,
Best wishes.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looks Good To Mee
@danilolmc
Thank you for contribution
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Error: the article has another translator @DaniloLima122, not @danilolmc in the Progress Issue #1. Please update the progress issue or ask maintainers to do so. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Updated |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I had changed my github username, but I had already finished the translation before it was merged. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.