GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||
GeezerVison is showing github.com — Debugging in the browser by zenobiopereira · Pull Request #399 · javascript-tutorial/pt.javascript.info Conversation
Contributor
Translated it the best I could, please let me know if there are some kind of convention that I've broken or some kind of phrasing that doesn't seems good. There's also the
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
Zenóbio seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@zenobiopereira , it seems you took a translated article and are proposing changes. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hey @odsantos , yeah, it seems like the topic already had been translated but at least for me, the text was using multiple terms in which seems like PT-PT, even though, I would be glad if you could review it as proposed changes and if that's not possible then I can jump to translate a different topic. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hi @zenobiopereira , yes I'll try to review it as soon as possible. Thanks. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Match original in English.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Hi @zenobiopereira ,
Here is a review.
Please don't hesitate to tell me where you disagree.
Thank you,
Osvaldo.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Hi @zenobiopereira ,
Here is a review.
Please don't hesitate to tell me where you disagree.
Thank you,
Osvaldo.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Please make the requested changes. After it, add a comment "/done". |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Hey @odsantos thank you for the review, I did applied most of your corrections since pretty much all of them added context and small needed corrections. I've also left small comments in two requested changes just because I think the text as it is, already delivers the same meaning, please let me know what do you think in relation to those. Thank you in advance. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
/done |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hi @zenobiopereira left a comment on the review point on discussion. Thanks. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@odsantos Thank you in advance. /done |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hi @zenobiopereira , will take a look as soon as possible. Thanks. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Embora, ainda considero que o artigo está em um linguajar muito formal, entendo que a necessidade deveria vir de outro momento para refletirmos em relação as colocações de escrita que este repositório em PT pode vir a adotar.
Sendo assim, considero a solicitação: LGTM ( Looks good to me )
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Looks Great To Me)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Please make the requested changes. After it, add a comment "/done". |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@jonnathan-ls, the language should be formal because programming is science. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
It also looks good to me to be approved.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.