GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Extending built-in classes by danilolmc · Pull Request #413 · javascript-tutorial/pt.javascript.info

Conversation

@danilolmc

@danilolmc danilolmc commented Jan 4, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
danilolmc added 2 commits January 2, 2024 20:31
@danilolmc
it updates built-in classes article
080dc0e
@danilolmc
fix: it fixes spelling mistakes
e493488
@javascript-translate-bot javascript-translate-bot added the review needed label Jan 4, 2024
@javascript-translate-bot
javascript-translate-bot requested a review from a team January 4, 2024 15:24
@javascript-translate-bot

javascript-translate-bot commented Jan 4, 2024

Copy link
Copy Markdown

Error: the article already has PR number in the Progress Issue #1, it's 411 ⁉️
danilolmc reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nazarepiedady
nazarepiedady reviewed Jan 7, 2024
View reviewed changes

@nazarepiedady nazarepiedady left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found two points to be reviewed, so I will pass to you @jonnathan-ls the responsibility of reviewing the rest.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/09-classes/05-extend-natives/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/09-classes/05-extend-natives/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@danilolmc
fix: it fixes grammar
f06d644
@danilolmc danilolmc mentioned this pull request Jan 8, 2024
Status review for unfinished articles #416
Closed
@danilolmc

danilolmc commented Jan 9, 2024

Copy link
Copy Markdown
Contributor Author

/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot
javascript-translate-bot requested a review from a team January 9, 2024 14:42
jonnathan-ls
jonnathan-ls approved these changes Jan 13, 2024
View reviewed changes

@jonnathan-ls jonnathan-ls left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me (LGTM)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Jan 13, 2024
@jonnathan-ls

jonnathan-ls commented Jan 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I just found two points to be reviewed, so I will pass to you @jonnathan-ls the responsibility of reviewing the rest.

Adicionei minha aprovação!

Por mais que ainda tenha solicitado alterações @nazarepiedady, acabou marcando a opção de review como comentário ... mas considerando que o @danilolmc já adicionou as alterações, entendo que a solicitação foi atendida, configurando como aprovada, então seguirei com o merge deste PR.

Quando adicionar uma revisão que tenha solicitações de mudança @nazarepiedady, procure marcar a opção:

Request changes
Submit feedback that must be addressed before merging.

Assim, o github registra as considerações e o BOT configurado do repositório consegue atuar, acho que foi por isso que ele acabou não atualizando o status deste PR, já que registrou como comentário em vez de request changes.

image

Obs.: Marcar como request changes e approved, mantém o vinculo de detalhes da aprovação associadas ao PR 01
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jonnathan-ls
jonnathan-ls merged commit d43daf7 into javascript-tutorial:master Jan 13, 2024
@javascript-translate-bot

javascript-translate-bot commented Jan 13, 2024

Copy link
Copy Markdown

Error: the article has another PR number in the Progress Issue #1, it's 411, not 413 ⁉️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jonnathan-ls jonnathan-ls mentioned this pull request Jan 13, 2024
Portuguese Translation Progress #1
Open
@jonnathan-ls

jonnathan-ls commented Jan 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Error: the article has another PR number in the Progress Issue 1, it's 411, not 413 ⁉️

Updated!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jonnathan-ls jonnathan-ls removed the needs +1 label Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nazarepiedady nazarepiedady nazarepiedady left review comments
@jonnathan-ls jonnathan-ls jonnathan-ls approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@danilolmc @javascript-translate-bot @jonnathan-ls @nazarepiedady
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.