GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Async iteration and generators by danilolmc · Pull Request #418 · javascript-tutorial/pt.javascript.info

Conversation

danilolmc commented Jan 8, 2024

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          it updates async iterators generatos article

b203819

javascript-translate-bot added the review needed label

Jan 8, 2024

javascript-translate-bot requested a review from a team

January 8, 2024 15:21

javascript-translate-bot mentioned this pull request

Jan 8, 2024

Portuguese Translation Progress #1

Open

nazarepiedady requested review from jonnathan-ls, murilloquality and odsantos

January 13, 2024 22:34

nazarepiedady requested changes

Feb 28, 2024

View reviewed changes

nazarepiedady left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danilolmc, could you update your pull request?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/12-generators-iterators/2-async-iterators-generators/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Feb 28, 2024

javascript-translate-bot commented Feb 28, 2024

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nazarepiedady commented Feb 28, 2024

Copy link

Copy Markdown

Member

@peruibeloko, could you do the honours?

peruibeloko reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

peruibeloko suggested changes

Feb 28, 2024

View reviewed changes

peruibeloko left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Além dos comentários que deixei, senti falta de conectores como artigos em diversos pontos, como "o await", "o - async", etc. mas não acho que sejam problemas grandes demais para prejudicar a compreensão do texto

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nazarepiedady reacted with thumbs up emoji

All reactions

👍 1 reaction

javascript-translate-bot commented Feb 28, 2024

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

danilolmc added 2 commits

March 4, 2024 17:44


          it fixes translation

5ea0f43


          it includes portuguese article for text improvement

632a99f

danilolmc commented Mar 4, 2024

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Mar 4, 2024

javascript-translate-bot requested a review from a team

March 4, 2024 21:06

peruibeloko approved these changes

Mar 6, 2024

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels

Mar 6, 2024

nazarepiedady approved these changes

Mar 6, 2024

View reviewed changes

nazarepiedady left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nazarepiedady merged commit 7c6f74b into javascript-tutorial:master

Mar 6, 2024

javascript-translate-bot commented Mar 6, 2024

Copy link

Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

nazarepiedady

nazarepiedady approved these changes

jonnathan-ls

Awaiting requested review from jonnathan-ls

murilloquality

Awaiting requested review from murilloquality

odsantos

Awaiting requested review from odsantos

+1 more reviewer

peruibeloko

peruibeloko approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.