GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — Quantifiers +, *, ? and {n} by peruibeloko · Pull Request #429 · javascript-tutorial/pt.javascript.info Conversation
peruibeloko
marked this pull request as ready for review
nazarepiedady
requested changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @peruibeloko, you did a great work here, so there is not so much things to be reviewed. I will let the rest on your hands and our colleagues.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
jonnathan-ls
approved these changes
|
I agree with @peruibeloko in relation to the translator ending up accepting the PR itself, although it is a documentation repository, if we consider the same premise as the code, whoever opened the PR may end up missing errors that they would not end up catching, hence the need to have reviewers for a look beyond the context (this corroborates the project's premise of having 02 reviewers, to avoid possible translation errors and ending up being taken to production when the translation is incorporated into the javascript.info website ' But I also consider @nazarepiedady's observation valid, unfortunately there are few contributors to this project and we need to release the translation. As it is a documentation repository and not a code repository, perhaps we can be a little more flexible, but if we are going to follow a path like this, I think it is worth creating a separate issue first to evaluate the opinion of other maintainers, at the same time time to ensure that we do not violate the premise adopted by the project owner (repository in English). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@peruibeloko, @jonnathan-ls, unfortunately this project do not have so many active maintainers so if we depend on the maintainers that are not so active we can not go ahead. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@nazarepiedady I think your approval is the only one remaining |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.