GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Quantifiers +, *, ? and {n} by peruibeloko · Pull Request #429 · javascript-tutorial/pt.javascript.info

Conversation

@peruibeloko

@peruibeloko peruibeloko commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@peruibeloko
start translation
36c44c6
@javascript-translate-bot javascript-translate-bot added the review needed label Feb 6, 2024
@javascript-translate-bot
javascript-translate-bot requested a review from a team February 6, 2024 14:30
@javascript-translate-bot javascript-translate-bot mentioned this pull request Feb 6, 2024
Portuguese Translation Progress #1
Open
@peruibeloko
finish translation
8d77eb0
@peruibeloko
peruibeloko marked this pull request as ready for review February 6, 2024 18:14
nazarepiedady
nazarepiedady requested changes Feb 6, 2024
View reviewed changes

@nazarepiedady nazarepiedady left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peruibeloko, you did a great work here, so there is not so much things to be reviewed.

I will let the rest on your hands and our colleagues.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 9-regular-expressions/09-regexp-quantifiers/2-find-html-colors-6hex/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/09-regexp-quantifiers/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 9-regular-expressions/09-regexp-quantifiers/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Feb 6, 2024
@javascript-translate-bot

javascript-translate-bot commented Feb 6, 2024

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nazarepiedady
nazarepiedady requested review from a team, jonnathan-ls and odsantos February 6, 2024 20:31
@peruibeloko
fix: minor spelling changes
f2dd836
@nazarepiedady

nazarepiedady commented Mar 8, 2024

Copy link
Copy Markdown
Member

@jonnathan-ls, could you review it?

jonnathan-ls reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nazarepiedady

nazarepiedady commented Mar 8, 2024

Copy link
Copy Markdown
Member

@peruibeloko, I think you could also look at your own pull request and approve it if you agree with what you did. This would help a lot when we don't have enough people online to look at it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@peruibeloko

peruibeloko commented Mar 8, 2024

Copy link
Copy Markdown
Contributor Author

@nazarepiedady that would be a conflict of interests, wouldn't it? the idea of reviews is to catch errors

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nazarepiedady

nazarepiedady commented Mar 8, 2024

Copy link
Copy Markdown
Member

@peruibeloko, yes, but you are also a reviewer even not being a maintainer. I also think that you have a good point.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@peruibeloko

peruibeloko commented Mar 23, 2024

Copy link
Copy Markdown
Contributor Author

/done

nazarepiedady reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Mar 23, 2024
@nazarepiedady

nazarepiedady commented Mar 24, 2024

Copy link
Copy Markdown
Member

@peruibeloko, excellent, now we can go forward.
@odsantos, and @jonnathan-ls, could you review it quickly as possible?

We need to merge all current opened pull request to do a good review on the issues and to organise the things to start to add new translations.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jonnathan-ls
jonnathan-ls approved these changes Mar 30, 2024
View reviewed changes

@jonnathan-ls jonnathan-ls left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️ I added my approval

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nazarepiedady reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Mar 30, 2024
@jonnathan-ls

jonnathan-ls commented Mar 30, 2024

Copy link
Copy Markdown
Contributor

that would be a conflict of interests, wouldn't it? the idea of reviews is to catch errors

I agree with @peruibeloko in relation to the translator ending up accepting the PR itself, although it is a documentation repository, if we consider the same premise as the code, whoever opened the PR may end up missing errors that they would not end up catching, hence the need to have reviewers for a look beyond the context (this corroborates the project's premise of having 02 reviewers, to avoid possible translation errors and ending up being taken to production when the translation is incorporated into the javascript.info website '

But I also consider @nazarepiedady's observation valid, unfortunately there are few contributors to this project and we need to release the translation. As it is a documentation repository and not a code repository, perhaps we can be a little more flexible, but if we are going to follow a path like this, I think it is worth creating a separate issue first to evaluate the opinion of other maintainers, at the same time time to ensure that we do not violate the premise adopted by the project owner (repository in English).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nazarepiedady

nazarepiedady commented Mar 31, 2024

Copy link
Copy Markdown
Member

@peruibeloko, @jonnathan-ls, unfortunately this project do not have so many active maintainers so if we depend on the maintainers that are not so active we can not go ahead.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@peruibeloko

peruibeloko commented Apr 2, 2024

Copy link
Copy Markdown
Contributor Author

@nazarepiedady I think your approval is the only one remaining

jonnathan-ls reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nazarepiedady
nazarepiedady approved these changes Apr 2, 2024
View reviewed changes
@nazarepiedady
nazarepiedady merged commit b4ee5de into javascript-tutorial:master Apr 2, 2024
@javascript-translate-bot

javascript-translate-bot commented Apr 2, 2024

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@peruibeloko
peruibeloko deleted the 09/09 branch April 3, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonnathan-ls jonnathan-ls jonnathan-ls approved these changes
@nazarepiedady nazarepiedady nazarepiedady approved these changes
@odsantos odsantos Awaiting requested review from odsantos

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@peruibeloko @javascript-translate-bot @nazarepiedady @jonnathan-ls
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.