GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — BigInt by danilolmc · Pull Request #430 · javascript-tutorial/pt.javascript.info

Conversation

@danilolmc

@danilolmc danilolmc commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@danilolmc
it updates bigint article
38e228e
@javascript-translate-bot javascript-translate-bot added the review needed label Feb 6, 2024
@javascript-translate-bot
javascript-translate-bot requested a review from a team February 6, 2024 20:23
@javascript-translate-bot javascript-translate-bot mentioned this pull request Feb 6, 2024
Portuguese Translation Progress #1
Open
nazarepiedady
nazarepiedady reviewed Feb 6, 2024
View reviewed changes

@nazarepiedady nazarepiedady left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danilolmc, what do you think about consider the idea about translating the word bigint in the article content as número inteiro grande or inteiro grande or inteiro maior?

@peruibeloko, @jonnathan-ls, @odsantos, what do you think about the suggestion I did?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nazarepiedady
nazarepiedady requested review from a team, jonnathan-ls and odsantos February 6, 2024 20:37
@peruibeloko

peruibeloko commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

@nazarepiedady I'd keep it as BigInt, and the only change I'd suggest is to capitalize it, since we're dealing with the actual object's name, much like we shouldn't translate Promise to Promessa for example :)

nazarepiedady and jonnathan-ls reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@danilolmc

danilolmc commented Feb 6, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I agree with @peruibeloko, since BigInt is just like Promise and the data type name itself.

@peruibeloko do you mean capitalize every bigint word in the article? I just let some bigint words as it was already capitalized.

nazarepiedady and jonnathan-ls reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@peruibeloko

peruibeloko commented Feb 6, 2024

Copy link
Copy Markdown
Contributor

@danilolmc Yes, that would be the case. Just a suggestion, of course.

nazarepiedady reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@danilolmc

danilolmc commented Feb 6, 2024

Copy link
Copy Markdown
Contributor Author

Ok, no problem, I'm going to capitalize them!

nazarepiedady reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nazarepiedady

nazarepiedady commented Feb 7, 2024

Copy link
Copy Markdown
Member

@nazarepiedady I'd keep it as BigInt, and the only change I'd suggest is to capitalize it, since we're dealing with the actual object's name, much like we shouldn't translate Promise to Promessa for example :)

@peruibeloko, I was talking about to translate the usage of the word bigint where it is not reference the data type.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@peruibeloko

peruibeloko commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

@nazarepiedady the problem is that bigint always refers to the data type

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

peruibeloko
peruibeloko suggested changes Feb 7, 2024
View reviewed changes

@peruibeloko peruibeloko left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danilolmc Solicitei algumas mudanças, deve ser rápido

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread 1-js/99-js-misc/05-bigint/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/05-bigint/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/05-bigint/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/05-bigint/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/05-bigint/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/05-bigint/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/05-bigint/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/99-js-misc/05-bigint/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Feb 7, 2024
@javascript-translate-bot

javascript-translate-bot commented Feb 7, 2024

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Feb 7, 2024
danilolmc added 2 commits February 7, 2024 11:57
@danilolmc
it improves grammar
e6157c8
@danilolmc
it fixes bigint article reference to MDN
eff18a0
@danilolmc

danilolmc commented Feb 7, 2024

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Feb 7, 2024
peruibeloko
peruibeloko approved these changes Feb 7, 2024
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Feb 7, 2024
@odsantos

odsantos commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

I agree with @peruibeloko, since BigInt is just like Promise and the data type name itself.

@peruibeloko do you mean capitalize every bigint word in the article? I just let some bigint words as it was already capitalized.

Seems good, as the Portuguese 'mdn' link, and other accepted suggestions here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nazarepiedady
nazarepiedady approved these changes Feb 11, 2024
View reviewed changes
@nazarepiedady
nazarepiedady merged commit 837287f into javascript-tutorial:master Feb 11, 2024
@javascript-translate-bot

javascript-translate-bot commented Feb 11, 2024

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

jonnathan-ls reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nazarepiedady nazarepiedady nazarepiedady approved these changes
@odsantos odsantos Awaiting requested review from odsantos
@jonnathan-ls jonnathan-ls Awaiting requested review from jonnathan-ls
+1 more reviewer
@peruibeloko peruibeloko peruibeloko approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@danilolmc @peruibeloko @nazarepiedady @javascript-translate-bot @odsantos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.