GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Loops: while and for by alvar-o · Pull Request #50 · javascript-tutorial/pt.javascript.info

Conversation

alvar-o commented Sep 4, 2019

Copy link

Copy Markdown

This is my first pull request. Comments appreciated!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Álvaro Antonio added 3 commits

September 4, 2019 17:10


          Translate while-for loops

e4765a4


          deleting

f313154


          Translate while-for loops

b17dba1

javascript-translate-bot added the review needed label

Sep 4, 2019

javascript-translate-bot requested a review from a team

September 4, 2019 20:29

iliakan mentioned this pull request

Sep 4, 2019

Portuguese Translation Progress #1

Open

CLAassistant commented Sep 4, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Álvaro Antonio seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

alvar-o commented Sep 4, 2019

Copy link

Copy Markdown

Author

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Álvaro Antonio seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Hey, I followed instructions to set my email address in Git and signed the CLA. Do I have to submit a new PR to make it work?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

alvar-o closed this

Sep 4, 2019

Mr-Saxobeat reviewed

Nov 4, 2019

View reviewed changes

Mr-Saxobeat left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your translation is very good, there is just some little terms that I think could be correct.
I can't finish now. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/12-while-for/3-which-value-for/solution.md

		3. If `true` -- execute the loop body `alert(i)`, and then `i++`
		1. Executar `i = 0` uma vez antes de tudo (begin).
		2. Verificar a condição `i < 5`.
		3. Caso verdadeira (`true`), executar o corpo do loop `alert(i)`, e em seguida `i++`.

Mr-Saxobeat Nov 4, 2019

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write the verbs on simple present:

Executa
Verifica
executa

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/12-while-for/6-repeat-until-correct/task.md

		# Repetir até que o input esteja correto

		Write a loop which prompts for a number greater than `100`. If the visitor enters another number -- ask them to input again.
		Escreva um loop que peça um número maior que `100`. Se o usuário digitar outro número, peça para digite digitar novamente.

Mr-Saxobeat Nov 4, 2019

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"... peça para que digite ~~digitar~~ novamente."

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/12-while-for/7-list-primes/solution.md

		Há muitos algotimos para esta tarefa.

		Let's use a nested loop:
		Vamos utilizar um loop dentro de outro (isto é, aninhado):

Mr-Saxobeat Nov 4, 2019

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add the "nested loop" term here, inside parenthesis.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/12-while-for/7-list-primes/solution.md

		if yes => the value is not a prime
		if no => the value is a prime, show it
		Para cada i no intervalo {
		testar se i tem um divisor de 1 a i

Mr-Saxobeat Nov 4, 2019

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"testar" in simple present form.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

jonnathan-ls commented Oct 14, 2022

Copy link

Copy Markdown

Contributor

@alvar-o

Are you still available to proceed with the translation?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

peruibeloko mentioned this pull request

Jan 7, 2024

Status review for unfinished articles #416

Closed

Reviewers

1 more reviewer

Mr-Saxobeat

Mr-Saxobeat left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

alvar-o commented Sep 4, 2019

Uh oh!

CLAassistant commented Sep 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alvar-o commented Sep 4, 2019

Uh oh!

Mr-Saxobeat left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mr-Saxobeat Nov 4, 2019

Choose a reason for hiding this comment

Uh oh!

Mr-Saxobeat Nov 4, 2019

Choose a reason for hiding this comment

Uh oh!

Mr-Saxobeat Nov 4, 2019

Choose a reason for hiding this comment

Uh oh!

Mr-Saxobeat Nov 4, 2019

Choose a reason for hiding this comment

Uh oh!

jonnathan-ls commented Oct 14, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Sep 4, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Mr-Saxobeat left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.