GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Interaction: alert, prompt, confirm by andreimuntean1 · Pull Request #170 · javascript-tutorial/ro.javascript.info

Conversation

@andreimuntean1

@andreimuntean1 andreimuntean1 commented Jan 23, 2023

Copy link
Copy Markdown

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
andreimuntean1 added 3 commits January 23, 2023 13:57
@andreimuntean1
Translated article.md
9da651d
@andreimuntean1
Translated solution.md
1afb63a
@andreimuntean1
Translated task.md
a70f72a
@javascript-translate-bot javascript-translate-bot added the review needed label Jan 23, 2023
@javascript-translate-bot
javascript-translate-bot requested a review from a team January 23, 2023 12:22
@javascript-translate-bot javascript-translate-bot mentioned this pull request Jan 23, 2023
Romanian Translation Progress #1
Open
@CLAassistant

CLAassistant commented Jan 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
andreimuntean1 added 2 commits January 23, 2023 16:56
@andreimuntean1
Translate article.md
d8f4e09
@andreimuntean1
Translated tasks
4a59e05
bogdanbacosca
bogdanbacosca requested changes Jan 23, 2023
View reviewed changes

@bogdanbacosca bogdanbacosca left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Te rog să dai revert la 13-while-for, cum ai făcut la celălalt PR.
Trebuie să avem doar 1 PR pentru fiecare articol.
Am lăsat 2 comentarii în cod.
Pe scurt: trebuie ca formatul markdown să fie identic cu cel original, iar numele variabilelor să rămână netraduse.
Te rog să faci schimbările astea mai intâi prin tot codul.
Dacă ai mai multe nelămuriri, citește fișierul README.md din repo sau trimite-mi un mail.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/02-first-steps/06-alert-prompt-confirm/1-simple-page/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/02-first-steps/06-alert-prompt-confirm/1-simple-page/solution.md
let name = prompt("What is your name?", "");
alert(name);
```js
let nume = prompt("Cum te numești?", "");

@bogdanbacosca bogdanbacosca Jan 23, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let nume = prompt("Cum te numești?", "");
let name = prompt("Cum te numești?", "");

numele variabilelor nu se traduc.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Jan 23, 2023
@javascript-translate-bot

javascript-translate-bot commented Jan 23, 2023

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andreimuntean1 andreimuntean1 closed this Jan 23, 2023
@andreimuntean1 andreimuntean1 reopened this Jan 23, 2023
@andreimuntean1 andreimuntean1 closed this Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogdanbacosca bogdanbacosca bogdanbacosca requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@andreimuntean1 @CLAassistant @javascript-translate-bot @bogdanbacosca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.