GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Class basic syntax by Benyaak · Pull Request #40 · javascript-tutorial/ro.javascript.info

Conversation

@Benyaak

@Benyaak Benyaak commented Dec 11, 2019

Copy link
Copy Markdown

Finished the class basic syntax lesson, I hope everything is okay. Waiting for a review/translation suggestions. Thanks a lot.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@danandreighinea
Class basic syntax
2503b6a
@javascript-translate-bot javascript-translate-bot added the review needed label Dec 11, 2019
@javascript-translate-bot
javascript-translate-bot requested a review from a team December 11, 2019 15:28
@iliakan iliakan mentioned this pull request Dec 11, 2019
Romanian Translation Progress #1
Open
lighthousand
lighthousand reviewed Dec 12, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/1-rewrite-to-class/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@danandreighinea
Updated missing translation
d75fef4
lighthousand
lighthousand reviewed Dec 12, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 12, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@danandreighinea
Added missing translation & typo
83304a1
lighthousand
lighthousand reviewed Dec 12, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 12, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@danandreighinea
Grammar Suggestion implemented
4f70ab1
@Benyaak

Benyaak commented Dec 16, 2019

Copy link
Copy Markdown
Author

Solved all suggestion /done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot
javascript-translate-bot requested a review from a team December 16, 2019 08:55
lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@lighthousand

lighthousand commented Dec 23, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@Benyaak, you're not a romanian native speaker, am i right ? :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand reviewed Dec 23, 2019
View reviewed changes
Comment thread 1-js/09-classes/01-class/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lighthousand
lighthousand previously requested changes Dec 23, 2019
View reviewed changes

@lighthousand lighthousand left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, good job !

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@javascript-translate-bot javascript-translate-bot added changes requested and removed review needed labels Dec 23, 2019
@javascript-translate-bot

javascript-translate-bot commented Dec 23, 2019

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CLAassistant

CLAassistant commented Mar 8, 2020

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bogdanbacosca
bogdanbacosca approved these changes Nov 26, 2022
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed changes requested labels Nov 26, 2022
@bogdanbacosca
bogdanbacosca dismissed lighthousand’s stale review November 27, 2022 00:41

outdated

bogdanbacosca
bogdanbacosca approved these changes Nov 27, 2022
View reviewed changes
@iliakan

iliakan commented Nov 27, 2022

Copy link
Copy Markdown
Member

You can't merge because of conflicts. Can you fix the conflicts (know what it is?)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bogdanbacosca

bogdanbacosca commented Nov 27, 2022

Copy link
Copy Markdown
Contributor

Yep but GitHub wouldn't let me edit the files. I think this person unticked the "let maintainers edit code" box

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iliakan

iliakan commented Nov 27, 2022

Copy link
Copy Markdown
Member

Maybe check it out locally, merge/edit and then close this PR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bogdanbacosca

bogdanbacosca commented Nov 27, 2022

Copy link
Copy Markdown
Contributor

I think he may have deleted his branch - checkout to Benyaak:master just creates a brand new branch. Also I cannot see his pull request in the GitHub desktop app, the other one shows up but not his.

Not sure exactly, I can copy/paste his code and modify it in a new branch because it seems like there are not so many mistakes, but not sure if it's "legal" or fair to do that. Translating one article is not that much work from my experience so far and I wouldn't mind to let go of it also.

Is there another way?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iliakan

iliakan commented Nov 27, 2022

Copy link
Copy Markdown
Member
 git fetch -fu origin refs/pull/40/head:pr/40
 git checkout pr/40
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bogdanbacosca

bogdanbacosca commented Nov 27, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
me@os:~/Documents/GitHub/ro.javascript.info$ git fetch -fu origin refs/pull/40/head:pr/40
fatal: couldn't find remote ref refs/pull/40/head
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iliakan

iliakan commented Nov 27, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

From this repo:

➜  ro.javascript.info git:(master) git fetch -fu origin refs/pull/40/head:pr/40
remote: Enumerating objects: 27, done.
remote: Counting objects: 100% (11/11), done.
remote: Total 27 (delta 11), reused 11 (delta 11), pack-reused 16
Unpacking objects: 100% (27/27), 6.31 KiB | 646.00 KiB/s, done.
From github.com:javascript-tutorial/ro.javascript.info
 * [new ref]           refs/pull/40/head -> pr/40
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iliakan

iliakan commented Nov 27, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I made a new branch tmp-40 with this PR and pushed it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iliakan iliakan closed this Nov 27, 2022
@iliakan

iliakan commented Nov 27, 2022

Copy link
Copy Markdown
Member

See this PR #146

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bogdanbacosca

bogdanbacosca commented Nov 27, 2022

Copy link
Copy Markdown
Contributor

thanks a lot 🙏️

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bogdanbacosca bogdanbacosca bogdanbacosca approved these changes
@lighthousand lighthousand lighthousand left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Benyaak @lighthousand @javascript-translate-bot @CLAassistant @iliakan @bogdanbacosca @danandreighinea
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.