GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Symbol type by armino-dev · Pull Request #44 · javascript-tutorial/ro.javascript.info

Conversation

@armino-dev

@armino-dev armino-dev commented Dec 24, 2019

Copy link
Copy Markdown
Contributor

I think that's it for this year :).
Happy holidays everyone!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
armino-dev added 2 commits December 24, 2019 13:46
@armino-dev
First attempt
d11fb74
@armino-dev
Some typos corrected
5dd4807
@javascript-translate-bot javascript-translate-bot added the review needed label Dec 24, 2019
@javascript-translate-bot
javascript-translate-bot requested a review from a team December 24, 2019 12:23
@iliakan iliakan mentioned this pull request Dec 24, 2019
Romanian Translation Progress #1
Open
@lighthousand

lighthousand commented Dec 27, 2019

Copy link
Copy Markdown
Member

Happy holidays to you, too ! 🍾 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@armino-dev
Corrected Typo : 'următoare' -> 'următoarea'
4eb75e5
lighthousand
lighthousand requested changes Jan 21, 2020
View reviewed changes
Comment thread 1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/03-symbol/article.md Outdated
Cele mai multe valori în JavaScript suportă conversie implicită la un șir. De exemplu, putem `alert`-a aproape orice valoare și va funcționa. Simbolurile sunt speciale. Ele nu se auto-convertesc.

For instance, this `alert` will show an error:
De exemplu, următoare instrucțiune `alert` va genera o eroare:

@lighthousand lighthousand Jan 6, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo : 'următoare' -> 'următoarea'

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@armino-dev armino-dev Jan 21, 2020

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was already made with commit 4eb75e5.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread 1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread 1-js/04-object-basics/03-symbol/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot removed the review needed label Jan 21, 2020
@javascript-translate-bot

javascript-translate-bot commented Jan 21, 2020

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added the changes requested label Jan 21, 2020
@armino-dev
Fixed grammar typos
9a40388
@armino-dev

armino-dev commented Jan 21, 2020

Copy link
Copy Markdown
Contributor Author

/done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Jan 21, 2020
@javascript-translate-bot
javascript-translate-bot requested a review from a team January 21, 2020 14:57
lighthousand
lighthousand approved these changes Jan 23, 2020
View reviewed changes

@lighthousand lighthousand left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Jan 23, 2020
@lighthousand
lighthousand merged commit fd1becf into javascript-tutorial:master Jan 23, 2020
@javascript-translate-bot

javascript-translate-bot commented Jan 23, 2020

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lighthousand lighthousand lighthousand approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@armino-dev @lighthousand @javascript-translate-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.