GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — The "switch" statement by bmatasar · Pull Request #9 · javascript-tutorial/ro.javascript.info

Conversation

bmatasar commented Jun 4, 2019

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bmatasar added 6 commits

June 4, 2019 15:16


          Translated

d3bea6b


          Update task.md

59c6193


          Update solution.md

3b3b39a


          Update task.md

6a6904a


          Update solution.md

69f821e


          Update article.md

60b4d9f

javascript-translate-bot added the review needed label

Jun 4, 2019

javascript-translate-bot requested a review from a team

June 4, 2019 12:39

lighthousand requested changes

Jun 4, 2019

View reviewed changes

Comment thread

1-js/02-first-steps/13-switch/article.md Outdated


		!
		case 3: // (*) grouped two cases
		case 3: // (*) douș cazuri grupate

lighthousand Jun 4, 2019

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo : "douș"
Possible fix : "două"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/13-switch/article.md Outdated

		Acum atât `3` cât și `5` arată același mesaj.

		The ability to "group" cases is a side-effect of how `switch/case` works without `break`. Here the execution of `case 3` starts from the line `(*)` and goes through `case 5`, because there's no `break`.
		Posibilitatea de a ȚgrupaȚ cazuri este un efect secundar al modului în care funcționează `switch/case` fără `break`. Execuția blocului `case 3` începe de la linia marcată `(*)` și continuă în `case 5`, pentru că nu există niciun `break`.

lighthousand Jun 4, 2019

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo : "...de a ȚgrupaȚ..."

Possible fix : '...de a"grupa"...'

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/13-switch/1-rewrite-switch-if-else/solution.md Outdated

		@@ -1,20 +1,20 @@
		To precisely match the functionality of `switch`, the `if` must use a strict comparison `'==='`.
		Pentru a obține exact funcționalitatea instrucțiunii `switch`, `if` trebuie să folosească operatorul de egalitate exactă `'==='`.

lighthousand Jun 4, 2019

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical typo : "...egalitate exactă"

Possible fix : "...egalitate strictă"

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/02-first-steps/13-switch/2-rewrite-if-switch/solution.md Outdated

		Observație: instrucțiunea `break` de la sfârșit nu este necesară, dar putem să o adăugăm pentru a pregăti codul pentru viitor.

		In the future, there is a chance that we'd want to add one more `case`, for example `case 4`. And if we forget to add a break before it, at the end of `case 3`, there will be an error. So that's a kind of self-insurance.
		În viitor este posibil că vom dori să mai adăugăm încă un `case`, de exemplu `case 4`. Dacă uităm să adăugăm un `break` înaintea lui, la sfârșitul blocului `case 3`, vom obține o eroare. Deci avem un fel de auto-asigurare.

lighthousand Jun 4, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional suggestion for grammar :

if can be done transform this : "...este posibil că vom dori...."

into this : "...este posibil să dorim...."
"...este posibil să vrem...."

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

javascript-translate-bot added changes requested and removed review needed labels

Jun 4, 2019

javascript-translate-bot commented Jun 4, 2019

Copy link

Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bmatasar added 3 commits

June 4, 2019 16:24


          Update article.md

befc1da


          Update solution.md

d9fb0fa


          Update solution.md

2c6a43a

bmatasar commented Jun 4, 2019

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Jun 4, 2019

javascript-translate-bot requested a review from a team

June 4, 2019 13:27

lighthousand merged commit ef04b82 into javascript-tutorial:master

Jun 4, 2019

iliakan mentioned this pull request

Jun 4, 2019

Romanian Translation Progress #1

Open

Reviewers

lighthousand

lighthousand requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

review needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

bmatasar commented Jun 4, 2019

Uh oh!

lighthousand Jun 4, 2019

Choose a reason for hiding this comment

Uh oh!

lighthousand Jun 4, 2019

Choose a reason for hiding this comment

Uh oh!

lighthousand Jun 4, 2019

Choose a reason for hiding this comment

Uh oh!

lighthousand Jun 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

javascript-translate-bot commented Jun 4, 2019

Uh oh!

bmatasar commented Jun 4, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lighthousand Jun 4, 2019 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.