GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Добавляет 2 задания by dobernike · Pull Request #448 · javascript-tutorial/ru.javascript.info

Conversation

@dobernike

@dobernike dobernike commented Aug 12, 2019

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@dobernike
Добавляет задание WAT
9cdcc19
@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Aug 12, 2019
@javascript-translate-bot
javascript-translate-bot requested a review from a team August 12, 2019 07:31
@dobernike
Добавляет 3-ю задачу
5e40bd8
@dobernike dobernike changed the title Добавляет задание WAT Добавляет 2 задания Aug 15, 2019
@dobernike dobernike mentioned this pull request Aug 16, 2019
Добавление задач #321
Closed
@iliakan

iliakan commented Aug 17, 2019

Copy link
Copy Markdown
Member
  1. Далеко не все знают, что такое WAT.
  2. Желательно, чтобы задачи были близки к жизни.
  3. Уже есть подобная задача с тестами. Можно добавить что-то в неё, если полезно.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iliakan iliakan assigned dobernike Aug 17, 2019
xcurveballx
xcurveballx requested changes Aug 17, 2019
View reviewed changes
Comment thread 1-js/02-first-steps/06-type-conversions/2-WAT/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/06-type-conversions/2-WAT/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/06-type-conversions/2-WAT/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/06-type-conversions/3-primitive-conversions-quizes/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/06-type-conversions/3-primitive-conversions-quizes/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/06-type-conversions/3-primitive-conversions-quizes/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/06-type-conversions/3-primitive-conversions-quizes/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/06-type-conversions/3-primitive-conversions-quizes/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/06-type-conversions/3-primitive-conversions-quizes/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/02-first-steps/06-type-conversions/3-primitive-conversions-quizes/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Aug 17, 2019
@javascript-translate-bot

javascript-translate-bot commented Aug 17, 2019

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dobernike added 4 commits August 18, 2019 10:01
@dobernike
Update task.md
2886880
@dobernike
Update solution.md
27d8a49
@dobernike
Update solution.md
f39977a
@dobernike
Update task.md
043d1dd
@dobernike

dobernike commented Aug 18, 2019

Copy link
Copy Markdown
Contributor Author

@iliakan

Далеко не все знают, что такое WAT.

Могу переименовать, если необходимо. Те кто не знают, не обратят внимание на название, а остальные вспомнят доклад.

Желательно, чтобы задачи были близки к жизни.

На собеседованиях до сих пор спрашивают про такие преобразования => это актуально.

Уже есть подобная задача с тестами. Можно добавить что-то в неё, если полезно.
Могу дополнить все в 1 задачу, но тогда не будет рассмотрения примеров доклада и картинки с "WTF JS"

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dobernike

dobernike commented Aug 18, 2019

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Aug 18, 2019
@javascript-translate-bot
javascript-translate-bot requested a review from a team August 18, 2019 07:14
@iliakan

iliakan commented Aug 20, 2019

Copy link
Copy Markdown
Member

Долго думал - пожалуй, это не то, что надо =(

Первая задача явно скорее quiz, чем задача - может быть, в quiz стоит.
Вторая primitive-conversions-quizes не проверяет ничего нового по сравнению с существующей.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iliakan iliakan closed this Aug 20, 2019
@dobernike

dobernike commented Aug 21, 2019

Copy link
Copy Markdown
Contributor Author

@iliakan Может первую добавить в https://github.com/javascript-tutorial/ru.javascript.info/blob/master/1-js/02-first-steps/06-type-conversions/1-primitive-conversions-questions/task.md ? не нашел где в quiz можно добавить.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xcurveballx xcurveballx xcurveballx requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@dobernike dobernike

Labels

review needed Review needed, please approve or request changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@dobernike @iliakan @javascript-translate-bot @xcurveballx
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.