GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — WeakMap and WeakSet by MykolaSopiha · Pull Request #162 · javascript-tutorial/uk.javascript.info

Conversation

MykolaSopiha commented Jul 28, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

Під час перекладу помітив, що інколи назви методів перелічуються в тексті з дужками, а іноді ні. Навіть в одному і тому ж реченні. Можливо це слід обговорити та прийти до єдиного стандарту. Поки що перекладав згідно з оригіналом:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          weakmap-weakset

cb04679

javascript-translate-bot added the review needed label

Jul 28, 2021

javascript-translate-bot mentioned this pull request

Jul 28, 2021

Ukrainian Translation Progress #1

Open


          weakmap-weakset

d05e96c

tarasyyyk reviewed

Jul 29, 2021

View reviewed changes

Comment thread

1-js/05-data-types/08-weakmap-weakset/01-recipients-read/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

tarasyyyk reviewed

Jul 29, 2021

View reviewed changes

Comment thread

1-js/05-data-types/08-weakmap-weakset/01-recipients-read/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

tarasyyyk added 2 commits

July 29, 2021 20:18


          Update 1-js/05-data-types/08-weakmap-weakset/01-recipients-read/solut…

de875f0

…ion.md


          Update 1-js/05-data-types/08-weakmap-weakset/01-recipients-read/solut…

53ba2d7

…ion.md

tarasyyyk reviewed

Jul 29, 2021

View reviewed changes

Comment thread

1-js/05-data-types/08-weakmap-weakset/01-recipients-read/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

tarasyyyk reviewed

Jul 29, 2021

View reviewed changes

Comment thread

1-js/05-data-types/08-weakmap-weakset/01-recipients-read/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

tarasyyyk added 2 commits

July 29, 2021 20:21


          Update 1-js/05-data-types/08-weakmap-weakset/01-recipients-read/task.md


          Update 1-js/05-data-types/08-weakmap-weakset/01-recipients-read/task.md

dba6c68

tarasyyyk reviewed

Jul 29, 2021

View reviewed changes

Comment thread

1-js/05-data-types/08-weakmap-weakset/02-recipients-when-read/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

tarasyyyk reviewed

Jul 29, 2021

View reviewed changes

Comment thread

1-js/05-data-types/08-weakmap-weakset/02-recipients-when-read/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

tarasyyyk added 2 commits

July 29, 2021 20:23


          Update 1-js/05-data-types/08-weakmap-weakset/02-recipients-when-read/…

559276e

…task.md


          Update 1-js/05-data-types/08-weakmap-weakset/02-recipients-when-read/…

…task.md

tarasyyyk requested changes

Jul 29, 2021

View reviewed changes

tarasyyyk left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дуже добре. Є декілька невеличких правок. Я вже додав пропозиції, тож залишилося лише їх закомітити. На рахунок назв методів. Про це не переймайтеся – пізніше в англійському варіанті їх заберуть і я оновлю переклад.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

1-js/05-data-types/08-weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/08-weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/08-weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/08-weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/08-weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/08-weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

1-js/05-data-types/08-weakmap-weakset/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot removed the review needed label

Jul 29, 2021

javascript-translate-bot commented Jul 29, 2021

Copy link

Copy Markdown

Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added the changes requested label

Jul 29, 2021

MykolaSopiha and others added 9 commits

July 29, 2021 22:59


          weakmap-weakset

eb1c521


          Update 1-js/05-data-types/08-weakmap-weakset/article.md

11577f6

Co-authored-by: Taras <[email protected]>


          Update 1-js/05-data-types/08-weakmap-weakset/article.md

fb97f49

Co-authored-by: Taras <[email protected]>


          Update 1-js/05-data-types/08-weakmap-weakset/article.md

2d442b9

Co-authored-by: Taras <[email protected]>


          Update 1-js/05-data-types/08-weakmap-weakset/article.md

b57764a

Co-authored-by: Taras <[email protected]>


          Update 1-js/05-data-types/08-weakmap-weakset/article.md

419af44

Co-authored-by: Taras <[email protected]>


          Update 1-js/05-data-types/08-weakmap-weakset/article.md

8dac342

Co-authored-by: Taras <[email protected]>


          Update 1-js/05-data-types/08-weakmap-weakset/article.md

f5eb970

Co-authored-by: Taras <[email protected]>


          Merge branch 'weakmap-weakset' of github.com:MykolaSopiha/uk.javascri…

44c5f94

…pt.info into weakmap-weakset

MykolaSopiha commented Jul 29, 2021

Copy link

Copy Markdown

Collaborator Author

@tarasyyyk дякую за правки! Я їх закомітив + додав ще пару невеликих фіксів. Сподіваюсь тепер все ок)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MykolaSopiha commented Aug 1, 2021

Copy link

Copy Markdown

Collaborator Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Aug 1, 2021

tarasyyyk commented Aug 3, 2021

Copy link

Copy Markdown

Collaborator

@MykolaSopiha чудово! Вибачте за затримку. Зараз в мене обмаль часу на перевірки.
Переклад підтверджую.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tarasyyyk approved these changes

Aug 3, 2021

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels

Aug 3, 2021

tarasyyyk merged commit 89ee8e9 into javascript-tutorial:master

Aug 3, 2021

javascript-translate-bot commented Aug 3, 2021

Copy link

Copy Markdown

Contributor

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

tarasyyyk

tarasyyyk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

MykolaSopiha commented Jul 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tarasyyyk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Jul 29, 2021

Uh oh!

MykolaSopiha commented Jul 29, 2021

Uh oh!

MykolaSopiha commented Aug 1, 2021

Uh oh!

tarasyyyk commented Aug 3, 2021

Uh oh!

javascript-translate-bot commented Aug 3, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MykolaSopiha commented Jul 28, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.