GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Error handling with promises by AntonBurchak · Pull Request #231 · javascript-tutorial/uk.javascript.info

Conversation

@AntonBurchak

@AntonBurchak AntonBurchak commented Dec 10, 2021

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Anton_Burchak Anton_Burchak
Finished "Error handling with promises" article translations
246c815
@javascript-translate-bot javascript-translate-bot added the review needed label Dec 10, 2021
@CLAassistant

CLAassistant commented Dec 10, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ AntonBurchak
❌ Anton_Burchak


Anton_Burchak seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot mentioned this pull request Dec 10, 2021
Ukrainian Translation Progress #1
Open
@AntonBurchak AntonBurchak closed this Dec 10, 2021
@AntonBurchak AntonBurchak reopened this Dec 10, 2021
@AntonBurchak

AntonBurchak commented Dec 10, 2021

Copy link
Copy Markdown
Contributor Author

@tarasyyyk Could you please review it?)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tarasyyyk
tarasyyyk requested changes Dec 12, 2021
View reviewed changes
Comment thread 1-js/11-async/04-promise-error-handling/01-error-async/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/04-promise-error-handling/01-error-async/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/04-promise-error-handling/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/04-promise-error-handling/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread 1-js/11-async/04-promise-error-handling/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot removed the review needed label Dec 12, 2021
@javascript-translate-bot

javascript-translate-bot commented Dec 12, 2021

Copy link
Copy Markdown
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added the changes requested label Dec 12, 2021
AntonBurchak and others added 6 commits December 13, 2021 15:02
@AntonBurchak @tarasyyyk
Update 1-js/11-async/04-promise-error-handling/01-error-async/solutio…
1a81c74
…n.md

Co-authored-by: Taras <[email protected]>
@AntonBurchak @tarasyyyk
Update 1-js/11-async/04-promise-error-handling/article.md
dcb3295
Co-authored-by: Taras <[email protected]>
@AntonBurchak @tarasyyyk
Update 1-js/11-async/04-promise-error-handling/article.md
3a4186a
Co-authored-by: Taras <[email protected]>
@AntonBurchak @tarasyyyk
Update 1-js/11-async/04-promise-error-handling/article.md
45ddf7a
Co-authored-by: Taras <[email protected]>
@AntonBurchak
Resolve suggested improvements
4455444
@AntonBurchak
Merge branch 'translate/promise-error-handling' of https://github.com…
7444722
…/AntonBurchak/uk.javascript.info into translate/promise-error-handling
@AntonBurchak

AntonBurchak commented Dec 13, 2021

Copy link
Copy Markdown
Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@javascript-translate-bot javascript-translate-bot added review needed and removed changes requested labels Dec 13, 2021
@AntonBurchak

AntonBurchak commented Dec 13, 2021

Copy link
Copy Markdown
Contributor Author

@tarasyyyk review it again, please

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tarasyyyk
tarasyyyk approved these changes Dec 13, 2021
View reviewed changes
@javascript-translate-bot javascript-translate-bot added needs +1 and removed review needed labels Dec 13, 2021
@tarasyyyk
tarasyyyk merged commit 99c7f4f into javascript-tutorial:master Dec 13, 2021
@javascript-translate-bot

javascript-translate-bot commented Dec 13, 2021

Copy link
Copy Markdown
Contributor

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

tarasyyyk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tarasyyyk

tarasyyyk commented Dec 13, 2021

Copy link
Copy Markdown
Collaborator

@all-contributors add @AntonBurchak for translation.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@allcontributors allcontributors Bot mentioned this pull request Dec 13, 2021
docs: add AntonBurchak as a contributor for translation #235
Merged
@allcontributors

allcontributors Bot commented Dec 13, 2021

Copy link
Copy Markdown
Contributor

@tarasyyyk

I've put up a pull request to add @AntonBurchak! 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarasyyyk tarasyyyk tarasyyyk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AntonBurchak @CLAassistant @javascript-translate-bot @tarasyyyk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.