GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Drag'n'Drop with mouse events by AntonBurchak · Pull Request #322 · javascript-tutorial/uk.javascript.info

Conversation

AntonBurchak commented Feb 23, 2022

Copy link

Copy Markdown

Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Anton_Burchak and others added 3 commits

December 13, 2021 20:17


          Finished translate "Dynamic imports" article

833a6cd


          Revert "Finished translate "Dynamic imports" article"

b4158fc

This reverts commit 833a6cd.


          added some translations and provided corrections

c843f3d

javascript-translate-bot added the review needed label

Feb 23, 2022

javascript-translate-bot mentioned this pull request

Feb 23, 2022

Ukrainian Translation Progress #1

Open

CLAassistant commented Feb 23, 2022

Copy link

Copy Markdown

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ AntonBurchak
❌ Anton_Burchak

Anton_Burchak seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AntonBurchak commented Feb 23, 2022

Copy link

Copy Markdown

Contributor Author

@tarasyyyk Можеш будь-ласка подивитись?)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dolgachio commented Mar 13, 2022

Copy link

Copy Markdown

Collaborator

@AntonBurchak привіт, для комітів у цьому пулл реквесті ви використала два різні аккаунти:
✅ AntonBurchak
❌ Anton_Burchak
Для того, щоб ми могли прийняти пулл реквест, потрібно додати другого користувача до вашого GitHub аккаунту

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dolgachio added the in progress Translation in progress label

Mar 13, 2022

dolgachio self-requested a review

March 13, 2022 22:23

dolgachio requested changes

Mar 21, 2022

View reviewed changes

dolgachio left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дякую за чудовий переклад! Будя ласка, подивіться на мої коментарі.
Звертаю вашу увагу, що я ще не закінчиві переверку, завершу сьогодні ;)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/1-slider/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/1-slider/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/1-slider/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/1-slider/solution.view/index.html Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/solution.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/solution.view/soccer.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/solution.view/soccer.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/source.view/index.html Outdated


		<p>And one more thing: heroes may never leave the page. If they reach the edge of the document, no dragging outside of it.</p>

		<h2>Розставте супергероїв по полю.</h2>

dolgachio Mar 21, 2022

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Будь ласка, змініть цей файл, відповідно до моїх коменьтарів вище

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/solution.view/index.html Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/task.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added changes requested and removed review needed labels

Mar 21, 2022

javascript-translate-bot commented Mar 21, 2022

Copy link

Copy Markdown

Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dolgachio added the partially reviewed label

Mar 21, 2022

dolgachio requested changes

Mar 21, 2022

View reviewed changes

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

2-ui/3-event-details/4-mouse-drag-and-drop/article.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot commented Mar 21, 2022

Copy link

Copy Markdown

Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dolgachio removed partially reviewed in progress Translation in progress labels

Mar 21, 2022

AntonBurchak and others added 10 commits

March 22, 2022 21:38


          Apply suggestions from code review

8c95048

Co-authored-by: Stanislav <[email protected]>


          Update soccer.js

98e602d


          Update index.html

b966c14


          Update task.md

acaea59


          Update index.html

e0403bd


          Update index.html

016297c


          Update index.html

ea5b2b1


          Apply suggestions from code review

016b25d

Co-authored-by: Stanislav <[email protected]>


          Update article.md

f747b5f


          Update article.md

b90a49a

AntonBurchak requested a review from dolgachio

March 22, 2022 20:30

AntonBurchak commented Mar 22, 2022

Copy link

Copy Markdown

Contributor Author

@stas-dolgachov Дякую за ретельне ревью. Я вніс корективи до перекладу, будь-ласка перевірте

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AntonBurchak commented Mar 25, 2022

Copy link

Copy Markdown

Contributor Author

/done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

javascript-translate-bot added review needed and removed changes requested labels

Mar 25, 2022

dolgachio approved these changes

Mar 26, 2022

View reviewed changes

javascript-translate-bot added needs +1 and removed review needed labels

Mar 26, 2022

dolgachio commented Mar 26, 2022

Copy link

Copy Markdown

Collaborator

Дякую за чудовий переклад!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dolgachio merged commit 8a8d92e into javascript-tutorial:master

Mar 26, 2022

javascript-translate-bot commented Mar 26, 2022

Copy link

Copy Markdown

Contributor

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

dolgachio

dolgachio approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.